* [PATCH] devfreq: rk3399_dmc: fix error code in rk3399_dmcfreq_probe() @ 2017-06-30 7:15 ` Gustavo A. R. Silva 2017-06-30 8:02 ` Chanwoo Choi 0 siblings, 1 reply; 5+ messages in thread From: Gustavo A. R. Silva @ 2017-06-30 7:15 UTC (permalink / raw) To: MyungJoo Ham, Kyungmin Park, Chanwoo Choi Cc: linux-pm, linux-kernel, Gustavo A. R. Silva Print and propagate the return value of platform_get_irq on failure. Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> --- drivers/devfreq/rk3399_dmc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c index 40a2499..1b89ebb 100644 --- a/drivers/devfreq/rk3399_dmc.c +++ b/drivers/devfreq/rk3399_dmc.c @@ -336,8 +336,9 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev) irq = platform_get_irq(pdev, 0); if (irq < 0) { - dev_err(&pdev->dev, "Cannot get the dmc interrupt resource\n"); - return -EINVAL; + dev_err(&pdev->dev, + "Cannot get the dmc interrupt resource: %d\n", irq); + return irq; } data = devm_kzalloc(dev, sizeof(struct rk3399_dmcfreq), GFP_KERNEL); if (!data) -- 2.5.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] devfreq: rk3399_dmc: fix error code in rk3399_dmcfreq_probe() 2017-06-30 7:15 ` [PATCH] devfreq: rk3399_dmc: fix error code in rk3399_dmcfreq_probe() Gustavo A. R. Silva @ 2017-06-30 8:02 ` Chanwoo Choi 2017-07-01 7:50 ` MyungJoo Ham 0 siblings, 1 reply; 5+ messages in thread From: Chanwoo Choi @ 2017-06-30 8:02 UTC (permalink / raw) To: Gustavo A. R. Silva, MyungJoo Ham, Kyungmin Park; +Cc: linux-pm, linux-kernel Hi, On 2017년 06월 30일 16:15, Gustavo A. R. Silva wrote: > Print and propagate the return value of platform_get_irq on failure. > > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> > --- > drivers/devfreq/rk3399_dmc.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c > index 40a2499..1b89ebb 100644 > --- a/drivers/devfreq/rk3399_dmc.c > +++ b/drivers/devfreq/rk3399_dmc.c > @@ -336,8 +336,9 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev) > > irq = platform_get_irq(pdev, 0); > if (irq < 0) { > - dev_err(&pdev->dev, "Cannot get the dmc interrupt resource\n"); > - return -EINVAL; > + dev_err(&pdev->dev, > + "Cannot get the dmc interrupt resource: %d\n", irq); > + return irq; > } > data = devm_kzalloc(dev, sizeof(struct rk3399_dmcfreq), GFP_KERNEL); > if (!data) > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> -- Best Regards, Chanwoo Choi Samsung Electronics ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] devfreq: rk3399_dmc: fix error code in rk3399_dmcfreq_probe() 2017-06-30 8:02 ` Chanwoo Choi @ 2017-07-01 7:50 ` MyungJoo Ham 2017-07-03 12:59 ` [PATCH v2] devfreq: rk3399_dmc: fix error return " Gustavo A. R. Silva 2017-07-17 4:50 ` [PATCH] devfreq: rk3399_dmc: fix error " Gustavo A. R. Silva 0 siblings, 2 replies; 5+ messages in thread From: MyungJoo Ham @ 2017-07-01 7:50 UTC (permalink / raw) To: Chanwoo Choi; +Cc: Gustavo A. R. Silva, Kyungmin Park, Linux PM list, LKML On Fri, Jun 30, 2017 at 5:02 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote: > Hi, > > On 2017년 06월 30일 16:15, Gustavo A. R. Silva wrote: >> Print and propagate the return value of platform_get_irq on failure. >> >> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> >> --- >> drivers/devfreq/rk3399_dmc.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c >> index 40a2499..1b89ebb 100644 >> --- a/drivers/devfreq/rk3399_dmc.c >> +++ b/drivers/devfreq/rk3399_dmc.c >> @@ -336,8 +336,9 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev) >> >> irq = platform_get_irq(pdev, 0); >> if (irq < 0) { >> - dev_err(&pdev->dev, "Cannot get the dmc interrupt resource\n"); >> - return -EINVAL; >> + dev_err(&pdev->dev, >> + "Cannot get the dmc interrupt resource: %d\n", irq); >> + return irq; >> } >> data = devm_kzalloc(dev, sizeof(struct rk3399_dmcfreq), GFP_KERNEL); >> if (!data) >> > > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com> > > -- > Best Regards, > Chanwoo Choi > Samsung Electronics -- MyungJoo Ham, Ph.D. S/W Center, Samsung Electronics ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] devfreq: rk3399_dmc: fix error return code in rk3399_dmcfreq_probe() 2017-07-01 7:50 ` MyungJoo Ham @ 2017-07-03 12:59 ` Gustavo A. R. Silva 2017-07-17 4:50 ` [PATCH] devfreq: rk3399_dmc: fix error " Gustavo A. R. Silva 1 sibling, 0 replies; 5+ messages in thread From: Gustavo A. R. Silva @ 2017-07-03 12:59 UTC (permalink / raw) To: MyungJoo Ham, Kyungmin Park, Chanwoo Choi Cc: linux-pm, linux-kernel, Gustavo A. R. Silva platform_get_irq() returns an error code, but the rk3399_dmc driver ignores it and always returns -EINVAL. This is not correct, and prevents -EPROBE_DEFER from being propagated properly. Notice that platform_get_irq() no longer returns 0 on error: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af Print and propagate the return value of platform_get_irq on failure. Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> --- Changes in v2: Rewrite commit message. drivers/devfreq/rk3399_dmc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c index 40a2499..1b89ebb 100644 --- a/drivers/devfreq/rk3399_dmc.c +++ b/drivers/devfreq/rk3399_dmc.c @@ -336,8 +336,9 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev) irq = platform_get_irq(pdev, 0); if (irq < 0) { - dev_err(&pdev->dev, "Cannot get the dmc interrupt resource\n"); - return -EINVAL; + dev_err(&pdev->dev, + "Cannot get the dmc interrupt resource: %d\n", irq); + return irq; } data = devm_kzalloc(dev, sizeof(struct rk3399_dmcfreq), GFP_KERNEL); if (!data) -- 2.5.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] devfreq: rk3399_dmc: fix error code in rk3399_dmcfreq_probe() 2017-07-01 7:50 ` MyungJoo Ham 2017-07-03 12:59 ` [PATCH v2] devfreq: rk3399_dmc: fix error return " Gustavo A. R. Silva @ 2017-07-17 4:50 ` Gustavo A. R. Silva 1 sibling, 0 replies; 5+ messages in thread From: Gustavo A. R. Silva @ 2017-07-17 4:50 UTC (permalink / raw) To: myungjoo.ham, Chanwoo Choi; +Cc: Kyungmin Park, Linux PM list, LKML On 07/01/2017 02:50 AM, MyungJoo Ham wrote: > On Fri, Jun 30, 2017 at 5:02 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote: >> Hi, >> >> On 2017년 06월 30일 16:15, Gustavo A. R. Silva wrote: >>> Print and propagate the return value of platform_get_irq on failure. >>> >>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> >>> --- >>> drivers/devfreq/rk3399_dmc.c | 5 +++-- >>> 1 file changed, 3 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c >>> index 40a2499..1b89ebb 100644 >>> --- a/drivers/devfreq/rk3399_dmc.c >>> +++ b/drivers/devfreq/rk3399_dmc.c >>> @@ -336,8 +336,9 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev) >>> >>> irq = platform_get_irq(pdev, 0); >>> if (irq < 0) { >>> - dev_err(&pdev->dev, "Cannot get the dmc interrupt resource\n"); >>> - return -EINVAL; >>> + dev_err(&pdev->dev, >>> + "Cannot get the dmc interrupt resource: %d\n", irq); >>> + return irq; >>> } >>> data = devm_kzalloc(dev, sizeof(struct rk3399_dmcfreq), GFP_KERNEL); >>> if (!data) >>> >> >> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> > > Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com> > Thank you, Chanwoo and MyungJoo. -- Gustavo A. R. Silva ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-07-17 4:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20170630071526epcas3p1104189e06db8f2d62622d72dc5f6fdd6@epcas3p1.samsung.com>
2017-06-30 7:15 ` [PATCH] devfreq: rk3399_dmc: fix error code in rk3399_dmcfreq_probe() Gustavo A. R. Silva
2017-06-30 8:02 ` Chanwoo Choi
2017-07-01 7:50 ` MyungJoo Ham
2017-07-03 12:59 ` [PATCH v2] devfreq: rk3399_dmc: fix error return " Gustavo A. R. Silva
2017-07-17 4:50 ` [PATCH] devfreq: rk3399_dmc: fix error " Gustavo A. R. Silva
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).