From: "Du, Changbin" <changbin.du@intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: "Du, Changbin" <changbin.du@intel.com>,
jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] perf sort: only insert overhead && overhead_children when no overhead* field given
Date: Wed, 5 Jul 2017 11:02:51 +0800 [thread overview]
Message-ID: <20170705030251.GA23139@intel.com> (raw)
In-Reply-To: <20170629152252.GA1463@krava>
[-- Attachment #1: Type: text/plain, Size: 843 bytes --]
On Thu, Jun 29, 2017 at 05:22:52PM +0200, Jiri Olsa wrote:
> > > --- a/tools/perf/util/sort.c
> > > +++ b/tools/perf/util/sort.c
> > > @@ -2635,6 +2635,9 @@ static char *setup_overhead(char *keys)
> > > if (sort__mode == SORT_MODE__DIFF)
> > > return keys;
> > >
> > > + if (strstr(keys, "overhead"))
> > > + return keys;
> > > +
>
> ah ok, I think it's right.. basically you're forcing
> precedence of the -s option over the --children option
>
> you could have your example working by running:
> $ perf report -s overhead,sym --no-children
>
Thanks for the knowledge.
> please state something like:
>
> /*
> * User already stated overhead within -s option,
> * do not mangle with that.
> */
>
I'll add this as comment around the change for v3.
> thanks,
> jirka
--
Thanks,
Changbin Du
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2017-07-05 3:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 9:03 [PATCH] perf sort: only insert overhead && overhead_children when no overhead* field given changbin.du
2017-06-01 10:21 ` Jiri Olsa
2017-06-02 2:52 ` Du, Changbin
2017-06-02 3:22 ` Du, Changbin
2017-06-02 4:22 ` [PATCH v2] " changbin.du
2017-06-26 8:06 ` Du, Changbin
2017-06-29 15:22 ` Jiri Olsa
2017-07-05 3:02 ` Du, Changbin [this message]
2017-07-05 3:35 ` [PATCH v3] " changbin.du
2017-07-06 16:04 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170705030251.GA23139@intel.com \
--to=changbin.du@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).