From: Jiri Olsa <jolsa@redhat.com>
To: changbin.du@intel.com
Cc: jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] perf sort: only insert overhead && overhead_children when no overhead* field given
Date: Thu, 6 Jul 2017 18:04:10 +0200 [thread overview]
Message-ID: <20170706160410.GA3227@krava> (raw)
In-Reply-To: <1499225752-2959-1-git-send-email-changbin.du@intel.com>
On Wed, Jul 05, 2017 at 11:35:52AM +0800, changbin.du@intel.com wrote:
> From: Changbin Du <changbin.du@intel.com>
>
> If we always insert 'overhead' and 'overhead_children' as sort keys,
> this make it impossible to sort as overhead (which displayed as Self)
> first.Ths will be a problem if the data is collected with call-graph
> enabled. Then we never can sort the result as self-overhead on this
> data. And sometimes the data is hard to collect.
>
> > perf record -ag
> > perf report -s overhead,sym
>
> Samples: 7K of event 'cycles', Event count (approx.): 865138253
> Children Self Symbol
> + 26.41% 0.00% [k] verify_cpu
> + 26.37% 0.04% [k] cpu_startup_entry
> + 25.93% 0.27% [k] do_idle
> + 19.88% 0.00% [k] start_secondary
> ....
>
> I intend to sort as 'Self', but actually it sort as 'Children'.
>
> This patch fix this by only insert overhead && overhead_children
> when no overhead* field given.
>
> Signed-off-by: Changbin Du <changbin.du@intel.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
> ---
> v3: Add comment in code from Jiri
> v2: Add the example in commit message.
>
> ---
> tools/perf/util/sort.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
> index 8b327c9..9e087fb 100644
> --- a/tools/perf/util/sort.c
> +++ b/tools/perf/util/sort.c
> @@ -2635,6 +2635,13 @@ static char *setup_overhead(char *keys)
> if (sort__mode == SORT_MODE__DIFF)
> return keys;
>
> + /**
> + * User already stated overhead within -s option,
> + * do not mangle with that.
> + */
> + if (strstr(keys, "overhead"))
> + return keys;
> +
> keys = prefix_if_not_in("overhead", keys);
>
> if (symbol_conf.cumulate_callchain)
> --
> 2.7.4
>
prev parent reply other threads:[~2017-07-06 16:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 9:03 [PATCH] perf sort: only insert overhead && overhead_children when no overhead* field given changbin.du
2017-06-01 10:21 ` Jiri Olsa
2017-06-02 2:52 ` Du, Changbin
2017-06-02 3:22 ` Du, Changbin
2017-06-02 4:22 ` [PATCH v2] " changbin.du
2017-06-26 8:06 ` Du, Changbin
2017-06-29 15:22 ` Jiri Olsa
2017-07-05 3:02 ` Du, Changbin
2017-07-05 3:35 ` [PATCH v3] " changbin.du
2017-07-06 16:04 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170706160410.GA3227@krava \
--to=jolsa@redhat.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=changbin.du@intel.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).