* [PATCH] mfd: intel_soc_pmic_chtwc: Turn Kconfig option into a bool
@ 2017-06-23 8:29 Hans de Goede
2017-07-13 8:06 ` Lee Jones
2017-07-17 11:04 ` Lee Jones
0 siblings, 2 replies; 4+ messages in thread
From: Hans de Goede @ 2017-06-23 8:29 UTC (permalink / raw)
To: Lee Jones; +Cc: Hans de Goede, linux-kernel
The PMIC provides ACPI OpRegions which must be available for other
drivers' PS0 / PS3 methods early-on as such it must be builtin as the
Kconfig help text already states.
Somehow its Kconfig option ended up being a tristate though, this fixes
this.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
Note, feel free to squash this in the original commit if you wish
---
drivers/mfd/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 8533cb46a875..be962d128f31 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -476,7 +476,7 @@ config INTEL_SOC_PMIC_BXTWC
on these systems.
config INTEL_SOC_PMIC_CHTWC
- tristate "Support for Intel Cherry Trail Whiskey Cove PMIC"
+ bool "Support for Intel Cherry Trail Whiskey Cove PMIC"
depends on ACPI && HAS_IOMEM && I2C=y && COMMON_CLK
depends on X86 || COMPILE_TEST
select MFD_CORE
--
2.13.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mfd: intel_soc_pmic_chtwc: Turn Kconfig option into a bool
2017-06-23 8:29 [PATCH] mfd: intel_soc_pmic_chtwc: Turn Kconfig option into a bool Hans de Goede
@ 2017-07-13 8:06 ` Lee Jones
2017-07-17 11:04 ` Lee Jones
1 sibling, 0 replies; 4+ messages in thread
From: Lee Jones @ 2017-07-13 8:06 UTC (permalink / raw)
To: Hans de Goede; +Cc: linux-kernel
On Fri, 23 Jun 2017, Hans de Goede wrote:
> The PMIC provides ACPI OpRegions which must be available for other
> drivers' PS0 / PS3 methods early-on as such it must be builtin as the
> Kconfig help text already states.
>
> Somehow its Kconfig option ended up being a tristate though, this fixes
> this.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> Note, feel free to squash this in the original commit if you wish
> ---
> drivers/mfd/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 8533cb46a875..be962d128f31 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -476,7 +476,7 @@ config INTEL_SOC_PMIC_BXTWC
> on these systems.
>
> config INTEL_SOC_PMIC_CHTWC
> - tristate "Support for Intel Cherry Trail Whiskey Cove PMIC"
> + bool "Support for Intel Cherry Trail Whiskey Cove PMIC"
> depends on ACPI && HAS_IOMEM && I2C=y && COMMON_CLK
> depends on X86 || COMPILE_TEST
> select MFD_CORE
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mfd: intel_soc_pmic_chtwc: Turn Kconfig option into a bool
2017-06-23 8:29 [PATCH] mfd: intel_soc_pmic_chtwc: Turn Kconfig option into a bool Hans de Goede
2017-07-13 8:06 ` Lee Jones
@ 2017-07-17 11:04 ` Lee Jones
2017-07-21 22:16 ` Hans de Goede
1 sibling, 1 reply; 4+ messages in thread
From: Lee Jones @ 2017-07-17 11:04 UTC (permalink / raw)
To: Hans de Goede; +Cc: linux-kernel
On Fri, 23 Jun 2017, Hans de Goede wrote:
> The PMIC provides ACPI OpRegions which must be available for other
> drivers' PS0 / PS3 methods early-on as such it must be builtin as the
> Kconfig help text already states.
>
> Somehow its Kconfig option ended up being a tristate though, this fixes
> this.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> Note, feel free to squash this in the original commit if you wish
Looks like the original commit is yet to be accepted.
Please ensure it's squashed in and resubmit.
> ---
> drivers/mfd/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 8533cb46a875..be962d128f31 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -476,7 +476,7 @@ config INTEL_SOC_PMIC_BXTWC
> on these systems.
>
> config INTEL_SOC_PMIC_CHTWC
> - tristate "Support for Intel Cherry Trail Whiskey Cove PMIC"
> + bool "Support for Intel Cherry Trail Whiskey Cove PMIC"
> depends on ACPI && HAS_IOMEM && I2C=y && COMMON_CLK
> depends on X86 || COMPILE_TEST
> select MFD_CORE
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mfd: intel_soc_pmic_chtwc: Turn Kconfig option into a bool
2017-07-17 11:04 ` Lee Jones
@ 2017-07-21 22:16 ` Hans de Goede
0 siblings, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2017-07-21 22:16 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel
Hi,
On 17-07-17 13:04, Lee Jones wrote:
> On Fri, 23 Jun 2017, Hans de Goede wrote:
>
>> The PMIC provides ACPI OpRegions which must be available for other
>> drivers' PS0 / PS3 methods early-on as such it must be builtin as the
>> Kconfig help text already states.
>>
>> Somehow its Kconfig option ended up being a tristate though, this fixes
>> this.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>> Note, feel free to squash this in the original commit if you wish
>
> Looks like the original commit is yet to be accepted.
The original commit is already in Linus' tree:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/mfd?id=de85d79f4aab67fe0537dd6e2c5d545b88239cc4
Regards,
Hans
>
> Please ensure it's squashed in and resubmit.
>
>> ---
>> drivers/mfd/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
>> index 8533cb46a875..be962d128f31 100644
>> --- a/drivers/mfd/Kconfig
>> +++ b/drivers/mfd/Kconfig
>> @@ -476,7 +476,7 @@ config INTEL_SOC_PMIC_BXTWC
>> on these systems.
>>
>> config INTEL_SOC_PMIC_CHTWC
>> - tristate "Support for Intel Cherry Trail Whiskey Cove PMIC"
>> + bool "Support for Intel Cherry Trail Whiskey Cove PMIC"
>> depends on ACPI && HAS_IOMEM && I2C=y && COMMON_CLK
>> depends on X86 || COMPILE_TEST
>> select MFD_CORE
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-07-21 22:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-23 8:29 [PATCH] mfd: intel_soc_pmic_chtwc: Turn Kconfig option into a bool Hans de Goede
2017-07-13 8:06 ` Lee Jones
2017-07-17 11:04 ` Lee Jones
2017-07-21 22:16 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).