[PATCH] usb: quirks: Add no-lpm quirk for Moshi USB to Ethernet Adapter

[PATCH] usb: quirks: Add no-lpm quirk for Moshi USB to Ethernet Adapter

[Kai-Heng Feng]

The Realtek r8153 ethernet does not work on Genesys Logic hub, no-lpm
quirk can make it work.

Since another r8153 dongle at my hand does not have the issue, so add
the quirk to the hub instead.

Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
 drivers/usb/core/quirks.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 3116edfcdc18..c96daf34431e 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -150,6 +150,9 @@ static const struct usb_device_id usb_quirk_list[] = {
 	/* appletouch */
 	{ USB_DEVICE(0x05ac, 0x021a), .driver_info = USB_QUIRK_RESET_RESUME },
 
+	/* Moshi USB to Ethernet Adapter */
+	{ USB_DEVICE(0x05e3, 0x0616), .driver_info = USB_QUIRK_NO_LPM },
+
 	/* Avision AV600U */
 	{ USB_DEVICE(0x0638, 0x0a13), .driver_info =
 	  USB_QUIRK_STRING_FETCH_255 },
-- 
2.13.4

Re: [PATCH] usb: quirks: Add no-lpm quirk for Moshi USB to Ethernet Adapter

[Oliver Neukum]

Am Freitag, den 04.08.2017, 17:34 +0800 schrieb Kai-Heng Feng:
> The Realtek r8153 ethernet does not work on Genesys Logic hub, no-lpm
> quirk can make it work.

So can you confirm it works with LPM on another hub?

> Since another r8153 dongle at my hand does not have the issue, so add
> the quirk to the hub instead.

This does not match the comment in the patch. This needs to
be clarified.

	Regards
		Oliver

Re: [PATCH] usb: quirks: Add no-lpm quirk for Moshi USB to Ethernet Adapter

[Kai-Heng Feng]

On Mon, Aug 7, 2017 at 5:08 PM, Oliver Neukum <oneukum@suse.com> wrote:
> Am Freitag, den 04.08.2017, 17:34 +0800 schrieb Kai-Heng Feng:
>> The Realtek r8153 ethernet does not work on Genesys Logic hub, no-lpm
>> quirk can make it work.
>
> So can you confirm it works with LPM on another hub?

Yes, another r8153 dongle (Dell Type-C to Ethernet) does not have this issue.

>
>> Since another r8153 dongle at my hand does not have the issue, so add
>> the quirk to the hub instead.
>
> This does not match the comment in the patch. This needs to
> be clarified.

The Moshi USB to Ethernet Adapter internally has a Genesys Logic hub.
Ethernet chip r8153 is connected to the Genesys Logic hub.

I'll resend a patch with this information if it's clear enough.

>
>         Regards
>                 Oliver
>

Re: [PATCH] usb: quirks: Add no-lpm quirk for Moshi USB to Ethernet Adapter

[Oliver Neukum]

Am Montag, den 07.08.2017, 17:33 +0800 schrieb Kai-Heng Feng:
> On Mon, Aug 7, 2017 at 5:08 PM, Oliver Neukum <oneukum@suse.com> wrote:
> > 
> > Am Freitag, den 04.08.2017, 17:34 +0800 schrieb Kai-Heng Feng:
> > > 
> > > The Realtek r8153 ethernet does not work on Genesys Logic hub, no-lpm
> > > quirk can make it work.
> > 
> > So can you confirm it works with LPM on another hub?
> 
> Yes, another r8153 dongle (Dell Type-C to Ethernet) does not have this issue.

OK.

> > 
> > 
> > > 
> > > Since another r8153 dongle at my hand does not have the issue, so add
> > > the quirk to the hub instead.
> > 
> > This does not match the comment in the patch. This needs to
> > be clarified.
> 
> The Moshi USB to Ethernet Adapter internally has a Genesys Logic hub.
> Ethernet chip r8153 is connected to the Genesys Logic hub.
> 
> I'll resend a patch with this information if it's clear enough.

Thanks. The piece about an internal hub was missing.

	Regards
		Oliver