linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@kernel.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: "Colm MacCárthaigh" <colm@allcosts.net>,
	"Kees Cook" <keescook@chromium.org>,
	"Mike Kravetz" <mike.kravetz@oracle.com>,
	"Rik van Riel" <riel@redhat.com>,
	"Will Drewry" <wad@chromium.org>,
	akpm@linux-foundation.org, dave.hansen@intel.com,
	kirill@shutemov.name, linux-api@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	luto@amacapital.net, mingo@kernel.org
Subject: Re: [PATCH v2 0/2] mm,fork,security: introduce MADV_WIPEONFORK
Date: Fri, 11 Aug 2017 16:24:57 +0200	[thread overview]
Message-ID: <20170811142457.GP30811@dhcp22.suse.cz> (raw)
In-Reply-To: <c8cda773-b28d-f35f-7f18-6735584cb173@redhat.com>

On Fri 11-08-17 16:11:44, Florian Weimer wrote:
> On 08/11/2017 04:06 PM, Michal Hocko wrote:
> 
> > I am sorry to look too insisting here (I have still hard time to reconcile
> > myself with the madvise (ab)use) but if we in fact want minherit like
> > interface why don't we simply add minherit and make the code which wants
> > to use that interface easier to port? Is the only reason that hooking
> > into madvise is less code? If yes is that a sufficient reason to justify
> > the (ab)use of madvise? If there is a general consensus on that part I
> > will shut up and won't object anymore. Arguably MADV_DONTFORK would fit
> > into minherit API better as well.
> 
> It does, OpenBSD calls it MAP_INHERIT_NONE.
> 
> Could you implement MAP_INHERIT_COPY and MAP_INHERIT_SHARE as well?  Or
> is changing from MAP_SHARED to MAP_PRIVATE and back impossible?

I haven't explored those two very much. Their semantic seems rather
awkward, especially map_inherit_share one. I guess MAP_INHERIT_COPY
would be doable. Do we have to support all modes or a missing support
would disqualify the syscall completely?
-- 
Michal Hocko
SUSE Labs

  reply	other threads:[~2017-08-11 14:25 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-06 14:04 [PATCH v2 0/2] mm,fork,security: introduce MADV_WIPEONFORK riel
2017-08-06 14:04 ` [PATCH 1/2] x86,mpx: make mpx depend on x86-64 to free up VMA flag riel
2017-08-06 14:04 ` [PATCH 2/2] mm,fork: introduce MADV_WIPEONFORK riel
2017-08-10 15:23   ` Michal Hocko
2017-08-11 15:23     ` Rik van Riel
2017-08-11 16:36       ` Mike Kravetz
2017-08-11 16:59         ` Rik van Riel
2017-08-11 17:07           ` Mike Kravetz
2017-08-07 13:22 ` [PATCH v2 0/2] mm,fork,security: " Michal Hocko
2017-08-07 13:46   ` Michal Hocko
2017-08-07 14:19     ` Florian Weimer
2017-08-10 13:06       ` Michal Hocko
2017-08-07 14:59     ` Rik van Riel
2017-08-09  9:59       ` Kirill A. Shutemov
2017-08-09 12:31         ` Rik van Riel
2017-08-09 12:42         ` Florian Weimer
2017-08-10 13:05       ` Michal Hocko
2017-08-10 13:23         ` Colm MacCárthaigh
2017-08-10 15:36           ` Michal Hocko
     [not found]             ` <CAAF6GDeno6RpHf1KORVSxUL7M-CQfbWFFdyKK8LAWd_6PcJ55Q@mail.gmail.com>
2017-08-10 17:01               ` Michal Hocko
2017-08-10 22:09                 ` Colm MacCárthaigh
2017-08-11 14:06                   ` Michal Hocko
2017-08-11 14:11                     ` Florian Weimer
2017-08-11 14:24                       ` Michal Hocko [this message]
2017-08-11 15:24                         ` Florian Weimer
2017-08-11 15:31                           ` Michal Hocko
     [not found]     ` <CAAF6GDcNoDUaDSxV6N12A_bOzo8phRUX5b8-OBteuN0AmeCv0g@mail.gmail.com>
2017-08-07 16:02       ` Colm MacCárthaigh
2017-08-10 13:21       ` Michal Hocko
2017-08-10 14:11         ` Michal Hocko
2017-08-07 18:23 ` Mike Kravetz
2017-08-08  9:58   ` Florian Weimer
2017-08-08 13:15     ` Rik van Riel
2017-08-08 15:19       ` Mike Kravetz
2017-08-08 15:22         ` Florian Weimer
2017-08-08 15:46         ` Rik van Riel
2017-08-08 16:48           ` Colm MacCárthaigh
2017-08-08 16:52           ` Matthew Wilcox
2017-08-08 18:45             ` Rik van Riel
2017-08-10 15:31               ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170811142457.GP30811@dhcp22.suse.cz \
    --to=mhocko@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=colm@allcosts.net \
    --cc=dave.hansen@intel.com \
    --cc=fweimer@redhat.com \
    --cc=keescook@chromium.org \
    --cc=kirill@shutemov.name \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=luto@amacapital.net \
    --cc=mike.kravetz@oracle.com \
    --cc=mingo@kernel.org \
    --cc=riel@redhat.com \
    --cc=wad@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).