From: Rob Herring <robh@kernel.org>
To: Lin Huang <hl@rock-chips.com>
Cc: dmitry.torokhov@gmail.com, jikos@kernel.org,
benjamin.tissoires@redhat.com, jani.nikula@intel.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
briannorris@chromium.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/2] devicetree: i2c-hid: Add reset property
Date: Wed, 1 Nov 2017 17:02:08 -0500 [thread overview]
Message-ID: <20171101220208.gixv6anohp5q4kh2@rob-hp-laptop> (raw)
In-Reply-To: <1509418996-25348-2-git-send-email-hl@rock-chips.com>
On Tue, Oct 31, 2017 at 11:03:16AM +0800, Lin Huang wrote:
> Document a "reset" and "assert-reset-us", it can be used for
> driver control reset property. And reuse post-power-on-delay-ms
> for deassert reset delay.
"dt-bindings: input: " for the subject please.
>
> Signed-off-by: Lin Huang <hl@rock-chips.com>
> ---
> Documentation/devicetree/bindings/input/hid-over-i2c.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/input/hid-over-i2c.txt b/Documentation/devicetree/bindings/input/hid-over-i2c.txt
> index 28e8bd8..6ab0eed 100644
> --- a/Documentation/devicetree/bindings/input/hid-over-i2c.txt
> +++ b/Documentation/devicetree/bindings/input/hid-over-i2c.txt
> @@ -31,7 +31,9 @@ device-specific compatible properties, which should be used in addition to the
>
> - vdd-supply: phandle of the regulator that provides the supply voltage.
> - post-power-on-delay-ms: time required by the device after enabling its regulators
> - before it is ready for communication. Must be used with 'vdd-supply'.
> + or deassert reset pin before it is ready for communication.
> +- reset: phandle of the gpio that provides for hid reset pin.
The kernel api takes "reset", but the property is "reset-gpios".
And it's not just a phandle typically.
> +- assert-reset-us: the device require reset assert time.
>
> Example:
>
> --
> 2.7.4
>
next prev parent reply other threads:[~2017-11-01 22:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 3:03 [PATCH v2 1/2] HID: i2c-hid: add reset gpio property Lin Huang
2017-10-31 3:03 ` [PATCH v2 2/2] devicetree: i2c-hid: Add reset property Lin Huang
2017-11-01 22:02 ` Rob Herring [this message]
2017-11-06 9:06 ` Benjamin Tissoires
2017-11-06 16:10 ` Dmitry Torokhov
2017-11-04 4:35 ` Brian Norris
2017-11-06 1:00 ` hl
2017-10-31 8:47 ` [PATCH v2 1/2] HID: i2c-hid: add reset gpio property Jani Nikula
2017-11-04 2:29 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171101220208.gixv6anohp5q4kh2@rob-hp-laptop \
--to=robh@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=briannorris@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hl@rock-chips.com \
--cc=jani.nikula@intel.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).