linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brian Norris <briannorris@chromium.org>
To: Lin Huang <hl@rock-chips.com>
Cc: dmitry.torokhov@gmail.com, jikos@kernel.org, robh@kernel.org,
	benjamin.tissoires@redhat.com, linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] HID: i2c-hid: add reset gpio property
Date: Fri, 3 Nov 2017 19:29:35 -0700	[thread overview]
Message-ID: <20171104022934.GA110548@google.com> (raw)
In-Reply-To: <1509418996-25348-1-git-send-email-hl@rock-chips.com>

On Tue, Oct 31, 2017 at 11:03:15AM +0800, Lin Huang wrote:
> some i2c hid devices have reset gpio, need to control
> it in the driver.
> 
> Signed-off-by: Lin Huang <hl@rock-chips.com>
> ---
> Changes in v2:
> - Add 10us in usleep_range() upper range
> - reuse post_power_delay_ms as deassert reset delay
> - delete deassert_reset_us property
> 
>  drivers/hid/i2c-hid/i2c-hid.c         | 61 +++++++++++++++++++++++++++--------
>  include/linux/platform_data/i2c-hid.h |  3 ++
>  2 files changed, 50 insertions(+), 14 deletions(-)

Reviewed-by: Brian Norris <briannorris@chromium.org>

      parent reply	other threads:[~2017-11-04  2:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-31  3:03 [PATCH v2 1/2] HID: i2c-hid: add reset gpio property Lin Huang
2017-10-31  3:03 ` [PATCH v2 2/2] devicetree: i2c-hid: Add reset property Lin Huang
2017-11-01 22:02   ` Rob Herring
2017-11-06  9:06     ` Benjamin Tissoires
2017-11-06 16:10       ` Dmitry Torokhov
2017-11-04  4:35   ` Brian Norris
2017-11-06  1:00     ` hl
2017-10-31  8:47 ` [PATCH v2 1/2] HID: i2c-hid: add reset gpio property Jani Nikula
2017-11-04  2:29 ` Brian Norris [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171104022934.GA110548@google.com \
    --to=briannorris@chromium.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hl@rock-chips.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).