* [PATCH] pci: dwc: pci-dra7xx: Make shutdown handler static
@ 2017-12-01 5:06 Vignesh R
2017-12-01 5:13 ` Keerthy
2017-12-20 11:11 ` Lorenzo Pieralisi
0 siblings, 2 replies; 6+ messages in thread
From: Vignesh R @ 2017-12-01 5:06 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Kishon Vijay Abraham I, Lorenzo Pieralisi, linux-omap, linux-pci,
linux-kernel, Vignesh R
Declare dra7xx_pcie_shutdown() as a static function as its not used
elsewhere.
Signed-off-by: Vignesh R <vigneshr@ti.com>
---
drivers/pci/dwc/pci-dra7xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
index 59e8de34cec6..b9db442af793 100644
--- a/drivers/pci/dwc/pci-dra7xx.c
+++ b/drivers/pci/dwc/pci-dra7xx.c
@@ -815,7 +815,7 @@ static int dra7xx_pcie_resume_noirq(struct device *dev)
}
#endif
-void dra7xx_pcie_shutdown(struct platform_device *pdev)
+static void dra7xx_pcie_shutdown(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
struct dra7xx_pcie *dra7xx = dev_get_drvdata(dev);
--
2.15.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] pci: dwc: pci-dra7xx: Make shutdown handler static
2017-12-01 5:06 [PATCH] pci: dwc: pci-dra7xx: Make shutdown handler static Vignesh R
@ 2017-12-01 5:13 ` Keerthy
2017-12-01 16:53 ` Lorenzo Pieralisi
2017-12-20 11:11 ` Lorenzo Pieralisi
1 sibling, 1 reply; 6+ messages in thread
From: Keerthy @ 2017-12-01 5:13 UTC (permalink / raw)
To: Vignesh R, Bjorn Helgaas
Cc: Kishon Vijay Abraham I, Lorenzo Pieralisi, linux-omap, linux-pci,
linux-kernel
On Friday 01 December 2017 10:36 AM, Vignesh R wrote:
> Declare dra7xx_pcie_shutdown() as a static function as its not used
> elsewhere.
Seems like the below version that had static version was not taken:
https://patchwork.kernel.org/patch/10052579/
So for this patch:
Reviewed-by: Keerthy <j-keerthy@ti.com>
>
> Signed-off-by: Vignesh R <vigneshr@ti.com>
> ---
> drivers/pci/dwc/pci-dra7xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
> index 59e8de34cec6..b9db442af793 100644
> --- a/drivers/pci/dwc/pci-dra7xx.c
> +++ b/drivers/pci/dwc/pci-dra7xx.c
> @@ -815,7 +815,7 @@ static int dra7xx_pcie_resume_noirq(struct device *dev)
> }
> #endif
>
> -void dra7xx_pcie_shutdown(struct platform_device *pdev)
> +static void dra7xx_pcie_shutdown(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct dra7xx_pcie *dra7xx = dev_get_drvdata(dev);
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] pci: dwc: pci-dra7xx: Make shutdown handler static
2017-12-01 5:13 ` Keerthy
@ 2017-12-01 16:53 ` Lorenzo Pieralisi
2017-12-20 10:29 ` Lorenzo Pieralisi
0 siblings, 1 reply; 6+ messages in thread
From: Lorenzo Pieralisi @ 2017-12-01 16:53 UTC (permalink / raw)
To: Keerthy
Cc: Vignesh R, Bjorn Helgaas, Kishon Vijay Abraham I, linux-omap,
linux-pci, linux-kernel
On Fri, Dec 01, 2017 at 10:43:53AM +0530, Keerthy wrote:
>
>
> On Friday 01 December 2017 10:36 AM, Vignesh R wrote:
> > Declare dra7xx_pcie_shutdown() as a static function as its not used
> > elsewhere.
>
> Seems like the below version that had static version was not taken:
>
> https://patchwork.kernel.org/patch/10052579/
It looks like I can drop the patch above then - let me know if
that's ok.
Thanks,
Lorenzo
> So for this patch:
>
> Reviewed-by: Keerthy <j-keerthy@ti.com>
>
> >
> > Signed-off-by: Vignesh R <vigneshr@ti.com>
> > ---
> > drivers/pci/dwc/pci-dra7xx.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
> > index 59e8de34cec6..b9db442af793 100644
> > --- a/drivers/pci/dwc/pci-dra7xx.c
> > +++ b/drivers/pci/dwc/pci-dra7xx.c
> > @@ -815,7 +815,7 @@ static int dra7xx_pcie_resume_noirq(struct device *dev)
> > }
> > #endif
> >
> > -void dra7xx_pcie_shutdown(struct platform_device *pdev)
> > +static void dra7xx_pcie_shutdown(struct platform_device *pdev)
> > {
> > struct device *dev = &pdev->dev;
> > struct dra7xx_pcie *dra7xx = dev_get_drvdata(dev);
> >
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] pci: dwc: pci-dra7xx: Make shutdown handler static
2017-12-01 16:53 ` Lorenzo Pieralisi
@ 2017-12-20 10:29 ` Lorenzo Pieralisi
2017-12-20 11:59 ` Keerthy
0 siblings, 1 reply; 6+ messages in thread
From: Lorenzo Pieralisi @ 2017-12-20 10:29 UTC (permalink / raw)
To: Keerthy
Cc: Vignesh R, Bjorn Helgaas, Kishon Vijay Abraham I, linux-omap,
linux-pci, linux-kernel
On Fri, Dec 01, 2017 at 04:53:14PM +0000, Lorenzo Pieralisi wrote:
> On Fri, Dec 01, 2017 at 10:43:53AM +0530, Keerthy wrote:
> >
> >
> > On Friday 01 December 2017 10:36 AM, Vignesh R wrote:
> > > Declare dra7xx_pcie_shutdown() as a static function as its not used
> > > elsewhere.
> >
> > Seems like the below version that had static version was not taken:
> >
> > https://patchwork.kernel.org/patch/10052579/
>
> It looks like I can drop the patch above then - let me know if
> that's ok.
I would appreciate some feedback; I assume that dropping the patch above
and applying the patch in $SUBJECT is what you expect, if there is a
problem with that please manifest yourselves.
Lorenzo
> Thanks,
> Lorenzo
>
> > So for this patch:
> >
> > Reviewed-by: Keerthy <j-keerthy@ti.com>
> >
> > >
> > > Signed-off-by: Vignesh R <vigneshr@ti.com>
> > > ---
> > > drivers/pci/dwc/pci-dra7xx.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
> > > index 59e8de34cec6..b9db442af793 100644
> > > --- a/drivers/pci/dwc/pci-dra7xx.c
> > > +++ b/drivers/pci/dwc/pci-dra7xx.c
> > > @@ -815,7 +815,7 @@ static int dra7xx_pcie_resume_noirq(struct device *dev)
> > > }
> > > #endif
> > >
> > > -void dra7xx_pcie_shutdown(struct platform_device *pdev)
> > > +static void dra7xx_pcie_shutdown(struct platform_device *pdev)
> > > {
> > > struct device *dev = &pdev->dev;
> > > struct dra7xx_pcie *dra7xx = dev_get_drvdata(dev);
> > >
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] pci: dwc: pci-dra7xx: Make shutdown handler static
2017-12-20 10:29 ` Lorenzo Pieralisi
@ 2017-12-20 11:59 ` Keerthy
0 siblings, 0 replies; 6+ messages in thread
From: Keerthy @ 2017-12-20 11:59 UTC (permalink / raw)
To: Lorenzo Pieralisi
Cc: Vignesh R, Bjorn Helgaas, Kishon Vijay Abraham I, linux-omap,
linux-pci, linux-kernel
On Wednesday 20 December 2017 03:59 PM, Lorenzo Pieralisi wrote:
> On Fri, Dec 01, 2017 at 04:53:14PM +0000, Lorenzo Pieralisi wrote:
>> On Fri, Dec 01, 2017 at 10:43:53AM +0530, Keerthy wrote:
>>>
>>>
>>> On Friday 01 December 2017 10:36 AM, Vignesh R wrote:
>>>> Declare dra7xx_pcie_shutdown() as a static function as its not used
>>>> elsewhere.
>>>
>>> Seems like the below version that had static version was not taken:
>>>
>>> https://patchwork.kernel.org/patch/10052579/
>>
>> It looks like I can drop the patch above then - let me know if
>> that's ok.
>
> I would appreciate some feedback; I assume that dropping the patch above
> and applying the patch in $SUBJECT is what you expect, if there is a
> problem with that please manifest yourselves.
Applying this patch is fine. Thanks.
>
> Lorenzo
>
>> Thanks,
>> Lorenzo
>>
>>> So for this patch:
>>>
>>> Reviewed-by: Keerthy <j-keerthy@ti.com>
>>>
>>>>
>>>> Signed-off-by: Vignesh R <vigneshr@ti.com>
>>>> ---
>>>> drivers/pci/dwc/pci-dra7xx.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
>>>> index 59e8de34cec6..b9db442af793 100644
>>>> --- a/drivers/pci/dwc/pci-dra7xx.c
>>>> +++ b/drivers/pci/dwc/pci-dra7xx.c
>>>> @@ -815,7 +815,7 @@ static int dra7xx_pcie_resume_noirq(struct device *dev)
>>>> }
>>>> #endif
>>>>
>>>> -void dra7xx_pcie_shutdown(struct platform_device *pdev)
>>>> +static void dra7xx_pcie_shutdown(struct platform_device *pdev)
>>>> {
>>>> struct device *dev = &pdev->dev;
>>>> struct dra7xx_pcie *dra7xx = dev_get_drvdata(dev);
>>>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] pci: dwc: pci-dra7xx: Make shutdown handler static
2017-12-01 5:06 [PATCH] pci: dwc: pci-dra7xx: Make shutdown handler static Vignesh R
2017-12-01 5:13 ` Keerthy
@ 2017-12-20 11:11 ` Lorenzo Pieralisi
1 sibling, 0 replies; 6+ messages in thread
From: Lorenzo Pieralisi @ 2017-12-20 11:11 UTC (permalink / raw)
To: Vignesh R
Cc: Bjorn Helgaas, Kishon Vijay Abraham I, linux-omap, linux-pci,
linux-kernel
On Fri, Dec 01, 2017 at 10:36:52AM +0530, Vignesh R wrote:
> Declare dra7xx_pcie_shutdown() as a static function as its not used
> elsewhere.
>
> Signed-off-by: Vignesh R <vigneshr@ti.com>
> ---
> drivers/pci/dwc/pci-dra7xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to pci/dwc for v4.16.
Thanks,
Lorenzo
> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
> index 59e8de34cec6..b9db442af793 100644
> --- a/drivers/pci/dwc/pci-dra7xx.c
> +++ b/drivers/pci/dwc/pci-dra7xx.c
> @@ -815,7 +815,7 @@ static int dra7xx_pcie_resume_noirq(struct device *dev)
> }
> #endif
>
> -void dra7xx_pcie_shutdown(struct platform_device *pdev)
> +static void dra7xx_pcie_shutdown(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct dra7xx_pcie *dra7xx = dev_get_drvdata(dev);
> --
> 2.15.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-12-20 11:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-01 5:06 [PATCH] pci: dwc: pci-dra7xx: Make shutdown handler static Vignesh R
2017-12-01 5:13 ` Keerthy
2017-12-01 16:53 ` Lorenzo Pieralisi
2017-12-20 10:29 ` Lorenzo Pieralisi
2017-12-20 11:59 ` Keerthy
2017-12-20 11:11 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).