* [PATCH] tpm: remove unused data fields from I2C and OF device ID tables
@ 2017-12-22 10:26 Javier Martinez Canillas
2017-12-22 16:06 ` Jason Gunthorpe
0 siblings, 1 reply; 2+ messages in thread
From: Javier Martinez Canillas @ 2017-12-22 10:26 UTC (permalink / raw)
To: linux-kernel
Cc: Javier Martinez Canillas, Arnd Bergmann, Jarkko Sakkinen,
Peter Huewe, Jason Gunthorpe, Greg Kroah-Hartman,
linux-integrity
The data field for the entries in the device tables are set but not used.
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---
drivers/char/tpm/tpm_i2c_infineon.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/char/tpm/tpm_i2c_infineon.c b/drivers/char/tpm/tpm_i2c_infineon.c
index 005c38879b2e..19fbd6a3a8e9 100644
--- a/drivers/char/tpm/tpm_i2c_infineon.c
+++ b/drivers/char/tpm/tpm_i2c_infineon.c
@@ -665,9 +665,9 @@ static int tpm_tis_i2c_init(struct device *dev)
}
static const struct i2c_device_id tpm_tis_i2c_table[] = {
- {"tpm_i2c_infineon", 0},
- {"slb9635tt", 0},
- {"slb9645tt", 1},
+ {"tpm_i2c_infineon" },
+ {"slb9635tt" },
+ {"slb9645tt" },
{},
};
@@ -675,9 +675,9 @@ MODULE_DEVICE_TABLE(i2c, tpm_tis_i2c_table);
#ifdef CONFIG_OF
static const struct of_device_id tpm_tis_i2c_of_match[] = {
- { .compatible = "infineon,tpm_i2c_infineon", .data = (void *)0 },
- { .compatible = "infineon,slb9635tt", .data = (void *)0 },
- { .compatible = "infineon,slb9645tt", .data = (void *)1 },
+ { .compatible = "infineon,tpm_i2c_infineon" },
+ { .compatible = "infineon,slb9635tt" },
+ { .compatible = "infineon,slb9645tt" },
{},
};
MODULE_DEVICE_TABLE(of, tpm_tis_i2c_of_match);
--
2.14.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tpm: remove unused data fields from I2C and OF device ID tables
2017-12-22 10:26 [PATCH] tpm: remove unused data fields from I2C and OF device ID tables Javier Martinez Canillas
@ 2017-12-22 16:06 ` Jason Gunthorpe
0 siblings, 0 replies; 2+ messages in thread
From: Jason Gunthorpe @ 2017-12-22 16:06 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: linux-kernel, Arnd Bergmann, Jarkko Sakkinen, Peter Huewe,
Greg Kroah-Hartman, linux-integrity
On Fri, Dec 22, 2017 at 11:26:36AM +0100, Javier Martinez Canillas wrote:
> The data field for the entries in the device tables are set but not used.
>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
>
> drivers/char/tpm/tpm_i2c_infineon.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/char/tpm/tpm_i2c_infineon.c b/drivers/char/tpm/tpm_i2c_infineon.c
> index 005c38879b2e..19fbd6a3a8e9 100644
> +++ b/drivers/char/tpm/tpm_i2c_infineon.c
> @@ -665,9 +665,9 @@ static int tpm_tis_i2c_init(struct device *dev)
> }
>
> static const struct i2c_device_id tpm_tis_i2c_table[] = {
> - {"tpm_i2c_infineon", 0},
> - {"slb9635tt", 0},
> - {"slb9645tt", 1},
> + {"tpm_i2c_infineon" },
> + {"slb9635tt" },
> + {"slb9645tt" },
^^^
The space should go too..
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-22 16:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-22 10:26 [PATCH] tpm: remove unused data fields from I2C and OF device ID tables Javier Martinez Canillas
2017-12-22 16:06 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).