Re: [PATCH 09/24] jump_label: Add branch hints to static_branch_{un,}likely()

From: Borislav Petkov <bp@alien8.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Josh Poimboeuf <jpoimboe@redhat.com>,
	linux-kernel@vger.kernel.org, Dave Hansen <dave.hansen@intel.com>,
	Ashok Raj <ashok.raj@intel.com>,
	Tim Chen <tim.c.chen@linux.intel.com>,
	Andy Lutomirski <luto@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Greg KH <gregkh@linuxfoundation.org>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Andi Kleen <ak@linux.intel.com>,
	Arjan Van De Ven <arjan.van.de.ven@intel.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Jun Nakajima <jun.nakajima@intel.com>,
	Asit Mallick <asit.k.mallick@intel.com>,
	Jason Baron <jbaron@akamai.com>
Subject: Re: [PATCH 09/24] jump_label: Add branch hints to static_branch_{un,}likely()
Date: Wed, 24 Jan 2018 19:46:12 +0100	[thread overview]
Message-ID: <20180124184612.kxlnoa2ajimkzd7x@pd.tnic> (raw)
In-Reply-To: <20180123152638.512294068@infradead.org>

On Tue, Jan 23, 2018 at 04:25:48PM +0100, Peter Zijlstra wrote:
> For some reason these were missing, I've not observed this patch
> making a difference in the few code locations I checked, but this
> makes sense.
> 
> Cc: Jason Baron <jbaron@akamai.com>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> ---
>  include/linux/jump_label.h |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- a/include/linux/jump_label.h
> +++ b/include/linux/jump_label.h
> @@ -388,7 +388,7 @@ extern bool ____wrong_branch_error(void)
>  		branch = !arch_static_branch_jump(&(x)->key, true);		\
>  	else									\
>  		branch = ____wrong_branch_error();				\
> -	branch;									\
> +	likely(branch);								\
>  })
>  
>  #define static_branch_unlikely(x)						\
> @@ -400,7 +400,7 @@ extern bool ____wrong_branch_error(void)
>  		branch = arch_static_branch(&(x)->key, false);			\
>  	else									\
>  		branch = ____wrong_branch_error();				\
> -	branch;									\
> +	unlikely(branch);							\
>  })

LOL, it is practically in the name already. :-)

Reviewed-by: Borislav Petkov <bp@suse.de>

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.