From: Andrew Lunn <andrew@lunn.ch>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Allan Nielsen <Allan.Nielsen@microsemi.com>,
razvan.stefanescu@nxp.com, po.liu@nxp.com,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mips@linux-mips.org,
James Hogan <jhogan@kernel.org>
Subject: Re: [PATCH net-next 6/8] MIPS: mscc: Add switch to ocelot
Date: Fri, 23 Mar 2018 22:33:44 +0100 [thread overview]
Message-ID: <20180323213344.GV24361@lunn.ch> (raw)
In-Reply-To: <20180323212230.GA12808@piout.net>
On Fri, Mar 23, 2018 at 10:22:30PM +0100, Alexandre Belloni wrote:
> On 23/03/2018 at 14:17:48 -0700, Florian Fainelli wrote:
> > On 03/23/2018 01:11 PM, Alexandre Belloni wrote:
> > > +
> > > + phy0: ethernet-phy@0 {
> > > + reg = <0>;
> > > + };
> > > + phy1: ethernet-phy@1 {
> > > + reg = <1>;
> > > + };
> > > + phy2: ethernet-phy@2 {
> > > + reg = <2>;
> > > + };
> > > + phy3: ethernet-phy@3 {
> > > + reg = <3>;
> > > + };
> >
> > These PHYs should be defined at the board DTS level.
>
> Those are internal PHYs, present on the SoC, I doubt anyone will have
> anything different while using the same SoC.
With DSA, there is no need to list internal PHYs.
That is the trade off of having a standalone MDIO bus driver. Maybe
add a phandle to the internal MDIO bus? The switch driver could then
follow the phandle, and direct connect the internal PHYs?
Andrew
next prev parent reply other threads:[~2018-03-23 21:33 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 20:11 [PATCH net-next 0/8] Microsemi Ocelot switch support Alexandre Belloni
2018-03-23 20:11 ` [PATCH net-next 1/8] net: phy: Add initial support for Microsemi Ocelot internal PHYs Alexandre Belloni
2018-03-23 20:29 ` Andrew Lunn
2018-03-23 21:08 ` Florian Fainelli
2018-03-28 16:18 ` Alexandre Belloni
2018-03-23 20:11 ` [PATCH net-next 2/8] dt-bindings: net: add DT bindings for Microsemi MIIM Alexandre Belloni
2018-03-23 21:46 ` Florian Fainelli
2018-03-23 20:11 ` [PATCH net-next 3/8] net: mscc: Add MDIO driver Alexandre Belloni
2018-03-23 20:49 ` Andrew Lunn
2018-03-29 14:05 ` Alexandre Belloni
2018-03-29 14:40 ` Andrew Lunn
2018-03-29 14:53 ` Alexandre Belloni
2018-03-29 14:57 ` Andrew Lunn
2018-03-23 21:51 ` Florian Fainelli
2018-03-29 14:14 ` Alexandre Belloni
2018-03-23 20:11 ` [PATCH net-next 4/8] dt-bindings: net: add DT bindings for Microsemi Ocelot Switch Alexandre Belloni
2018-03-23 21:01 ` Andrew Lunn
2018-03-23 21:11 ` Florian Fainelli
2018-03-26 22:25 ` Rob Herring
2018-03-26 22:50 ` Andrew Lunn
2018-03-27 0:34 ` Rob Herring
2018-03-26 22:25 ` Rob Herring
2018-03-23 20:11 ` [PATCH net-next 5/8] net: mscc: Add initial Ocelot switch support Alexandre Belloni
2018-03-23 21:25 ` Andrew Lunn
2018-03-23 21:41 ` Florian Fainelli
2018-03-30 12:45 ` Alexandre Belloni
2018-03-30 13:54 ` Andrew Lunn
2018-03-30 14:16 ` Alexandre Belloni
2018-03-30 14:50 ` Andrew Lunn
2018-03-31 22:47 ` Florian Fainelli
2018-04-24 18:52 ` Alexandre Belloni
2018-03-26 19:13 ` kbuild test robot
2018-03-30 7:02 ` Razvan Stefanescu
2018-03-23 20:11 ` [PATCH net-next 6/8] MIPS: mscc: Add switch to ocelot Alexandre Belloni
2018-03-23 21:17 ` Florian Fainelli
2018-03-23 21:22 ` Alexandre Belloni
2018-03-23 21:33 ` Andrew Lunn [this message]
2018-03-23 21:44 ` Florian Fainelli
2018-03-23 22:06 ` Andrew Lunn
2018-03-23 22:11 ` Florian Fainelli
2018-03-24 14:48 ` Andrew Lunn
2018-03-23 20:11 ` [PATCH net-next 7/8] MIPS: mscc: connect phys to ports on ocelot_pcb123 Alexandre Belloni
2018-03-23 20:11 ` [PATCH net-next 8/8] MAINTAINERS: Add entry for Microsemi Ethernet switches Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180323213344.GV24361@lunn.ch \
--to=andrew@lunn.ch \
--cc=Allan.Nielsen@microsemi.com \
--cc=alexandre.belloni@bootlin.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jhogan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
--cc=po.liu@nxp.com \
--cc=razvan.stefanescu@nxp.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).