linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] perf trace: remove redundant ')'
@ 2018-03-13 10:40 changbin.du
  2018-03-16  7:51 ` Du, Changbin
  2018-04-04  5:36 ` [tip:perf/urgent] perf trace: Remove " tip-bot for Changbin Du
  0 siblings, 2 replies; 7+ messages in thread
From: changbin.du @ 2018-03-13 10:40 UTC (permalink / raw)
  To: acme, jolsa
  Cc: peterz, mingo, namhyung, linux-kernel, linux-perf-users, Changbin Du

From: Changbin Du <changbin.du@intel.com>

There is a redundant ')' at the tail of each event. So remove it.
$ sudo perf trace --no-syscalls -e 'kmem:*' -a
   899.342 kmem:kfree:(vfs_writev+0xb9) call_site=ffffffff9c453979 ptr=(nil))
   899.344 kmem:kfree:(___sys_recvmsg+0x188) call_site=ffffffff9c9b8b88 ptr=(nil))

Signed-off-by: Changbin Du <changbin.du@intel.com>
---
 tools/perf/builtin-trace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index e7f1b18..7273f5f 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -1959,7 +1959,7 @@ static int trace__event_handler(struct trace *trace, struct perf_evsel *evsel,
 				      trace->output);
 	}
 
-	fprintf(trace->output, ")\n");
+	fprintf(trace->output, "\n");
 
 	if (callchain_ret > 0)
 		trace__fprintf_callchain(trace, sample);
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH] perf trace: remove redundant ')'
  2018-03-13 10:40 [PATCH] perf trace: remove redundant ')' changbin.du
@ 2018-03-16  7:51 ` Du, Changbin
  2018-03-16 12:50   ` Arnaldo Carvalho de Melo
  2018-04-04  5:36 ` [tip:perf/urgent] perf trace: Remove " tip-bot for Changbin Du
  1 sibling, 1 reply; 7+ messages in thread
From: Du, Changbin @ 2018-03-16  7:51 UTC (permalink / raw)
  To: changbin.du
  Cc: acme, jolsa, peterz, mingo, namhyung, linux-kernel, linux-perf-users

Hi Arnaldo, How about this simple one? Thanks.

On Tue, Mar 13, 2018 at 06:40:01PM +0800, changbin.du@intel.com wrote:
> From: Changbin Du <changbin.du@intel.com>
> 
> There is a redundant ')' at the tail of each event. So remove it.
> $ sudo perf trace --no-syscalls -e 'kmem:*' -a
>    899.342 kmem:kfree:(vfs_writev+0xb9) call_site=ffffffff9c453979 ptr=(nil))
>    899.344 kmem:kfree:(___sys_recvmsg+0x188) call_site=ffffffff9c9b8b88 ptr=(nil))
> 
> Signed-off-by: Changbin Du <changbin.du@intel.com>
> ---
>  tools/perf/builtin-trace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> index e7f1b18..7273f5f 100644
> --- a/tools/perf/builtin-trace.c
> +++ b/tools/perf/builtin-trace.c
> @@ -1959,7 +1959,7 @@ static int trace__event_handler(struct trace *trace, struct perf_evsel *evsel,
>  				      trace->output);
>  	}
>  
> -	fprintf(trace->output, ")\n");
> +	fprintf(trace->output, "\n");
>  
>  	if (callchain_ret > 0)
>  		trace__fprintf_callchain(trace, sample);
> -- 
> 2.7.4
> 

-- 
Thanks,
Changbin Du

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] perf trace: remove redundant ')'
  2018-03-16  7:51 ` Du, Changbin
@ 2018-03-16 12:50   ` Arnaldo Carvalho de Melo
  2018-03-28  7:26     ` Du, Changbin
  0 siblings, 1 reply; 7+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-03-16 12:50 UTC (permalink / raw)
  To: Du, Changbin
  Cc: jolsa, peterz, mingo, namhyung, linux-kernel, linux-perf-users

Em Fri, Mar 16, 2018 at 03:51:09PM +0800, Du, Changbin escreveu:
> Hi Arnaldo, How about this simple one? Thanks.
> 
> On Tue, Mar 13, 2018 at 06:40:01PM +0800, changbin.du@intel.com wrote:
> > From: Changbin Du <changbin.du@intel.com>
> > 
> > There is a redundant ')' at the tail of each event. So remove it.
> > $ sudo perf trace --no-syscalls -e 'kmem:*' -a
> >    899.342 kmem:kfree:(vfs_writev+0xb9) call_site=ffffffff9c453979 ptr=(nil))
> >    899.344 kmem:kfree:(___sys_recvmsg+0x188) call_site=ffffffff9c9b8b88 ptr=(nil))
> > 
> > Signed-off-by: Changbin Du <changbin.du@intel.com>
> > ---
> >  tools/perf/builtin-trace.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> > index e7f1b18..7273f5f 100644
> > --- a/tools/perf/builtin-trace.c
> > +++ b/tools/perf/builtin-trace.c
> > @@ -1959,7 +1959,7 @@ static int trace__event_handler(struct trace *trace, struct perf_evsel *evsel,
> >  				      trace->output);
> >  	}
> >  
> > -	fprintf(trace->output, ")\n");
> > +	fprintf(trace->output, "\n");

It looks simple on the surface, but I couldn't quickly recall why this
')' was put there in the first place... So I left for later to do a 'git
blame' on this file, etc.

- Arnaldo

> >  	if (callchain_ret > 0)
> >  		trace__fprintf_callchain(trace, sample);
> > -- 
> > 2.7.4
> > 
> 
> -- 
> Thanks,
> Changbin Du

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] perf trace: remove redundant ')'
  2018-03-16 12:50   ` Arnaldo Carvalho de Melo
@ 2018-03-28  7:26     ` Du, Changbin
  2018-04-03 19:19       ` Arnaldo Carvalho de Melo
  0 siblings, 1 reply; 7+ messages in thread
From: Du, Changbin @ 2018-03-28  7:26 UTC (permalink / raw)
  To: Arnaldo Carvalho de Melo
  Cc: Du, Changbin, jolsa, peterz, mingo, namhyung, linux-kernel,
	linux-perf-users

Hi Arnaldo,
Just a kind reminder. Hope you didn't forget this.

On Fri, Mar 16, 2018 at 09:50:45AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, Mar 16, 2018 at 03:51:09PM +0800, Du, Changbin escreveu:
> > Hi Arnaldo, How about this simple one? Thanks.
> > 
> > On Tue, Mar 13, 2018 at 06:40:01PM +0800, changbin.du@intel.com wrote:
> > > From: Changbin Du <changbin.du@intel.com>
> > > 
> > > There is a redundant ')' at the tail of each event. So remove it.
> > > $ sudo perf trace --no-syscalls -e 'kmem:*' -a
> > >    899.342 kmem:kfree:(vfs_writev+0xb9) call_site=ffffffff9c453979 ptr=(nil))
> > >    899.344 kmem:kfree:(___sys_recvmsg+0x188) call_site=ffffffff9c9b8b88 ptr=(nil))
> > > 
> > > Signed-off-by: Changbin Du <changbin.du@intel.com>
> > > ---
> > >  tools/perf/builtin-trace.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> > > index e7f1b18..7273f5f 100644
> > > --- a/tools/perf/builtin-trace.c
> > > +++ b/tools/perf/builtin-trace.c
> > > @@ -1959,7 +1959,7 @@ static int trace__event_handler(struct trace *trace, struct perf_evsel *evsel,
> > >  				      trace->output);
> > >  	}
> > >  
> > > -	fprintf(trace->output, ")\n");
> > > +	fprintf(trace->output, "\n");
> 
> It looks simple on the surface, but I couldn't quickly recall why this
> ')' was put there in the first place... So I left for later to do a 'git
> blame' on this file, etc.
> 
> - Arnaldo
> 
> > >  	if (callchain_ret > 0)
> > >  		trace__fprintf_callchain(trace, sample);
> > > -- 
> > > 2.7.4
> > > 
> > 
> > -- 
> > Thanks,
> > Changbin Du

-- 
Thanks,
Changbin Du

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] perf trace: remove redundant ')'
  2018-03-28  7:26     ` Du, Changbin
@ 2018-04-03 19:19       ` Arnaldo Carvalho de Melo
  2018-04-04  2:31         ` Du, Changbin
  0 siblings, 1 reply; 7+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-04-03 19:19 UTC (permalink / raw)
  To: Du, Changbin
  Cc: jolsa, peterz, mingo, namhyung, linux-kernel, linux-perf-users

Em Wed, Mar 28, 2018 at 03:26:31PM +0800, Du, Changbin escreveu:
> Hi Arnaldo,
> Just a kind reminder. Hope you didn't forget this.

Ok, applied.

- Arnaldo
 
> On Fri, Mar 16, 2018 at 09:50:45AM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Fri, Mar 16, 2018 at 03:51:09PM +0800, Du, Changbin escreveu:
> > > Hi Arnaldo, How about this simple one? Thanks.
> > > 
> > > On Tue, Mar 13, 2018 at 06:40:01PM +0800, changbin.du@intel.com wrote:
> > > > From: Changbin Du <changbin.du@intel.com>
> > > > 
> > > > There is a redundant ')' at the tail of each event. So remove it.
> > > > $ sudo perf trace --no-syscalls -e 'kmem:*' -a
> > > >    899.342 kmem:kfree:(vfs_writev+0xb9) call_site=ffffffff9c453979 ptr=(nil))
> > > >    899.344 kmem:kfree:(___sys_recvmsg+0x188) call_site=ffffffff9c9b8b88 ptr=(nil))
> > > > 
> > > > Signed-off-by: Changbin Du <changbin.du@intel.com>
> > > > ---
> > > >  tools/perf/builtin-trace.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> > > > index e7f1b18..7273f5f 100644
> > > > --- a/tools/perf/builtin-trace.c
> > > > +++ b/tools/perf/builtin-trace.c
> > > > @@ -1959,7 +1959,7 @@ static int trace__event_handler(struct trace *trace, struct perf_evsel *evsel,
> > > >  				      trace->output);
> > > >  	}
> > > >  
> > > > -	fprintf(trace->output, ")\n");
> > > > +	fprintf(trace->output, "\n");
> > 
> > It looks simple on the surface, but I couldn't quickly recall why this
> > ')' was put there in the first place... So I left for later to do a 'git
> > blame' on this file, etc.
> > 
> > - Arnaldo
> > 
> > > >  	if (callchain_ret > 0)
> > > >  		trace__fprintf_callchain(trace, sample);
> > > > -- 
> > > > 2.7.4
> > > > 
> > > 
> > > -- 
> > > Thanks,
> > > Changbin Du
> 
> -- 
> Thanks,
> Changbin Du

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] perf trace: remove redundant ')'
  2018-04-03 19:19       ` Arnaldo Carvalho de Melo
@ 2018-04-04  2:31         ` Du, Changbin
  0 siblings, 0 replies; 7+ messages in thread
From: Du, Changbin @ 2018-04-04  2:31 UTC (permalink / raw)
  To: Arnaldo Carvalho de Melo
  Cc: Du, Changbin, jolsa, peterz, mingo, namhyung, linux-kernel,
	linux-perf-users

On Tue, Apr 03, 2018 at 04:19:07PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Mar 28, 2018 at 03:26:31PM +0800, Du, Changbin escreveu:
> > Hi Arnaldo,
> > Just a kind reminder. Hope you didn't forget this.
> 
> Ok, applied.
> 
> - Arnaldo
>  
Got it, thanks!

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [tip:perf/urgent] perf trace: Remove redundant ')'
  2018-03-13 10:40 [PATCH] perf trace: remove redundant ')' changbin.du
  2018-03-16  7:51 ` Du, Changbin
@ 2018-04-04  5:36 ` tip-bot for Changbin Du
  1 sibling, 0 replies; 7+ messages in thread
From: tip-bot for Changbin Du @ 2018-04-04  5:36 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: namhyung, acme, hpa, jolsa, peterz, tglx, changbin.du, mingo,
	linux-kernel

Commit-ID:  51125a29a395048fdb3429b8c4ca0ada57097744
Gitweb:     https://git.kernel.org/tip/51125a29a395048fdb3429b8c4ca0ada57097744
Author:     Changbin Du <changbin.du@intel.com>
AuthorDate: Tue, 13 Mar 2018 18:40:01 +0800
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 3 Apr 2018 16:16:41 -0300

perf trace: Remove redundant ')'

There is a redundant ')' at the tail of each event. So remove it.

$ sudo perf trace --no-syscalls -e 'kmem:*' -a
   899.342 kmem:kfree:(vfs_writev+0xb9) call_site=ffffffff9c453979 ptr=(nil))
   899.344 kmem:kfree:(___sys_recvmsg+0x188) call_site=ffffffff9c9b8b88 ptr=(nil))

Signed-off-by: Changbin Du <changbin.du@intel.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1520937601-24952-1-git-send-email-changbin.du@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-trace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index 4e03f0f68241..3ad17ee89403 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -1962,7 +1962,7 @@ static int trace__event_handler(struct trace *trace, struct perf_evsel *evsel,
 				      trace->output);
 	}
 
-	fprintf(trace->output, ")\n");
+	fprintf(trace->output, "\n");
 
 	if (callchain_ret > 0)
 		trace__fprintf_callchain(trace, sample);

^ permalink raw reply related	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-04-04  5:37 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-13 10:40 [PATCH] perf trace: remove redundant ')' changbin.du
2018-03-16  7:51 ` Du, Changbin
2018-03-16 12:50   ` Arnaldo Carvalho de Melo
2018-03-28  7:26     ` Du, Changbin
2018-04-03 19:19       ` Arnaldo Carvalho de Melo
2018-04-04  2:31         ` Du, Changbin
2018-04-04  5:36 ` [tip:perf/urgent] perf trace: Remove " tip-bot for Changbin Du

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).