linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Rosin <peda@axentia.se>
To: linux-kernel@vger.kernel.org
Cc: Peter Rosin <peda@axentia.se>,
	Wenyou Yang <wenyou.yang@microchip.com>,
	Josh Wu <rainyfeeling@outlook.com>,
	Boris Brezillon <boris.brezillon@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	Marek Vasut <marek.vasut@gmail.com>,
	Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	linux-mtd@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mtd: nand: raw: atmel: add module param to avoid using dma
Date: Thu, 29 Mar 2018 15:10:54 +0200	[thread overview]
Message-ID: <20180329131054.22506-1-peda@axentia.se> (raw)

On a sama5d31 with a Full-HD dual LVDS panel (132MHz pixel clock) NAND
flash accesses have a tendency to cause display disturbances. Add a
module param to disable DMA from the NAND controller, since that fixes
the display problem for me.

Signed-off-by: Peter Rosin <peda@axentia.se>
---
 drivers/mtd/nand/raw/atmel/nand-controller.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c
index b2f00b398490..2ff7a77c7b8e 100644
--- a/drivers/mtd/nand/raw/atmel/nand-controller.c
+++ b/drivers/mtd/nand/raw/atmel/nand-controller.c
@@ -129,6 +129,11 @@
 #define DEFAULT_TIMEOUT_MS			1000
 #define MIN_DMA_LEN				128
 
+static bool atmel_nand_avoid_dma __read_mostly;
+
+MODULE_PARM_DESC(avoiddma, "Avoid using DMA");
+module_param_named(avoiddma, atmel_nand_avoid_dma, bool, 0400);
+
 enum atmel_nand_rb_type {
 	ATMEL_NAND_NO_RB,
 	ATMEL_NAND_NATIVE_RB,
@@ -1977,7 +1982,7 @@ static int atmel_nand_controller_init(struct atmel_nand_controller *nc,
 		return ret;
 	}
 
-	if (nc->caps->has_dma) {
+	if (nc->caps->has_dma && !atmel_nand_avoid_dma) {
 		dma_cap_mask_t mask;
 
 		dma_cap_zero(mask);
-- 
2.11.0

             reply	other threads:[~2018-03-29 13:11 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-29 13:10 Peter Rosin [this message]
2018-03-29 13:33 ` [PATCH] mtd: nand: raw: atmel: add module param to avoid using dma Boris Brezillon
2018-03-29 13:37   ` Peter Rosin
2018-03-29 13:44     ` Boris Brezillon
2018-03-29 14:27       ` Peter Rosin
2018-03-30 21:43         ` Peter Rosin
2018-04-02 12:22         ` Boris Brezillon
2018-04-02 17:59           ` Peter Rosin
2018-04-02 19:28             ` Boris Brezillon
2018-04-02 20:20               ` Boris Brezillon
2018-04-02 20:32                 ` Boris Brezillon
2018-04-03  6:11                 ` Peter Rosin
2018-04-03  7:18                   ` Boris Brezillon
2018-04-11 14:44                     ` Peter Rosin
2018-04-11 14:59                       ` Boris Brezillon
2018-04-11 15:10                         ` Peter Rosin
2018-04-11 15:34                           ` Boris Brezillon
2018-04-11 15:34                       ` Nicolas Ferre
2018-04-12  7:18                         ` Peter Rosin
2018-05-22 18:03                         ` Peter Rosin
2018-05-23 10:42                           ` Boris Brezillon
2018-05-25 14:51                         ` Tudor Ambarus
2018-05-26 17:40                           ` Peter Rosin
2018-05-27  9:18                           ` Peter Rosin
2018-05-27 22:11                             ` Peter Rosin
2018-05-28 10:10                               ` Peter Rosin
2018-05-28 14:27                                 ` Boris Brezillon
2018-05-28 15:52                                   ` Peter Rosin
2018-05-28 16:09                                     ` Boris Brezillon
2018-05-28 16:09                                     ` Nicolas Ferre
2018-05-29  6:30                                 ` Eugen Hristev
2018-05-29  7:10                                   ` Peter Rosin
2018-05-29  7:25                                     ` Eugen Hristev
2018-05-29 14:49                                   ` Boris Brezillon
2018-05-29 15:01                                     ` Eugen Hristev
2018-05-29 15:15                                       ` Boris Brezillon
2018-05-29 15:21                                         ` Eugen Hristev
2018-05-29 15:46                                           ` Boris Brezillon
2018-05-29 17:57                                             ` Boris Brezillon
2018-05-29 21:37                                               ` Peter Rosin
2018-06-04 15:46                                 ` Tudor Ambarus
2018-06-04 16:03                                   ` Boris Brezillon
2018-04-03  6:51                 ` Peter Rosin
2018-04-03  7:15                   ` Boris Brezillon
2018-04-03  7:32                     ` Boris Brezillon
2018-04-03  8:14                     ` Peter Rosin
2018-04-03  8:30                       ` Boris Brezillon
2018-04-02 20:23               ` Peter Rosin
2018-04-02 20:35                 ` Boris Brezillon
2018-04-03  7:18                 ` Alexandre Belloni
2018-04-03  8:37                   ` Peter Rosin
2018-03-29 14:20 ` Nicolas Ferre
2018-03-29 14:23   ` Peter Rosin
2018-03-29 14:29   ` Boris Brezillon
2018-06-18  8:39 ` Boris Brezillon
2018-06-18 14:00   ` Miquel Raynal
2018-06-25 12:31   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180329131054.22506-1-peda@axentia.se \
    --to=peda@axentia.se \
    --cc=alexandre.belloni@bootlin.com \
    --cc=boris.brezillon@bootlin.com \
    --cc=computersforpeace@gmail.com \
    --cc=cyrille.pitchen@wedev4u.fr \
    --cc=dwmw2@infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=rainyfeeling@outlook.com \
    --cc=richard@nod.at \
    --cc=wenyou.yang@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).