linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drivers/memory/Kconfig: Add CONFIG_OF dependency
@ 2018-07-21 20:00 Anders Roxell
  2018-07-21 21:53 ` Randy Dunlap
  0 siblings, 1 reply; 11+ messages in thread
From: Anders Roxell @ 2018-07-21 20:00 UTC (permalink / raw)
  To: miquel.raynal, boris.brezillon, rdunlap; +Cc: linux-kernel, Anders Roxell

JZ4780_NEMC doesn't depend on OF, and if OF isn't enabled we get this
error:
drivers/memory/jz4780-nemc.c: In function ‘jz4780_nemc_num_banks’:
drivers/memory/jz4780-nemc.c:72:10: error: implicit declaration of
 function ‘of_read_number’; did you mean ‘down_read_nested’?
 [-Werror=implicit-function-declaration]
   bank = of_read_number(prop, 1);
          ^~~~~~~~~~~~~~
          down_read_nested

Make JZ4780_NEMC depend on OF.

Fixes: ab99e11062c1 ("memory: jz4780-nemc: Allow selection of this driver when COMPILE_TEST=y")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
 drivers/memory/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
index a642552dfdc9..63389f075f1d 100644
--- a/drivers/memory/Kconfig
+++ b/drivers/memory/Kconfig
@@ -123,7 +123,7 @@ config JZ4780_NEMC
 	bool "Ingenic JZ4780 SoC NEMC driver"
 	default y
 	depends on MACH_JZ4780 || COMPILE_TEST
-	depends on HAS_IOMEM
+	depends on HAS_IOMEM && OF
 	help
 	  This driver is for the NAND/External Memory Controller (NEMC) in
 	  the Ingenic JZ4780. This controller is used to handle external
-- 
2.18.0


^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2018-07-26 23:26 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-21 20:00 [PATCH] drivers/memory/Kconfig: Add CONFIG_OF dependency Anders Roxell
2018-07-21 21:53 ` Randy Dunlap
2018-07-22  6:29   ` Boris Brezillon
2018-07-23  9:34     ` Arnd Bergmann
2018-07-23  9:41       ` Boris Brezillon
2018-07-23 15:40         ` Arnd Bergmann
2018-07-23 16:04           ` Arnd Bergmann
2018-07-23 16:14             ` Boris Brezillon
2018-07-23 18:39               ` Arnd Bergmann
2018-07-23 16:12           ` Boris Brezillon
2018-07-26 23:25         ` Miquel Raynal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).