* [PATCH] fsnotify: remove some duplicated includes
@ 2018-11-26 14:54 Yangtao Li
2018-11-26 23:37 ` Paul Moore
0 siblings, 1 reply; 2+ messages in thread
From: Yangtao Li @ 2018-11-26 14:54 UTC (permalink / raw)
To: paul, eparis; +Cc: linux-audit, linux-kernel, Yangtao Li
audit.h and fs.h are included twice.It's unnecessary.
hence just remove them.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
kernel/audit_fsnotify.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/kernel/audit_fsnotify.c b/kernel/audit_fsnotify.c
index fba78047fb37..5b54386a9edf 100644
--- a/kernel/audit_fsnotify.c
+++ b/kernel/audit_fsnotify.c
@@ -16,10 +16,8 @@
*/
#include <linux/kernel.h>
-#include <linux/audit.h>
#include <linux/kthread.h>
#include <linux/mutex.h>
-#include <linux/fs.h>
#include <linux/fsnotify_backend.h>
#include <linux/namei.h>
#include <linux/netlink.h>
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fsnotify: remove some duplicated includes
2018-11-26 14:54 [PATCH] fsnotify: remove some duplicated includes Yangtao Li
@ 2018-11-26 23:37 ` Paul Moore
0 siblings, 0 replies; 2+ messages in thread
From: Paul Moore @ 2018-11-26 23:37 UTC (permalink / raw)
To: tiny.windzz; +Cc: Eric Paris, linux-audit, linux-kernel
On Mon, Nov 26, 2018 at 9:54 AM Yangtao Li <tiny.windzz@gmail.com> wrote:
> audit.h and fs.h are included twice.It's unnecessary.
> hence just remove them.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> kernel/audit_fsnotify.c | 2 --
> 1 file changed, 2 deletions(-)
I currently prefer to keep things as-is, see my response to your previous patch.
> diff --git a/kernel/audit_fsnotify.c b/kernel/audit_fsnotify.c
> index fba78047fb37..5b54386a9edf 100644
> --- a/kernel/audit_fsnotify.c
> +++ b/kernel/audit_fsnotify.c
> @@ -16,10 +16,8 @@
> */
>
> #include <linux/kernel.h>
> -#include <linux/audit.h>
> #include <linux/kthread.h>
> #include <linux/mutex.h>
> -#include <linux/fs.h>
> #include <linux/fsnotify_backend.h>
> #include <linux/namei.h>
> #include <linux/netlink.h>
> --
> 2.17.0
>
--
paul moore
www.paul-moore.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-26 23:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-26 14:54 [PATCH] fsnotify: remove some duplicated includes Yangtao Li
2018-11-26 23:37 ` Paul Moore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).