[PATCH] fsnotify: remove some duplicated includes

[PATCH] fsnotify: remove some duplicated includes

[Yangtao Li]

audit.h and fs.h are included twice.It's unnecessary.
hence just remove them.

Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
 kernel/audit_fsnotify.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/kernel/audit_fsnotify.c b/kernel/audit_fsnotify.c
index fba78047fb37..5b54386a9edf 100644
--- a/kernel/audit_fsnotify.c
+++ b/kernel/audit_fsnotify.c
@@ -16,10 +16,8 @@
  */
 
 #include <linux/kernel.h>
-#include <linux/audit.h>
 #include <linux/kthread.h>
 #include <linux/mutex.h>
-#include <linux/fs.h>
 #include <linux/fsnotify_backend.h>
 #include <linux/namei.h>
 #include <linux/netlink.h>
-- 
2.17.0

Re: [PATCH] fsnotify: remove some duplicated includes

[Paul Moore]

On Mon, Nov 26, 2018 at 9:54 AM Yangtao Li <tiny.windzz@gmail.com> wrote:
> audit.h and fs.h are included twice.It's unnecessary.
> hence just remove them.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
>  kernel/audit_fsnotify.c | 2 --
>  1 file changed, 2 deletions(-)

I currently prefer to keep things as-is, see my response to your previous patch.

> diff --git a/kernel/audit_fsnotify.c b/kernel/audit_fsnotify.c
> index fba78047fb37..5b54386a9edf 100644
> --- a/kernel/audit_fsnotify.c
> +++ b/kernel/audit_fsnotify.c
> @@ -16,10 +16,8 @@
>   */
>
>  #include <linux/kernel.h>
> -#include <linux/audit.h>
>  #include <linux/kthread.h>
>  #include <linux/mutex.h>
> -#include <linux/fs.h>
>  #include <linux/fsnotify_backend.h>
>  #include <linux/namei.h>
>  #include <linux/netlink.h>
> --
> 2.17.0
>


-- 
paul moore
www.paul-moore.com