* [PATCH 1/2] perf c2c: Change the default coalesce setup
@ 2018-12-28 10:18 Jiri Olsa
2018-12-28 10:18 ` [PATCH 2/2] perf c2c: Increase the HITM ratio limit for displayed cachelines Jiri Olsa
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Jiri Olsa @ 2018-12-28 10:18 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: lkml, Ingo Molnar, Namhyung Kim, Alexander Shishkin,
Peter Zijlstra, Joe Mario
Joe suggested to have the coalesce default set just to 'iaddr',
because it's easier to read on the (default) c2c report run.
By removing pid from -c option, the c2c report will group all
the relevant pids under instruction address bucket. User can
always run -c pid,iaddr for more grained output on particular
pids.
Suggested-by: Joe Mario <jmario@redhat.com>
Link: http://lkml.kernel.org/n/tip-lk53c7y9fadu53spuzsn6cij@git.kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
tools/perf/builtin-c2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
index 686fb60a8e11..321687f8f373 100644
--- a/tools/perf/builtin-c2c.c
+++ b/tools/perf/builtin-c2c.c
@@ -68,7 +68,7 @@ struct c2c_hist_entry {
struct hist_entry he;
};
-static char const *coalesce_default = "pid,iaddr";
+static char const *coalesce_default = "iaddr";
struct perf_c2c {
struct perf_tool tool;
--
2.17.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] perf c2c: Increase the HITM ratio limit for displayed cachelines
2018-12-28 10:18 [PATCH 1/2] perf c2c: Change the default coalesce setup Jiri Olsa
@ 2018-12-28 10:18 ` Jiri Olsa
2018-12-28 12:39 ` Arnaldo Carvalho de Melo
2019-01-03 13:19 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2018-12-28 12:34 ` [PATCH 1/2] perf c2c: Change the default coalesce setup Arnaldo Carvalho de Melo
2019-01-03 13:18 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2 siblings, 2 replies; 6+ messages in thread
From: Jiri Olsa @ 2018-12-28 10:18 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: lkml, Ingo Molnar, Namhyung Kim, Alexander Shishkin,
Peter Zijlstra, Joe Mario
The cachelines being reported go down to 0.05%. hat makes for very
long output files. Raising that to 0.1%. The user can always specify
--show-all if they want all the cachelines.
Suggested-by: Joe Mario <jmario@redhat.com>
Link: http://lkml.kernel.org/n/tip-uwxpd36jutygit56mycanwma@git.kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
tools/perf/builtin-c2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
index 321687f8f373..30584cb44fb7 100644
--- a/tools/perf/builtin-c2c.c
+++ b/tools/perf/builtin-c2c.c
@@ -1878,7 +1878,7 @@ static int c2c_hists__reinit(struct c2c_hists *c2c_hists,
return hpp_list__parse(&c2c_hists->list, output, sort);
}
-#define DISPLAY_LINE_LIMIT 0.0005
+#define DISPLAY_LINE_LIMIT 0.001
static bool he__display(struct hist_entry *he, struct c2c_stats *stats)
{
--
2.17.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] perf c2c: Increase the HITM ratio limit for displayed cachelines
2018-12-28 10:18 ` [PATCH 2/2] perf c2c: Increase the HITM ratio limit for displayed cachelines Jiri Olsa
@ 2018-12-28 12:39 ` Arnaldo Carvalho de Melo
2019-01-03 13:19 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
1 sibling, 0 replies; 6+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-12-28 12:39 UTC (permalink / raw)
To: Jiri Olsa
Cc: lkml, Ingo Molnar, Namhyung Kim, Alexander Shishkin,
Peter Zijlstra, Joe Mario
Em Fri, Dec 28, 2018 at 11:18:20AM +0100, Jiri Olsa escreveu:
> The cachelines being reported go down to 0.05%. hat makes for very
> long output files. Raising that to 0.1%. The user can always specify
> --show-all if they want all the cachelines.
Thanks, applied.
- Arnaldo
> Suggested-by: Joe Mario <jmario@redhat.com>
> Link: http://lkml.kernel.org/n/tip-uwxpd36jutygit56mycanwma@git.kernel.org
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
> tools/perf/builtin-c2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
> index 321687f8f373..30584cb44fb7 100644
> --- a/tools/perf/builtin-c2c.c
> +++ b/tools/perf/builtin-c2c.c
> @@ -1878,7 +1878,7 @@ static int c2c_hists__reinit(struct c2c_hists *c2c_hists,
> return hpp_list__parse(&c2c_hists->list, output, sort);
> }
>
> -#define DISPLAY_LINE_LIMIT 0.0005
> +#define DISPLAY_LINE_LIMIT 0.001
>
> static bool he__display(struct hist_entry *he, struct c2c_stats *stats)
> {
> --
> 2.17.2
--
- Arnaldo
^ permalink raw reply [flat|nested] 6+ messages in thread* [tip:perf/urgent] perf c2c: Increase the HITM ratio limit for displayed cachelines
2018-12-28 10:18 ` [PATCH 2/2] perf c2c: Increase the HITM ratio limit for displayed cachelines Jiri Olsa
2018-12-28 12:39 ` Arnaldo Carvalho de Melo
@ 2019-01-03 13:19 ` tip-bot for Jiri Olsa
1 sibling, 0 replies; 6+ messages in thread
From: tip-bot for Jiri Olsa @ 2019-01-03 13:19 UTC (permalink / raw)
To: linux-tip-commits
Cc: peterz, jolsa, tglx, acme, alexander.shishkin, mingo, jmario,
hpa, namhyung, linux-kernel
Commit-ID: c4a75bb9488a9f7b3c7e79017609529d1aa5deab
Gitweb: https://git.kernel.org/tip/c4a75bb9488a9f7b3c7e79017609529d1aa5deab
Author: Jiri Olsa <jolsa@kernel.org>
AuthorDate: Fri, 28 Dec 2018 11:18:20 +0100
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 28 Dec 2018 16:33:07 -0300
perf c2c: Increase the HITM ratio limit for displayed cachelines
The cachelines being reported are the ones with percentages all the way
down to 0.05%. That makes for very long output files. Raising that to
0.1%. The user can always specify --show-all if they want all the
cachelines with hits.
Suggested-by: Joe Mario <jmario@redhat.com>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20181228101820.28010-2-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-c2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
index 964f3f5ef420..d340d2e42776 100644
--- a/tools/perf/builtin-c2c.c
+++ b/tools/perf/builtin-c2c.c
@@ -1878,7 +1878,7 @@ static int c2c_hists__reinit(struct c2c_hists *c2c_hists,
return hpp_list__parse(&c2c_hists->list, output, sort);
}
-#define DISPLAY_LINE_LIMIT 0.0005
+#define DISPLAY_LINE_LIMIT 0.001
static bool he__display(struct hist_entry *he, struct c2c_stats *stats)
{
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] perf c2c: Change the default coalesce setup
2018-12-28 10:18 [PATCH 1/2] perf c2c: Change the default coalesce setup Jiri Olsa
2018-12-28 10:18 ` [PATCH 2/2] perf c2c: Increase the HITM ratio limit for displayed cachelines Jiri Olsa
@ 2018-12-28 12:34 ` Arnaldo Carvalho de Melo
2019-01-03 13:18 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2 siblings, 0 replies; 6+ messages in thread
From: Arnaldo Carvalho de Melo @ 2018-12-28 12:34 UTC (permalink / raw)
To: Jiri Olsa
Cc: lkml, Ingo Molnar, Namhyung Kim, Alexander Shishkin,
Peter Zijlstra, Joe Mario
Em Fri, Dec 28, 2018 at 11:18:19AM +0100, Jiri Olsa escreveu:
> Joe suggested to have the coalesce default set just to 'iaddr',
> because it's easier to read on the (default) c2c report run.
>
> By removing pid from -c option, the c2c report will group all
> the relevant pids under instruction address bucket. User can
> always run -c pid,iaddr for more grained output on particular
> pids.
Thanks, applied.
- Arnaldo
^ permalink raw reply [flat|nested] 6+ messages in thread
* [tip:perf/urgent] perf c2c: Change the default coalesce setup
2018-12-28 10:18 [PATCH 1/2] perf c2c: Change the default coalesce setup Jiri Olsa
2018-12-28 10:18 ` [PATCH 2/2] perf c2c: Increase the HITM ratio limit for displayed cachelines Jiri Olsa
2018-12-28 12:34 ` [PATCH 1/2] perf c2c: Change the default coalesce setup Arnaldo Carvalho de Melo
@ 2019-01-03 13:18 ` tip-bot for Jiri Olsa
2 siblings, 0 replies; 6+ messages in thread
From: tip-bot for Jiri Olsa @ 2019-01-03 13:18 UTC (permalink / raw)
To: linux-tip-commits
Cc: acme, mingo, hpa, alexander.shishkin, peterz, jmario,
linux-kernel, jolsa, tglx, namhyung
Commit-ID: 423701a0c8d754d9a39547f6c48904347e4f1eca
Gitweb: https://git.kernel.org/tip/423701a0c8d754d9a39547f6c48904347e4f1eca
Author: Jiri Olsa <jolsa@kernel.org>
AuthorDate: Fri, 28 Dec 2018 11:18:19 +0100
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 28 Dec 2018 16:33:06 -0300
perf c2c: Change the default coalesce setup
Joe suggested to have the coalesce default set just to 'iaddr', because
it's easier to read on the default 'perf c2c report' output.
By removing the "pid" field from the default -c/--coalesce option, the
'perf c2c' report will group all the relevant PIDs under the instruction
address ('iaddr') bucket. User can always run "-c pid,iaddr" for a more
fine grained output on particular PIDs.
Suggested-by: Joe Mario <jmario@redhat.com>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20181228101820.28010-1-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-c2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
index f3aa9d02a5ab..964f3f5ef420 100644
--- a/tools/perf/builtin-c2c.c
+++ b/tools/perf/builtin-c2c.c
@@ -68,7 +68,7 @@ struct c2c_hist_entry {
struct hist_entry he;
};
-static char const *coalesce_default = "pid,iaddr";
+static char const *coalesce_default = "iaddr";
struct perf_c2c {
struct perf_tool tool;
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-01-03 13:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-28 10:18 [PATCH 1/2] perf c2c: Change the default coalesce setup Jiri Olsa
2018-12-28 10:18 ` [PATCH 2/2] perf c2c: Increase the HITM ratio limit for displayed cachelines Jiri Olsa
2018-12-28 12:39 ` Arnaldo Carvalho de Melo
2019-01-03 13:19 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2018-12-28 12:34 ` [PATCH 1/2] perf c2c: Change the default coalesce setup Arnaldo Carvalho de Melo
2019-01-03 13:18 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).