* [PATCH v4 01/11] ACPI / LPSS: Make PCI dependency explicit
[not found] <20181230195612.6657-1-okaya@kernel.org>
@ 2018-12-30 19:56 ` Sinan Kaya
2018-12-30 19:56 ` [PATCH v4 02/11] ata: pata_acpi: " Sinan Kaya
` (9 subsequent siblings)
10 siblings, 0 replies; 25+ messages in thread
From: Sinan Kaya @ 2018-12-30 19:56 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Rafael J. Wysocki, Len Brown, open list
This code depends on PCI. Compile only when PCI is present.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/acpi/Makefile | 3 ++-
drivers/acpi/internal.h | 4 ++++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile
index 7c6afc111d76..bb857421c2e8 100644
--- a/drivers/acpi/Makefile
+++ b/drivers/acpi/Makefile
@@ -41,7 +41,8 @@ acpi-y += ec.o
acpi-$(CONFIG_ACPI_DOCK) += dock.o
acpi-$(CONFIG_PCI) += pci_root.o pci_link.o pci_irq.o
obj-$(CONFIG_ACPI_MCFG) += pci_mcfg.o
-acpi-y += acpi_lpss.o acpi_apd.o
+acpi-$(CONFIG_PCI) += acpi_lpss.o
+acpi-y += acpi_apd.o
acpi-y += acpi_platform.o
acpi-y += acpi_pnp.o
acpi-$(CONFIG_ARM_AMBA) += acpi_amba.o
diff --git a/drivers/acpi/internal.h b/drivers/acpi/internal.h
index 7e6952edb5b0..6a9e1fb8913a 100644
--- a/drivers/acpi/internal.h
+++ b/drivers/acpi/internal.h
@@ -81,7 +81,11 @@ void acpi_debugfs_init(void);
#else
static inline void acpi_debugfs_init(void) { return; }
#endif
+#ifdef CONFIG_PCI
void acpi_lpss_init(void);
+#else
+static inline void acpi_lpss_init(void) {}
+#endif
void acpi_apd_init(void);
--
2.19.0
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v4 02/11] ata: pata_acpi: Make PCI dependency explicit
[not found] <20181230195612.6657-1-okaya@kernel.org>
2018-12-30 19:56 ` [PATCH v4 01/11] ACPI / LPSS: Make PCI dependency explicit Sinan Kaya
@ 2018-12-30 19:56 ` Sinan Kaya
2018-12-30 19:56 ` [PATCH v4 03/11] vga-switcheroo: make " Sinan Kaya
` (8 subsequent siblings)
10 siblings, 0 replies; 25+ messages in thread
From: Sinan Kaya @ 2018-12-30 19:56 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Jens Axboe,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list
PATA_ACPI is a PCI device driver but the PCI dependency has not been
explicitly called out.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/ata/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 4ca7a6b4eaae..8218db17ebdb 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -1091,7 +1091,7 @@ comment "Generic fallback / legacy drivers"
config PATA_ACPI
tristate "ACPI firmware driver for PATA"
- depends on ATA_ACPI && ATA_BMDMA
+ depends on ATA_ACPI && ATA_BMDMA && PCI
help
This option enables an ACPI method driver which drives
motherboard PATA controller interfaces through the ACPI
--
2.19.0
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v4 03/11] vga-switcheroo: make PCI dependency explicit
[not found] <20181230195612.6657-1-okaya@kernel.org>
2018-12-30 19:56 ` [PATCH v4 01/11] ACPI / LPSS: Make PCI dependency explicit Sinan Kaya
2018-12-30 19:56 ` [PATCH v4 02/11] ata: pata_acpi: " Sinan Kaya
@ 2018-12-30 19:56 ` Sinan Kaya
2019-01-07 10:34 ` Daniel Vetter
2018-12-30 19:56 ` [PATCH v4 04/11] platform/x86: intel_ips: " Sinan Kaya
` (7 subsequent siblings)
10 siblings, 1 reply; 25+ messages in thread
From: Sinan Kaya @ 2018-12-30 19:56 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, David Airlie, Daniel Vetter,
Maarten Lankhorst, Maxime Ripard, Sean Paul,
open list:DRM DRIVERS, open list
This driver depends on the PCI infrastructure but the dependency has not
been explicitly called out.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
Reviewed-by: Lukas Wunner <lukas@wunner.de>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/gpu/vga/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/vga/Kconfig b/drivers/gpu/vga/Kconfig
index b677e5d524e6..d5f1d8e1c6f8 100644
--- a/drivers/gpu/vga/Kconfig
+++ b/drivers/gpu/vga/Kconfig
@@ -21,6 +21,7 @@ config VGA_SWITCHEROO
bool "Laptop Hybrid Graphics - GPU switching support"
depends on X86
depends on ACPI
+ depends on PCI
select VGA_ARB
help
Many laptops released in 2008/9/10 have two GPUs with a multiplexer
--
2.19.0
^ permalink raw reply related [flat|nested] 25+ messages in thread
* Re: [PATCH v4 03/11] vga-switcheroo: make PCI dependency explicit
2018-12-30 19:56 ` [PATCH v4 03/11] vga-switcheroo: make " Sinan Kaya
@ 2019-01-07 10:34 ` Daniel Vetter
2019-01-07 10:53 ` Rafael J. Wysocki
0 siblings, 1 reply; 25+ messages in thread
From: Daniel Vetter @ 2019-01-07 10:34 UTC (permalink / raw)
To: Sinan Kaya
Cc: linux-next, linux-acpi, David Airlie, Daniel Vetter,
Maarten Lankhorst, Maxime Ripard, Sean Paul,
open list:DRM DRIVERS, open list
On Sun, Dec 30, 2018 at 07:56:04PM +0000, Sinan Kaya wrote:
> This driver depends on the PCI infrastructure but the dependency has not
> been explicitly called out.
>
> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> Reviewed-by: Lukas Wunner <lukas@wunner.de>
> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
I'm assuming this goes in through the acpi tree, correct?
-Daniel
> ---
> drivers/gpu/vga/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/vga/Kconfig b/drivers/gpu/vga/Kconfig
> index b677e5d524e6..d5f1d8e1c6f8 100644
> --- a/drivers/gpu/vga/Kconfig
> +++ b/drivers/gpu/vga/Kconfig
> @@ -21,6 +21,7 @@ config VGA_SWITCHEROO
> bool "Laptop Hybrid Graphics - GPU switching support"
> depends on X86
> depends on ACPI
> + depends on PCI
> select VGA_ARB
> help
> Many laptops released in 2008/9/10 have two GPUs with a multiplexer
> --
> 2.19.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v4 03/11] vga-switcheroo: make PCI dependency explicit
2019-01-07 10:34 ` Daniel Vetter
@ 2019-01-07 10:53 ` Rafael J. Wysocki
0 siblings, 0 replies; 25+ messages in thread
From: Rafael J. Wysocki @ 2019-01-07 10:53 UTC (permalink / raw)
To: Sinan Kaya, Linux-Next Mailing List, ACPI Devel Maling List,
David Airlie, Maarten Lankhorst, Maxime Ripard, Sean Paul,
open list:DRM DRIVERS, open list
Cc: Daniel Vetter
On Mon, Jan 7, 2019 at 11:34 AM Daniel Vetter <daniel@ffwll.ch> wrote:
>
> On Sun, Dec 30, 2018 at 07:56:04PM +0000, Sinan Kaya wrote:
> > This driver depends on the PCI infrastructure but the dependency has not
> > been explicitly called out.
> >
> > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> > Signed-off-by: Sinan Kaya <okaya@kernel.org>
> > Reviewed-by: Lukas Wunner <lukas@wunner.de>
> > Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> I'm assuming this goes in through the acpi tree, correct?
I'm going to pick it up.
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH v4 04/11] platform/x86: intel_ips: make PCI dependency explicit
[not found] <20181230195612.6657-1-okaya@kernel.org>
` (2 preceding siblings ...)
2018-12-30 19:56 ` [PATCH v4 03/11] vga-switcheroo: make " Sinan Kaya
@ 2018-12-30 19:56 ` Sinan Kaya
2018-12-30 19:56 ` [PATCH v4 05/11] platform/x86: intel_pmc: Make " Sinan Kaya
` (6 subsequent siblings)
10 siblings, 0 replies; 25+ messages in thread
From: Sinan Kaya @ 2018-12-30 19:56 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Darren Hart, Andy Shevchenko,
open list:X86 PLATFORM DRIVERS, open list
ipss driver is a PCI device driver but this has not been mentioned
anywhere in Kconfig.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/platform/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index e3b62c2ee8d1..b36ea14b41ad 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -1009,7 +1009,7 @@ config INTEL_MFLD_THERMAL
config INTEL_IPS
tristate "Intel Intelligent Power Sharing"
- depends on ACPI
+ depends on ACPI && PCI
---help---
Intel Calpella platforms support dynamic power sharing between the
CPU and GPU, maximizing performance in a given TDP. This driver,
--
2.19.0
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v4 05/11] platform/x86: intel_pmc: Make PCI dependency explicit
[not found] <20181230195612.6657-1-okaya@kernel.org>
` (3 preceding siblings ...)
2018-12-30 19:56 ` [PATCH v4 04/11] platform/x86: intel_ips: " Sinan Kaya
@ 2018-12-30 19:56 ` Sinan Kaya
2018-12-30 19:56 ` [PATCH v4 06/11] platform/x86: apple-gmux: " Sinan Kaya
` (5 subsequent siblings)
10 siblings, 0 replies; 25+ messages in thread
From: Sinan Kaya @ 2018-12-30 19:56 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Darren Hart, Andy Shevchenko,
open list:X86 PLATFORM DRIVERS, open list
Code relies on PCI for execution. Specify this in the Kconfig.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/platform/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index b36ea14b41ad..7afb96cb1cd6 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -1174,7 +1174,7 @@ config INTEL_SMARTCONNECT
config INTEL_PMC_IPC
tristate "Intel PMC IPC Driver"
- depends on ACPI
+ depends on ACPI && PCI
---help---
This driver provides support for PMC control on some Intel platforms.
The PMC is an ARC processor which defines IPC commands for communication
--
2.19.0
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v4 06/11] platform/x86: apple-gmux: Make PCI dependency explicit
[not found] <20181230195612.6657-1-okaya@kernel.org>
` (4 preceding siblings ...)
2018-12-30 19:56 ` [PATCH v4 05/11] platform/x86: intel_pmc: Make " Sinan Kaya
@ 2018-12-30 19:56 ` Sinan Kaya
2018-12-30 20:01 ` Lukas Wunner
2018-12-30 19:56 ` [PATCH v4 07/11] drivers: thermal: int3406_thermal: " Sinan Kaya
` (4 subsequent siblings)
10 siblings, 1 reply; 25+ messages in thread
From: Sinan Kaya @ 2018-12-30 19:56 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Darren Hart, Andy Shevchenko,
open list:X86 PLATFORM DRIVERS, open list
This driver depends on the PCI infrastructure but the dependency has not
been explicitly called out.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/platform/x86/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 7afb96cb1cd6..89f4b86244a7 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -1136,6 +1136,7 @@ config SAMSUNG_Q10
config APPLE_GMUX
tristate "Apple Gmux Driver"
depends on ACPI
+ depends on PCI
depends on PNP
depends on BACKLIGHT_CLASS_DEVICE
depends on BACKLIGHT_APPLE=n || BACKLIGHT_APPLE
--
2.19.0
^ permalink raw reply related [flat|nested] 25+ messages in thread
* Re: [PATCH v4 06/11] platform/x86: apple-gmux: Make PCI dependency explicit
2018-12-30 19:56 ` [PATCH v4 06/11] platform/x86: apple-gmux: " Sinan Kaya
@ 2018-12-30 20:01 ` Lukas Wunner
0 siblings, 0 replies; 25+ messages in thread
From: Lukas Wunner @ 2018-12-30 20:01 UTC (permalink / raw)
To: Sinan Kaya
Cc: linux-next, linux-acpi, Darren Hart, Andy Shevchenko,
open list:X86 PLATFORM DRIVERS, open list
On Sun, Dec 30, 2018 at 07:56:07PM +0000, Sinan Kaya wrote:
> This driver depends on the PCI infrastructure but the dependency has not
> been explicitly called out.
>
> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
Reviewed-by: Lukas Wunner <lukas@wunner.de>
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH v4 07/11] drivers: thermal: int3406_thermal: Make PCI dependency explicit
[not found] <20181230195612.6657-1-okaya@kernel.org>
` (5 preceding siblings ...)
2018-12-30 19:56 ` [PATCH v4 06/11] platform/x86: apple-gmux: " Sinan Kaya
@ 2018-12-30 19:56 ` Sinan Kaya
2018-12-30 19:56 ` [PATCH v4 08/11] ASoC: Intel: atom: " Sinan Kaya
` (3 subsequent siblings)
10 siblings, 0 replies; 25+ messages in thread
From: Sinan Kaya @ 2018-12-30 19:56 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Zhang Rui, Eduardo Valentin,
Daniel Lezcano, Amit Kucheria, open list:THERMAL, open list
Need CONFIG_PCI to be set in order to be able to use this driver.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/thermal/intel/int340x_thermal/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/intel/int340x_thermal/Kconfig b/drivers/thermal/intel/int340x_thermal/Kconfig
index 0582bd12a239..fba1976d5f8d 100644
--- a/drivers/thermal/intel/int340x_thermal/Kconfig
+++ b/drivers/thermal/intel/int340x_thermal/Kconfig
@@ -31,7 +31,7 @@ if INT340X_THERMAL
config INT3406_THERMAL
tristate "ACPI INT3406 display thermal driver"
- depends on ACPI_VIDEO
+ depends on ACPI_VIDEO && PCI
help
The display thermal device represents the LED/LCD display panel
that may or may not include touch support. The main function of
--
2.19.0
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit
[not found] <20181230195612.6657-1-okaya@kernel.org>
` (6 preceding siblings ...)
2018-12-30 19:56 ` [PATCH v4 07/11] drivers: thermal: int3406_thermal: " Sinan Kaya
@ 2018-12-30 19:56 ` Sinan Kaya
2018-12-31 17:46 ` Mark Brown
2019-01-02 9:34 ` Rafael J. Wysocki
2018-12-30 19:56 ` [PATCH v4 09/11] mmc: sdhci-acpi: " Sinan Kaya
` (2 subsequent siblings)
10 siblings, 2 replies; 25+ messages in thread
From: Sinan Kaya @ 2018-12-30 19:56 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Pierre-Louis Bossart, Liam Girdwood,
Jie Yang, Mark Brown, Jaroslav Kysela, Takashi Iwai,
moderated list:INTEL ASoC DRIVERS, open list
Code does unconditional select for IOSF_MBI. IOSF_MBI driver depends on
CONFIG_PCI set but this is not specified anywhere.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
sound/soc/intel/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
index 2fd1b61e8331..b0764b2fe001 100644
--- a/sound/soc/intel/Kconfig
+++ b/sound/soc/intel/Kconfig
@@ -91,7 +91,7 @@ config SND_SST_ATOM_HIFI2_PLATFORM_PCI
config SND_SST_ATOM_HIFI2_PLATFORM_ACPI
tristate "ACPI HiFi2 (Baytrail, Cherrytrail) Platforms"
default ACPI
- depends on X86 && ACPI
+ depends on X86 && ACPI && PCI
select SND_SST_IPC_ACPI
select SND_SST_ATOM_HIFI2_PLATFORM
select SND_SOC_ACPI_INTEL_MATCH
--
2.19.0
^ permalink raw reply related [flat|nested] 25+ messages in thread
* Re: [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit
2018-12-30 19:56 ` [PATCH v4 08/11] ASoC: Intel: atom: " Sinan Kaya
@ 2018-12-31 17:46 ` Mark Brown
2018-12-31 17:52 ` Sinan Kaya
2019-01-02 9:34 ` Rafael J. Wysocki
1 sibling, 1 reply; 25+ messages in thread
From: Mark Brown @ 2018-12-31 17:46 UTC (permalink / raw)
To: Sinan Kaya
Cc: linux-next, linux-acpi, Pierre-Louis Bossart, Liam Girdwood,
Jie Yang, Jaroslav Kysela, Takashi Iwai,
moderated list:INTEL ASoC DRIVERS, open list
[-- Attachment #1: Type: text/plain, Size: 282 bytes --]
On Sun, Dec 30, 2018 at 07:56:09PM +0000, Sinan Kaya wrote:
> Code does unconditional select for IOSF_MBI. IOSF_MBI driver depends on
> CONFIG_PCI set but this is not specified anywhere.
I don't have the cover letter or anything for this series, what's going
on with dependencies?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit
2018-12-31 17:46 ` Mark Brown
@ 2018-12-31 17:52 ` Sinan Kaya
2018-12-31 19:30 ` Mark Brown
0 siblings, 1 reply; 25+ messages in thread
From: Sinan Kaya @ 2018-12-31 17:52 UTC (permalink / raw)
To: Mark Brown
Cc: Linux Next Mailing List, ACPI Devel Mailing List,
Pierre-Louis Bossart, Liam Girdwood, Jie Yang, Jaroslav Kysela,
Takashi Iwai, moderated list:INTEL ASoC DRIVERS, open list
On Mon, Dec 31, 2018 at 8:47 PM Mark Brown <broonie@kernel.org> wrote:
>
> On Sun, Dec 30, 2018 at 07:56:09PM +0000, Sinan Kaya wrote:
> > Code does unconditional select for IOSF_MBI. IOSF_MBI driver depends on
> > CONFIG_PCI set but this is not specified anywhere.
>
> I don't have the cover letter or anything for this series, what's going
> on with dependencies?
Here is the executive summary:
I have a changeset that separates ACPI from PCI on 4.21. CONFIG_ACPI
used to select PCI. This is no longer true.
You can build an ACPI system without any PCI devices.
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit
2018-12-31 17:52 ` Sinan Kaya
@ 2018-12-31 19:30 ` Mark Brown
2018-12-31 19:35 ` Sinan Kaya
0 siblings, 1 reply; 25+ messages in thread
From: Mark Brown @ 2018-12-31 19:30 UTC (permalink / raw)
To: Sinan Kaya
Cc: Linux Next Mailing List, ACPI Devel Mailing List,
Pierre-Louis Bossart, Liam Girdwood, Jie Yang, Jaroslav Kysela,
Takashi Iwai, moderated list:INTEL ASoC DRIVERS, open list
[-- Attachment #1: Type: text/plain, Size: 498 bytes --]
On Mon, Dec 31, 2018 at 08:52:52PM +0300, Sinan Kaya wrote:
> On Mon, Dec 31, 2018 at 8:47 PM Mark Brown <broonie@kernel.org> wrote:
> > I don't have the cover letter or anything for this series, what's going
> > on with dependencies?
> Here is the executive summary:
> I have a changeset that separates ACPI from PCI on 4.21. CONFIG_ACPI
> used to select PCI. This is no longer true.
> You can build an ACPI system without any PCI devices.
So there's no dependency and I can just apply this?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit
2018-12-31 19:30 ` Mark Brown
@ 2018-12-31 19:35 ` Sinan Kaya
2018-12-31 20:29 ` Pierre-Louis Bossart
0 siblings, 1 reply; 25+ messages in thread
From: Sinan Kaya @ 2018-12-31 19:35 UTC (permalink / raw)
To: Mark Brown
Cc: Linux Next Mailing List, ACPI Devel Mailing List,
Pierre-Louis Bossart, Liam Girdwood, Jie Yang, Jaroslav Kysela,
Takashi Iwai, moderated list:INTEL ASoC DRIVERS, open list
On Mon, Dec 31, 2018 at 10:30 PM Mark Brown <broonie@kernel.org> wrote:
>
> On Mon, Dec 31, 2018 at 08:52:52PM +0300, Sinan Kaya wrote:
> > On Mon, Dec 31, 2018 at 8:47 PM Mark Brown <broonie@kernel.org> wrote:
>
> > > I don't have the cover letter or anything for this series, what's going
> > > on with dependencies?
>
> > Here is the executive summary:
>
> > I have a changeset that separates ACPI from PCI on 4.21. CONFIG_ACPI
> > used to select PCI. This is no longer true.
>
> > You can build an ACPI system without any PCI devices.
>
> So there's no dependency and I can just apply this?
The plan is to apply this patchset via ACPI tree. Need an Acked-by per patch.
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit
2018-12-31 19:35 ` Sinan Kaya
@ 2018-12-31 20:29 ` Pierre-Louis Bossart
2018-12-31 20:35 ` Sinan Kaya
0 siblings, 1 reply; 25+ messages in thread
From: Pierre-Louis Bossart @ 2018-12-31 20:29 UTC (permalink / raw)
To: Sinan Kaya, Mark Brown
Cc: Linux Next Mailing List, ACPI Devel Mailing List, Liam Girdwood,
Jie Yang, Jaroslav Kysela, Takashi Iwai,
moderated list:INTEL ASoC DRIVERS, open list
On 12/31/18 1:35 PM, Sinan Kaya wrote:
> On Mon, Dec 31, 2018 at 10:30 PM Mark Brown <broonie@kernel.org> wrote:
>> On Mon, Dec 31, 2018 at 08:52:52PM +0300, Sinan Kaya wrote:
>>> On Mon, Dec 31, 2018 at 8:47 PM Mark Brown <broonie@kernel.org> wrote:
>>>> I don't have the cover letter or anything for this series, what's going
>>>> on with dependencies?
>>> Here is the executive summary:
>>> I have a changeset that separates ACPI from PCI on 4.21. CONFIG_ACPI
>>> used to select PCI. This is no longer true.
>>> You can build an ACPI system without any PCI devices.
>> So there's no dependency and I can just apply this?
> The plan is to apply this patchset via ACPI tree. Need an Acked-by per patch.
Anytime we change the Kconfig settings for audio, we get all kinds of
problems with randconfig and 0day/kbuild due to depend/select issues.
I'd like to give this a spin first, can you share a link to the entire
series? Thanks!
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit
2018-12-31 20:29 ` Pierre-Louis Bossart
@ 2018-12-31 20:35 ` Sinan Kaya
2018-12-31 21:42 ` Pierre-Louis Bossart
0 siblings, 1 reply; 25+ messages in thread
From: Sinan Kaya @ 2018-12-31 20:35 UTC (permalink / raw)
To: Pierre-Louis Bossart
Cc: Mark Brown, Linux Next Mailing List, ACPI Devel Mailing List,
Liam Girdwood, Jie Yang, Jaroslav Kysela, Takashi Iwai,
moderated list:INTEL ASoC DRIVERS, open list
On Mon, Dec 31, 2018 at 11:29 PM Pierre-Louis Bossart
<pierre-louis.bossart@linux.intel.com> wrote:
>
>
> On 12/31/18 1:35 PM, Sinan Kaya wrote:
> > On Mon, Dec 31, 2018 at 10:30 PM Mark Brown <broonie@kernel.org> wrote:
> >> On Mon, Dec 31, 2018 at 08:52:52PM +0300, Sinan Kaya wrote:
> >>> On Mon, Dec 31, 2018 at 8:47 PM Mark Brown <broonie@kernel.org> wrote:
> >>>> I don't have the cover letter or anything for this series, what's going
> >>>> on with dependencies?
> >>> Here is the executive summary:
> >>> I have a changeset that separates ACPI from PCI on 4.21. CONFIG_ACPI
> >>> used to select PCI. This is no longer true.
> >>> You can build an ACPI system without any PCI devices.
> >> So there's no dependency and I can just apply this?
> > The plan is to apply this patchset via ACPI tree. Need an Acked-by per patch.
> Anytime we change the Kconfig settings for audio, we get all kinds of
> problems with randconfig and 0day/kbuild due to depend/select issues.
> I'd like to give this a spin first, can you share a link to the entire
> series? Thanks!
Sure,
You can find them here
https://lore.kernel.org/patchwork/patch/1028330/
Click related.
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit
2018-12-31 20:35 ` Sinan Kaya
@ 2018-12-31 21:42 ` Pierre-Louis Bossart
2019-01-01 1:07 ` Sinan Kaya
0 siblings, 1 reply; 25+ messages in thread
From: Pierre-Louis Bossart @ 2018-12-31 21:42 UTC (permalink / raw)
To: Sinan Kaya
Cc: Mark Brown, Linux Next Mailing List, ACPI Devel Mailing List,
Liam Girdwood, Jie Yang, Jaroslav Kysela, Takashi Iwai,
moderated list:INTEL ASoC DRIVERS, open list
On 12/31/18 2:35 PM, Sinan Kaya wrote:
> On Mon, Dec 31, 2018 at 11:29 PM Pierre-Louis Bossart
> <pierre-louis.bossart@linux.intel.com> wrote:
>>
>> On 12/31/18 1:35 PM, Sinan Kaya wrote:
>>> On Mon, Dec 31, 2018 at 10:30 PM Mark Brown <broonie@kernel.org> wrote:
>>>> On Mon, Dec 31, 2018 at 08:52:52PM +0300, Sinan Kaya wrote:
>>>>> On Mon, Dec 31, 2018 at 8:47 PM Mark Brown <broonie@kernel.org> wrote:
>>>>>> I don't have the cover letter or anything for this series, what's going
>>>>>> on with dependencies?
>>>>> Here is the executive summary:
>>>>> I have a changeset that separates ACPI from PCI on 4.21. CONFIG_ACPI
>>>>> used to select PCI. This is no longer true.
>>>>> You can build an ACPI system without any PCI devices.
>>>> So there's no dependency and I can just apply this?
>>> The plan is to apply this patchset via ACPI tree. Need an Acked-by per patch.
>> Anytime we change the Kconfig settings for audio, we get all kinds of
>> problems with randconfig and 0day/kbuild due to depend/select issues.
>> I'd like to give this a spin first, can you share a link to the entire
>> series? Thanks!
> Sure,
>
> You can find them here
>
> https://lore.kernel.org/patchwork/patch/1028330/
>
> Click related.
Something must be missing, I get compilation errors when PCI is not
defined? And I see tons of references to pci stuff in drivers/acpi.
drivers/acpi/reboot.c: In function ‘acpi_reboot’:
drivers/acpi/reboot.c:37:10: error: implicit declaration of function
‘pci_find_bus’; did you mean ‘pci_find_next_bus’?
[-Werror=implicit-function-declaration]
bus0 = pci_find_bus(0, 0);
^~~~~~~~~~~~
pci_find_next_bus
drivers/acpi/reboot.c:37:8: warning: assignment makes pointer from
integer without a cast [-Wint-conversion]
bus0 = pci_find_bus(0, 0);
^
drivers/acpi/reboot.c:45:3: error: implicit declaration of function
‘pci_bus_write_config_byte’; did you mean ‘pci_write_config_byte’?
[-Werror=implicit-function-declaration]
pci_bus_write_config_byte(bus0, devfn,
^~~~~~~~~~~~~~~~~~~~~~~~~
pci_write_config_byte
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit
2018-12-31 21:42 ` Pierre-Louis Bossart
@ 2019-01-01 1:07 ` Sinan Kaya
2019-01-02 16:34 ` [alsa-devel] " Pierre-Louis Bossart
0 siblings, 1 reply; 25+ messages in thread
From: Sinan Kaya @ 2019-01-01 1:07 UTC (permalink / raw)
To: Pierre-Louis Bossart
Cc: Mark Brown, Linux Next Mailing List, ACPI Devel Mailing List,
Liam Girdwood, Jie Yang, Jaroslav Kysela, Takashi Iwai,
moderated list:INTEL ASoC DRIVERS, open list
On Tue, Jan 1, 2019 at 12:42 AM Pierre-Louis Bossart
<pierre-louis.bossart@linux.intel.com> wrote:
>
>
> On 12/31/18 2:35 PM, Sinan Kaya wrote:
> > On Mon, Dec 31, 2018 at 11:29 PM Pierre-Louis Bossart
> > <pierre-louis.bossart@linux.intel.com> wrote:
> >>
> >> On 12/31/18 1:35 PM, Sinan Kaya wrote:
> >>> On Mon, Dec 31, 2018 at 10:30 PM Mark Brown <broonie@kernel.org> wrote:
> >>>> On Mon, Dec 31, 2018 at 08:52:52PM +0300, Sinan Kaya wrote:
> >>>>> On Mon, Dec 31, 2018 at 8:47 PM Mark Brown <broonie@kernel.org> wrote:
> >>>>>> I don't have the cover letter or anything for this series, what's going
> >>>>>> on with dependencies?
> >>>>> Here is the executive summary:
> >>>>> I have a changeset that separates ACPI from PCI on 4.21. CONFIG_ACPI
> >>>>> used to select PCI. This is no longer true.
> >>>>> You can build an ACPI system without any PCI devices.
> >>>> So there's no dependency and I can just apply this?
> >>> The plan is to apply this patchset via ACPI tree. Need an Acked-by per patch.
> >> Anytime we change the Kconfig settings for audio, we get all kinds of
> >> problems with randconfig and 0day/kbuild due to depend/select issues.
> >> I'd like to give this a spin first, can you share a link to the entire
> >> series? Thanks!
> > Sure,
> >
> > You can find them here
> >
> > https://lore.kernel.org/patchwork/patch/1028330/
> >
> > Click related.
>
> Something must be missing, I get compilation errors when PCI is not
> defined? And I see tons of references to pci stuff in drivers/acpi.
>
> drivers/acpi/reboot.c: In function ‘acpi_reboot’:
> drivers/acpi/reboot.c:37:10: error: implicit declaration of function
> ‘pci_find_bus’; did you mean ‘pci_find_next_bus’?
> [-Werror=implicit-function-declaration]
> bus0 = pci_find_bus(0, 0);
> ^~~~~~~~~~~~
> pci_find_next_bus
> drivers/acpi/reboot.c:37:8: warning: assignment makes pointer from
> integer without a cast [-Wint-conversion]
> bus0 = pci_find_bus(0, 0);
> ^
> drivers/acpi/reboot.c:45:3: error: implicit declaration of function
> ‘pci_bus_write_config_byte’; did you mean ‘pci_write_config_byte’?
> [-Werror=implicit-function-declaration]
> pci_bus_write_config_byte(bus0, devfn,
> ^~~~~~~~~~~~~~~~~~~~~~~~~
> pci_write_config_byte
>
>
Please check out this tag next-20181224 and apply the patches afterwards.
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [alsa-devel] [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit
2019-01-01 1:07 ` Sinan Kaya
@ 2019-01-02 16:34 ` Pierre-Louis Bossart
0 siblings, 0 replies; 25+ messages in thread
From: Pierre-Louis Bossart @ 2019-01-02 16:34 UTC (permalink / raw)
To: Sinan Kaya
Cc: moderated list:INTEL ASoC DRIVERS, open list, Jie Yang,
Takashi Iwai, Liam Girdwood, ACPI Devel Mailing List, Mark Brown,
Linux Next Mailing List
> Please check out this tag next-20181224 and apply the patches afterwards.
Thanks, will do. I think this patchset will uncover additional
inconsistencies, e.g. for legacy Haswell/Broadwell/Baytrail the machine
drivers depend on X86_INTEL_LPSS, which depends in turn on PCI, but the
platform drivers only depend on ACPI, so there is a risk of creating a
config that makes no sense (or should only be used for COMPILE_TEST)
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit
2018-12-30 19:56 ` [PATCH v4 08/11] ASoC: Intel: atom: " Sinan Kaya
2018-12-31 17:46 ` Mark Brown
@ 2019-01-02 9:34 ` Rafael J. Wysocki
2019-01-02 9:36 ` Rafael J. Wysocki
1 sibling, 1 reply; 25+ messages in thread
From: Rafael J. Wysocki @ 2019-01-02 9:34 UTC (permalink / raw)
To: Sinan Kaya
Cc: Linux-Next Mailing List, ACPI Devel Maling List,
Pierre-Louis Bossart, Liam Girdwood, Jie Yang, Mark Brown,
Jaroslav Kysela, Takashi Iwai, moderated list:INTEL ASoC DRIVERS,
open list
On Sun, Dec 30, 2018 at 8:56 PM Sinan Kaya <okaya@kernel.org> wrote:
>
> Code does unconditional select for IOSF_MBI. IOSF_MBI driver depends on
> CONFIG_PCI set but this is not specified anywhere.
IMO it would be better to say
"After commit 5d32a66541c46 (PCI/ACPI: Allow ACPI to be built without
CONFIG_PCI set) dependencies on CONFIG_PCI that previously were
satisfied implicitly through dependencies on CONFIG_ACPI have to be
specified directly. For this reason, add a direct dependency on
CONFIG_PCI to the IOSF_MBI driver."
If you did that, the reviewers would know upfront what this was about
and that might save at least one back-and-forth e-mail exchange in
each case.
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit
2019-01-02 9:34 ` Rafael J. Wysocki
@ 2019-01-02 9:36 ` Rafael J. Wysocki
0 siblings, 0 replies; 25+ messages in thread
From: Rafael J. Wysocki @ 2019-01-02 9:36 UTC (permalink / raw)
To: Sinan Kaya
Cc: Linux-Next Mailing List, ACPI Devel Maling List,
Pierre-Louis Bossart, Liam Girdwood, Jie Yang, Mark Brown,
Jaroslav Kysela, Takashi Iwai, moderated list:INTEL ASoC DRIVERS,
open list
On Wed, Jan 2, 2019 at 10:34 AM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Sun, Dec 30, 2018 at 8:56 PM Sinan Kaya <okaya@kernel.org> wrote:
> >
> > Code does unconditional select for IOSF_MBI. IOSF_MBI driver depends on
> > CONFIG_PCI set but this is not specified anywhere.
>
> IMO it would be better to say
>
> "After commit 5d32a66541c46 (PCI/ACPI: Allow ACPI to be built without
> CONFIG_PCI set) dependencies on CONFIG_PCI that previously were
> satisfied implicitly through dependencies on CONFIG_ACPI have to be
> specified directly. For this reason, add a direct dependency on
> CONFIG_PCI to the IOSF_MBI driver."
>
> If you did that, the reviewers would know upfront what this was about
> and that might save at least one back-and-forth e-mail exchange in
> each case.
But, of course, the changelog doesn't even match the patch contents in
this particular case. Please fix that.
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH v4 09/11] mmc: sdhci-acpi: Make PCI dependency explicit
[not found] <20181230195612.6657-1-okaya@kernel.org>
` (7 preceding siblings ...)
2018-12-30 19:56 ` [PATCH v4 08/11] ASoC: Intel: atom: " Sinan Kaya
@ 2018-12-30 19:56 ` Sinan Kaya
2018-12-30 19:56 ` [PATCH v4 10/11] x86/intel/lpss: " Sinan Kaya
2018-12-30 19:56 ` [PATCH v4 11/11] drivers: thermal: int340x_thermal: " Sinan Kaya
10 siblings, 0 replies; 25+ messages in thread
From: Sinan Kaya @ 2018-12-30 19:56 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Ulf Hansson, Adrian Hunter, Shawn Lin,
Geert Uytterhoeven, Masahiro Yamada, Faiz Abbas, Chunyan Zhang,
Jisheng Zhang, Ludovic Barre, Arnd Bergmann, Alex Smith,
Chris Brandt, open list:MULTIMEDIA CARD (MMC),
SECURE DIGITAL (SD) AND...,
open list
Select IOSF_MBI only when PCI and X86 is set.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/mmc/host/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index e26b8145efb3..4c5f037b246d 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -117,7 +117,7 @@ config MMC_RICOH_MMC
config MMC_SDHCI_ACPI
tristate "SDHCI support for ACPI enumerated SDHCI controllers"
depends on MMC_SDHCI && ACPI
- select IOSF_MBI if X86
+ select IOSF_MBI if (X86 && PCI)
help
This selects support for ACPI enumerated SDHCI controllers,
identified by ACPI Compatibility ID PNP0D40 or specific
--
2.19.0
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v4 10/11] x86/intel/lpss: Make PCI dependency explicit
[not found] <20181230195612.6657-1-okaya@kernel.org>
` (8 preceding siblings ...)
2018-12-30 19:56 ` [PATCH v4 09/11] mmc: sdhci-acpi: " Sinan Kaya
@ 2018-12-30 19:56 ` Sinan Kaya
2018-12-30 19:56 ` [PATCH v4 11/11] drivers: thermal: int340x_thermal: " Sinan Kaya
10 siblings, 0 replies; 25+ messages in thread
From: Sinan Kaya @ 2018-12-30 19:56 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, H. Peter Anvin,
maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT),
open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)
LPSS code relies on PCI infrastructure but this dependency has not been
explicitly called out.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
arch/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index cc4f0c6ee1ed..322a58ababb0 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -617,7 +617,7 @@ config X86_INTEL_QUARK
config X86_INTEL_LPSS
bool "Intel Low Power Subsystem Support"
- depends on X86 && ACPI
+ depends on X86 && ACPI && PCI
select COMMON_CLK
select PINCTRL
select IOSF_MBI
--
2.19.0
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [PATCH v4 11/11] drivers: thermal: int340x_thermal: Make PCI dependency explicit
[not found] <20181230195612.6657-1-okaya@kernel.org>
` (9 preceding siblings ...)
2018-12-30 19:56 ` [PATCH v4 10/11] x86/intel/lpss: " Sinan Kaya
@ 2018-12-30 19:56 ` Sinan Kaya
10 siblings, 0 replies; 25+ messages in thread
From: Sinan Kaya @ 2018-12-30 19:56 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Zhang Rui, Eduardo Valentin,
Daniel Lezcano, Amit Kucheria, open list:THERMAL, open list
IOSF_CORE depends on PCI. This was never mentioned.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/thermal/intel/int340x_thermal/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/intel/int340x_thermal/Kconfig b/drivers/thermal/intel/int340x_thermal/Kconfig
index fba1976d5f8d..2acddf8fb314 100644
--- a/drivers/thermal/intel/int340x_thermal/Kconfig
+++ b/drivers/thermal/intel/int340x_thermal/Kconfig
@@ -4,7 +4,7 @@
config INT340X_THERMAL
tristate "ACPI INT340X thermal drivers"
- depends on X86 && ACPI
+ depends on X86 && ACPI && PCI
select THERMAL_GOV_USER_SPACE
select ACPI_THERMAL_REL
select ACPI_FAN
--
2.19.0
^ permalink raw reply related [flat|nested] 25+ messages in thread