* [PATCH] doc: rcu: Suspicious RCU usage is a warning
@ 2019-02-28 10:59 Geert Uytterhoeven
2019-02-28 16:51 ` Paul E. McKenney
2019-03-04 19:53 ` Jonathan Corbet
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2019-02-28 10:59 UTC (permalink / raw)
To: Jonathan Corbet, Paul E . McKenney
Cc: Josh Triplett, Steven Rostedt, Mathieu Desnoyers, Lai Jiangshan,
Joel Fernandes, linux-kernel, linux-doc, Geert Uytterhoeven
Suspicious RCU usage messages are reported as warnings.
Fixes: a5dd63efda3d07b5 ("lockdep: Use "WARNING" tag on lockdep splats")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
And before that, they were printed as errors, which was also never
reflected in the documentation...
---
Documentation/RCU/lockdep-splat.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/RCU/lockdep-splat.txt b/Documentation/RCU/lockdep-splat.txt
index 9423b633526d14df..9c015976b174123f 100644
--- a/Documentation/RCU/lockdep-splat.txt
+++ b/Documentation/RCU/lockdep-splat.txt
@@ -14,9 +14,9 @@ being the real world and all that.
So let's look at an example RCU lockdep splat from 3.0-rc5, one that
has long since been fixed:
-===============================
-[ INFO: suspicious RCU usage. ]
--------------------------------
+=============================
+WARNING: suspicious RCU usage
+-----------------------------
block/cfq-iosched.c:2776 suspicious rcu_dereference_protected() usage!
other info that might help us debug this:
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] doc: rcu: Suspicious RCU usage is a warning
2019-02-28 10:59 [PATCH] doc: rcu: Suspicious RCU usage is a warning Geert Uytterhoeven
@ 2019-02-28 16:51 ` Paul E. McKenney
2019-03-04 19:53 ` Jonathan Corbet
1 sibling, 0 replies; 3+ messages in thread
From: Paul E. McKenney @ 2019-02-28 16:51 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Jonathan Corbet, Josh Triplett, Steven Rostedt,
Mathieu Desnoyers, Lai Jiangshan, Joel Fernandes, linux-kernel,
linux-doc
On Thu, Feb 28, 2019 at 11:59:32AM +0100, Geert Uytterhoeven wrote:
> Suspicious RCU usage messages are reported as warnings.
>
> Fixes: a5dd63efda3d07b5 ("lockdep: Use "WARNING" tag on lockdep splats")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Paul E. McKenney <paulmck@linux.ibm.com>
> ---
> And before that, they were printed as errors, which was also never
> reflected in the documentation...
> ---
> Documentation/RCU/lockdep-splat.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/RCU/lockdep-splat.txt b/Documentation/RCU/lockdep-splat.txt
> index 9423b633526d14df..9c015976b174123f 100644
> --- a/Documentation/RCU/lockdep-splat.txt
> +++ b/Documentation/RCU/lockdep-splat.txt
> @@ -14,9 +14,9 @@ being the real world and all that.
> So let's look at an example RCU lockdep splat from 3.0-rc5, one that
> has long since been fixed:
>
> -===============================
> -[ INFO: suspicious RCU usage. ]
> --------------------------------
> +=============================
> +WARNING: suspicious RCU usage
> +-----------------------------
> block/cfq-iosched.c:2776 suspicious rcu_dereference_protected() usage!
>
> other info that might help us debug this:
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] doc: rcu: Suspicious RCU usage is a warning
2019-02-28 10:59 [PATCH] doc: rcu: Suspicious RCU usage is a warning Geert Uytterhoeven
2019-02-28 16:51 ` Paul E. McKenney
@ 2019-03-04 19:53 ` Jonathan Corbet
1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Corbet @ 2019-03-04 19:53 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Paul E . McKenney, Josh Triplett, Steven Rostedt,
Mathieu Desnoyers, Lai Jiangshan, Joel Fernandes, linux-kernel,
linux-doc
On Thu, 28 Feb 2019 11:59:32 +0100
Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> Suspicious RCU usage messages are reported as warnings.
>
> Fixes: a5dd63efda3d07b5 ("lockdep: Use "WARNING" tag on lockdep splats")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> And before that, they were printed as errors, which was also never
> reflected in the documentation...
> ---
> Documentation/RCU/lockdep-splat.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Applied, thanks.
jon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-04 19:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-28 10:59 [PATCH] doc: rcu: Suspicious RCU usage is a warning Geert Uytterhoeven
2019-02-28 16:51 ` Paul E. McKenney
2019-03-04 19:53 ` Jonathan Corbet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).