* [PATCH] fs/reiserfs/journal.c: Make remove_journal_hash static
@ 2019-04-14 11:24 Bharath Vedartham
2019-04-15 9:47 ` Jan Kara
0 siblings, 1 reply; 3+ messages in thread
From: Bharath Vedartham @ 2019-04-14 11:24 UTC (permalink / raw)
To: keescook, jack, arnd, akpm; +Cc: reiserfs-devel, linux-kernel
This fixes the -WDecl sparse warning in journal.c. Function was declared
as static void but the definition was void.
Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com>
---
fs/reiserfs/journal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c
index 8a76f9d..36346dc 100644
--- a/fs/reiserfs/journal.c
+++ b/fs/reiserfs/journal.c
@@ -1844,7 +1844,7 @@ static int flush_used_journal_lists(struct super_block *s,
* removes any nodes in table with name block and dev as bh.
* only touchs the hnext and hprev pointers.
*/
-void remove_journal_hash(struct super_block *sb,
+static void remove_journal_hash(struct super_block *sb,
struct reiserfs_journal_cnode **table,
struct reiserfs_journal_list *jl,
unsigned long block, int remove_freed)
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fs/reiserfs/journal.c: Make remove_journal_hash static
2019-04-14 11:24 [PATCH] fs/reiserfs/journal.c: Make remove_journal_hash static Bharath Vedartham
@ 2019-04-15 9:47 ` Jan Kara
2019-04-15 15:06 ` Bharath Vedartham
0 siblings, 1 reply; 3+ messages in thread
From: Jan Kara @ 2019-04-15 9:47 UTC (permalink / raw)
To: Bharath Vedartham
Cc: keescook, jack, arnd, akpm, reiserfs-devel, linux-kernel
On Sun 14-04-19 16:54:38, Bharath Vedartham wrote:
> This fixes the -WDecl sparse warning in journal.c. Function was declared
> as static void but the definition was void.
>
> Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com>
Thanks! I've added your patch into my tree.
Honza
> ---
> fs/reiserfs/journal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c
> index 8a76f9d..36346dc 100644
> --- a/fs/reiserfs/journal.c
> +++ b/fs/reiserfs/journal.c
> @@ -1844,7 +1844,7 @@ static int flush_used_journal_lists(struct super_block *s,
> * removes any nodes in table with name block and dev as bh.
> * only touchs the hnext and hprev pointers.
> */
> -void remove_journal_hash(struct super_block *sb,
> +static void remove_journal_hash(struct super_block *sb,
> struct reiserfs_journal_cnode **table,
> struct reiserfs_journal_list *jl,
> unsigned long block, int remove_freed)
> --
> 2.7.4
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fs/reiserfs/journal.c: Make remove_journal_hash static
2019-04-15 9:47 ` Jan Kara
@ 2019-04-15 15:06 ` Bharath Vedartham
0 siblings, 0 replies; 3+ messages in thread
From: Bharath Vedartham @ 2019-04-15 15:06 UTC (permalink / raw)
To: Jan Kara; +Cc: keescook, arnd, akpm, reiserfs-devel, linux-kernel
On Mon, Apr 15, 2019 at 11:47:39AM +0200, Jan Kara wrote:
> On Sun 14-04-19 16:54:38, Bharath Vedartham wrote:
> > This fixes the -WDecl sparse warning in journal.c. Function was declared
> > as static void but the definition was void.
> >
> > Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com>
>
> Thanks! I've added your patch into my tree.
>
Thanks Jan!
> Honza
>
> > ---
> > fs/reiserfs/journal.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c
> > index 8a76f9d..36346dc 100644
> > --- a/fs/reiserfs/journal.c
> > +++ b/fs/reiserfs/journal.c
> > @@ -1844,7 +1844,7 @@ static int flush_used_journal_lists(struct super_block *s,
> > * removes any nodes in table with name block and dev as bh.
> > * only touchs the hnext and hprev pointers.
> > */
> > -void remove_journal_hash(struct super_block *sb,
> > +static void remove_journal_hash(struct super_block *sb,
> > struct reiserfs_journal_cnode **table,
> > struct reiserfs_journal_list *jl,
> > unsigned long block, int remove_freed)
> > --
> > 2.7.4
> >
> --
> Jan Kara <jack@suse.com>
> SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-15 15:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-14 11:24 [PATCH] fs/reiserfs/journal.c: Make remove_journal_hash static Bharath Vedartham
2019-04-15 9:47 ` Jan Kara
2019-04-15 15:06 ` Bharath Vedartham
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).