[PATCH] fs/reiserfs/journal.c: Make remove_journal_hash static

[PATCH] fs/reiserfs/journal.c: Make remove_journal_hash static

[Bharath Vedartham]

This fixes the -WDecl sparse warning in journal.c. Function was declared
as static void but the definition was void.

Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com>
---
 fs/reiserfs/journal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c
index 8a76f9d..36346dc 100644
--- a/fs/reiserfs/journal.c
+++ b/fs/reiserfs/journal.c
@@ -1844,7 +1844,7 @@ static int flush_used_journal_lists(struct super_block *s,
  * removes any nodes in table with name block and dev as bh.
  * only touchs the hnext and hprev pointers.
  */
-void remove_journal_hash(struct super_block *sb,
+static void remove_journal_hash(struct super_block *sb,
 			 struct reiserfs_journal_cnode **table,
 			 struct reiserfs_journal_list *jl,
 			 unsigned long block, int remove_freed)
-- 
2.7.4

Re: [PATCH] fs/reiserfs/journal.c: Make remove_journal_hash static

[Jan Kara]

On Sun 14-04-19 16:54:38, Bharath Vedartham wrote:
> This fixes the -WDecl sparse warning in journal.c. Function was declared
> as static void but the definition was void.
> 
> Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com>

Thanks! I've added your patch into my tree.

								Honza

> ---
>  fs/reiserfs/journal.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c
> index 8a76f9d..36346dc 100644
> --- a/fs/reiserfs/journal.c
> +++ b/fs/reiserfs/journal.c
> @@ -1844,7 +1844,7 @@ static int flush_used_journal_lists(struct super_block *s,
>   * removes any nodes in table with name block and dev as bh.
>   * only touchs the hnext and hprev pointers.
>   */
> -void remove_journal_hash(struct super_block *sb,
> +static void remove_journal_hash(struct super_block *sb,
>  			 struct reiserfs_journal_cnode **table,
>  			 struct reiserfs_journal_list *jl,
>  			 unsigned long block, int remove_freed)
> -- 
> 2.7.4
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Re: [PATCH] fs/reiserfs/journal.c: Make remove_journal_hash static

[Bharath Vedartham]

On Mon, Apr 15, 2019 at 11:47:39AM +0200, Jan Kara wrote:
> On Sun 14-04-19 16:54:38, Bharath Vedartham wrote:
> > This fixes the -WDecl sparse warning in journal.c. Function was declared
> > as static void but the definition was void.
> > 
> > Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com>
> 
> Thanks! I've added your patch into my tree.
>
Thanks Jan!
> 								Honza
> 
> > ---
> >  fs/reiserfs/journal.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c
> > index 8a76f9d..36346dc 100644
> > --- a/fs/reiserfs/journal.c
> > +++ b/fs/reiserfs/journal.c
> > @@ -1844,7 +1844,7 @@ static int flush_used_journal_lists(struct super_block *s,
> >   * removes any nodes in table with name block and dev as bh.
> >   * only touchs the hnext and hprev pointers.
> >   */
> > -void remove_journal_hash(struct super_block *sb,
> > +static void remove_journal_hash(struct super_block *sb,
> >  			 struct reiserfs_journal_cnode **table,
> >  			 struct reiserfs_journal_list *jl,
> >  			 unsigned long block, int remove_freed)
> > -- 
> > 2.7.4
> > 
> -- 
> Jan Kara <jack@suse.com>
> SUSE Labs, CR