From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Petr Mladek <pmladek@suse.com>,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
Mathias Nyman <mathias.nyman@intel.com>,
Jonathan Corbet <corbet@lwn.net>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
John Stultz <john.stultz@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v1 1/4] lib/vsprintf: Print time64_t in human readable format
Date: Fri, 26 Jul 2019 16:20:37 +0300 [thread overview]
Message-ID: <20190726132037.GX9224@smile.fi.intel.com> (raw)
In-Reply-To: <20190110215858.GG2362@piout.net>
On Thu, Jan 10, 2019 at 10:58:58PM +0100, Alexandre Belloni wrote:
> On 08/01/2019 16:25:28+0100, Petr Mladek wrote:
> > On Fri 2019-01-04 21:30:06, Andy Shevchenko wrote:
> > > There are users which print time and date represented by content of
> > > time64_t type in human readable format.
> > >
> > > Instead of open coding that each time introduce %ptT[dt][r] specifier.
> > >
> > > Few test cases for %ptT specifier has been added as well.
> > > +void time64_to_rtc_time(time64_t time, struct rtc_time *rtc_time)
> > > +{
> > > +#ifdef CONFIG_RTC_LIB
> > > + rtc_time64_to_tm(time, rtc_time);
> > I wonder if the conversion between struct tm and rtc_time
> > might be useful in general.
> >
> > It might make sense to de-duplicate time64_to_tm() and
> > rtc_time64_to_tm() implementations.
> Looking at 57f1f0874f42, this seemed to be the plan at the time
> time_to_tm was introduced but this was never done. Seeing that tm and
> rtc_time are quite similar, we could probably always use time64_to_tm as
> it is more accurate than rtc_time64_to_tm as the latter assumes a
> specific year range.
So, do I understand correctly that dropping #ifdef along with
rtc_time64_to_tm() call is sufficient for now?
> Maybe be rtc_str should take a struct tm instead of an rtc_time so
> time64_to_rtc_time always uses time64_to_tm.
Because this one, while sounding plausible, maybe too invasive on current
state of affairs.
> > > +#else
> > > + struct tm tm;
> > > +
> > > + time64_to_tm(time, 0, &tm);
> > > +
> > > + rtc_time->tm_sec = tm.tm_sec;
> > > + rtc_time->tm_min = tm.tm_min;
> > > + rtc_time->tm_hour = tm.tm_hour;
> > > + rtc_time->tm_mday = tm.tm_mday;
> > > + rtc_time->tm_mon = tm.tm_mon;
> > > + rtc_time->tm_year = tm.tm_year;
> > > + rtc_time->tm_wday = tm.tm_wday;
> > > + rtc_time->tm_yday = tm.tm_yday;
> > > +
> > > + rtc_time->tm_isdst = 0;
> > > +#endif
> > > +}
> > > +
> > > +static noinline_for_stack
> > > +char *time64_str(char *buf, char *end, const time64_t *t, const char *fmt)
> > > +{
> > > + struct rtc_time tm;
> > > +
> > > + time64_to_rtc_time(*t, &tm);
> > > +
> > > + return rtc_str(buf, end, &tm, fmt);
> > > +}
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-07-26 13:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 19:30 [PATCH v1 1/4] lib/vsprintf: Print time64_t in human readable format Andy Shevchenko
2019-01-04 19:30 ` [PATCH v1 2/4] ARM: bcm2835: Switch to use %ptT Andy Shevchenko
2019-01-04 19:30 ` [PATCH v1 3/4] [media] usb: pulse8-cec: " Andy Shevchenko
2019-10-01 11:57 ` Andy Shevchenko
2019-10-01 12:13 ` Hans Verkuil
2019-01-04 19:30 ` [PATCH v1 4/4] usb: host: xhci-tegra: " Andy Shevchenko
2019-10-01 11:56 ` Andy Shevchenko
2019-10-01 12:20 ` Mathias Nyman
2019-10-01 12:35 ` Andy Shevchenko
2019-10-01 13:30 ` Thierry Reding
2019-10-01 14:41 ` Andy Shevchenko
[not found] ` <20190108152528.utr3a5huran52gsf@pathway.suse.cz>
[not found] ` <20190110215858.GG2362@piout.net>
2019-07-26 13:20 ` Andy Shevchenko [this message]
2019-09-30 20:08 ` [PATCH v1 1/4] lib/vsprintf: Print time64_t in human readable format Alexandre Belloni
2019-10-01 11:36 ` Andy Shevchenko
2019-10-01 11:48 ` Alexandre Belloni
2019-10-01 12:11 ` Andy Shevchenko
2019-10-01 12:13 ` Alexandre Belloni
2019-10-01 13:33 ` Andy Shevchenko
2019-10-01 13:50 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190726132037.GX9224@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alexandre.belloni@bootlin.com \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil@xs4all.nl \
--cc=john.stultz@linaro.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=pmladek@suse.com \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).