From: Mathias Nyman <mathias.nyman@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Petr Mladek <pmladek@suse.com>,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>
Subject: Re: [PATCH v1 4/4] usb: host: xhci-tegra: Switch to use %ptT
Date: Tue, 1 Oct 2019 15:20:46 +0300 [thread overview]
Message-ID: <99fa90e8-3188-6781-dcbd-89e29e8509eb@intel.com> (raw)
In-Reply-To: <20191001115640.GJ32742@smile.fi.intel.com>
On 1.10.2019 14.56, Andy Shevchenko wrote:
> On Fri, Jan 04, 2019 at 09:30:09PM +0200, Andy Shevchenko wrote:
>> Use %ptT instead of open coded variant to print content of
>> time64_t type in human readable format.
>
> Any comments on this?
Untested, but looks ok to me.
xhci-tegra.c is written by Thierry Reding, so its more up to him
>
>>
>> Cc: Mathias Nyman <mathias.nyman@intel.com>
>> Cc: Thierry Reding <thierry.reding@gmail.com>
>> Cc: Jonathan Hunter <jonathanh@nvidia.com>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> ---
>> drivers/usb/host/xhci-tegra.c | 6 +-----
>> 1 file changed, 1 insertion(+), 5 deletions(-)
>>
>> diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-tegra.c
>> index 938ff06c0349..ed3eea3876e2 100644
>> --- a/drivers/usb/host/xhci-tegra.c
>> +++ b/drivers/usb/host/xhci-tegra.c
>> @@ -820,7 +820,6 @@ static int tegra_xusb_load_firmware(struct tegra_xusb *tegra)
>> const struct firmware *fw;
>> unsigned long timeout;
>> time64_t timestamp;
>> - struct tm time;
>> u64 address;
>> u32 value;
>> int err;
>> @@ -925,11 +924,8 @@ static int tegra_xusb_load_firmware(struct tegra_xusb *tegra)
>> }
>>
>> timestamp = le32_to_cpu(header->fwimg_created_time);
>> - time64_to_tm(timestamp, 0, &time);
>>
>> - dev_info(dev, "Firmware timestamp: %ld-%02d-%02d %02d:%02d:%02d UTC\n",
>> - time.tm_year + 1900, time.tm_mon + 1, time.tm_mday,
>> - time.tm_hour, time.tm_min, time.tm_sec);
>> + dev_info(dev, "Firmware timestamp: %ptT UTC\n", ×tamp);
>>
>> return 0;
>> }
>> --
>> 2.19.2
>>
>
next prev parent reply other threads:[~2019-10-01 12:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 19:30 [PATCH v1 1/4] lib/vsprintf: Print time64_t in human readable format Andy Shevchenko
2019-01-04 19:30 ` [PATCH v1 2/4] ARM: bcm2835: Switch to use %ptT Andy Shevchenko
2019-01-04 19:30 ` [PATCH v1 3/4] [media] usb: pulse8-cec: " Andy Shevchenko
2019-10-01 11:57 ` Andy Shevchenko
2019-10-01 12:13 ` Hans Verkuil
2019-01-04 19:30 ` [PATCH v1 4/4] usb: host: xhci-tegra: " Andy Shevchenko
2019-10-01 11:56 ` Andy Shevchenko
2019-10-01 12:20 ` Mathias Nyman [this message]
2019-10-01 12:35 ` Andy Shevchenko
2019-10-01 13:30 ` Thierry Reding
2019-10-01 14:41 ` Andy Shevchenko
[not found] ` <20190108152528.utr3a5huran52gsf@pathway.suse.cz>
[not found] ` <20190110215858.GG2362@piout.net>
2019-07-26 13:20 ` [PATCH v1 1/4] lib/vsprintf: Print time64_t in human readable format Andy Shevchenko
2019-09-30 20:08 ` Alexandre Belloni
2019-10-01 11:36 ` Andy Shevchenko
2019-10-01 11:48 ` Alexandre Belloni
2019-10-01 12:11 ` Andy Shevchenko
2019-10-01 12:13 ` Alexandre Belloni
2019-10-01 13:33 ` Andy Shevchenko
2019-10-01 13:50 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99fa90e8-3188-6781-dcbd-89e29e8509eb@intel.com \
--to=mathias.nyman@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).