linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Petr Mladek <pmladek@suse.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Mathias Nyman <mathias.nyman@intel.com>,
	Jonathan Hunter <jonathanh@nvidia.com>
Subject: Re: [PATCH v1 4/4] usb: host: xhci-tegra: Switch to use %ptT
Date: Tue, 1 Oct 2019 17:41:24 +0300	[thread overview]
Message-ID: <CAHp75VdQ1LguHMoqdtCXEV0j4y9qWGpi9Qf5cDc151ip5xSNpw@mail.gmail.com> (raw)
In-Reply-To: <20191001133055.GA3563296@ulmo>

On Tue, Oct 1, 2019 at 4:33 PM Thierry Reding <thierry.reding@gmail.com> wrote:
> On Fri, Jan 04, 2019 at 09:30:09PM +0200, Andy Shevchenko wrote:
> > Use %ptT instead of open coded variant to print content of
> > time64_t type in human readable format.

> > -     dev_info(dev, "Firmware timestamp: %ld-%02d-%02d %02d:%02d:%02d UTC\n",
> > -              time.tm_year + 1900, time.tm_mon + 1, time.tm_mday,
> > -              time.tm_hour, time.tm_min, time.tm_sec);
> > +     dev_info(dev, "Firmware timestamp: %ptT UTC\n", &timestamp);
>
> If I understand correctly, this will now print:
>
>         Firmware timestamp: YYYY-mm-ddTHH:MM:SS UTC
>
> whereas it earlier printed:
>
>         Firmware timestamp: YYYY-mm-dd HH:MM:SS UTC
>
> So the 'T' character is different now.

>  Could we make this something
> along the lines of:
>
>         dev_info(dev, "Firmware timestamp: %ptTd %ptTt UTC\n", &timestamp,
>                  &timestamp);
>
> To keep the output identical?

Yes, we can...

> It's possible that there are some scripts
> that parse the log to find out which firmware was loaded.

...but if you have scripts parsing kernel log, something is odd.
As far as I understand kernel log isn't ABI, no-one should rely on its output.

-- 
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2019-10-01 14:41 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-04 19:30 [PATCH v1 1/4] lib/vsprintf: Print time64_t in human readable format Andy Shevchenko
2019-01-04 19:30 ` [PATCH v1 2/4] ARM: bcm2835: Switch to use %ptT Andy Shevchenko
2019-01-04 19:30 ` [PATCH v1 3/4] [media] usb: pulse8-cec: " Andy Shevchenko
2019-10-01 11:57   ` Andy Shevchenko
2019-10-01 12:13     ` Hans Verkuil
2019-01-04 19:30 ` [PATCH v1 4/4] usb: host: xhci-tegra: " Andy Shevchenko
2019-10-01 11:56   ` Andy Shevchenko
2019-10-01 12:20     ` Mathias Nyman
2019-10-01 12:35       ` Andy Shevchenko
2019-10-01 13:30   ` Thierry Reding
2019-10-01 14:41     ` Andy Shevchenko [this message]
     [not found] ` <20190108152528.utr3a5huran52gsf@pathway.suse.cz>
     [not found]   ` <20190110215858.GG2362@piout.net>
2019-07-26 13:20     ` [PATCH v1 1/4] lib/vsprintf: Print time64_t in human readable format Andy Shevchenko
2019-09-30 20:08       ` Alexandre Belloni
2019-10-01 11:36         ` Andy Shevchenko
2019-10-01 11:48           ` Alexandre Belloni
2019-10-01 12:11             ` Andy Shevchenko
2019-10-01 12:13               ` Alexandre Belloni
2019-10-01 13:33                 ` Andy Shevchenko
2019-10-01 13:50                   ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHp75VdQ1LguHMoqdtCXEV0j4y9qWGpi9Qf5cDc151ip5xSNpw@mail.gmail.com \
    --to=andy.shevchenko@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=pmladek@suse.com \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).