From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Petr Mladek <pmladek@suse.com>,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Hans Verkuil <hverkuil@xs4all.nl>
Subject: Re: [PATCH v1 3/4] [media] usb: pulse8-cec: Switch to use %ptT
Date: Tue, 1 Oct 2019 14:57:05 +0300 [thread overview]
Message-ID: <20191001115705.GK32742@smile.fi.intel.com> (raw)
In-Reply-To: <20190104193009.30907-3-andriy.shevchenko@linux.intel.com>
On Fri, Jan 04, 2019 at 09:30:08PM +0200, Andy Shevchenko wrote:
> Use %ptT instead of open coded variant to print content of
> time64_t type in human readable format.
Hans, any objections on this?
> Cc: Hans Verkuil <hverkuil@xs4all.nl>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/media/usb/pulse8-cec/pulse8-cec.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/media/usb/pulse8-cec/pulse8-cec.c b/drivers/media/usb/pulse8-cec/pulse8-cec.c
> index b085b14f3f87..05f997e9ce28 100644
> --- a/drivers/media/usb/pulse8-cec/pulse8-cec.c
> +++ b/drivers/media/usb/pulse8-cec/pulse8-cec.c
> @@ -328,7 +328,6 @@ static int pulse8_setup(struct pulse8 *pulse8, struct serio *serio,
> u8 *data = pulse8->data + 1;
> u8 cmd[2];
> int err;
> - struct tm tm;
> time64_t date;
>
> pulse8->vers = 0;
> @@ -349,10 +348,7 @@ static int pulse8_setup(struct pulse8 *pulse8, struct serio *serio,
> if (err)
> return err;
> date = (data[0] << 24) | (data[1] << 16) | (data[2] << 8) | data[3];
> - time64_to_tm(date, 0, &tm);
> - dev_info(pulse8->dev, "Firmware build date %04ld.%02d.%02d %02d:%02d:%02d\n",
> - tm.tm_year + 1900, tm.tm_mon + 1, tm.tm_mday,
> - tm.tm_hour, tm.tm_min, tm.tm_sec);
> + dev_info(pulse8->dev, "Firmware build date %ptT\n", &date);
>
> dev_dbg(pulse8->dev, "Persistent config:\n");
> cmd[0] = MSGCODE_GET_AUTO_ENABLED;
> --
> 2.19.2
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-10-01 11:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 19:30 [PATCH v1 1/4] lib/vsprintf: Print time64_t in human readable format Andy Shevchenko
2019-01-04 19:30 ` [PATCH v1 2/4] ARM: bcm2835: Switch to use %ptT Andy Shevchenko
2019-01-04 19:30 ` [PATCH v1 3/4] [media] usb: pulse8-cec: " Andy Shevchenko
2019-10-01 11:57 ` Andy Shevchenko [this message]
2019-10-01 12:13 ` Hans Verkuil
2019-01-04 19:30 ` [PATCH v1 4/4] usb: host: xhci-tegra: " Andy Shevchenko
2019-10-01 11:56 ` Andy Shevchenko
2019-10-01 12:20 ` Mathias Nyman
2019-10-01 12:35 ` Andy Shevchenko
2019-10-01 13:30 ` Thierry Reding
2019-10-01 14:41 ` Andy Shevchenko
[not found] ` <20190108152528.utr3a5huran52gsf@pathway.suse.cz>
[not found] ` <20190110215858.GG2362@piout.net>
2019-07-26 13:20 ` [PATCH v1 1/4] lib/vsprintf: Print time64_t in human readable format Andy Shevchenko
2019-09-30 20:08 ` Alexandre Belloni
2019-10-01 11:36 ` Andy Shevchenko
2019-10-01 11:48 ` Alexandre Belloni
2019-10-01 12:11 ` Andy Shevchenko
2019-10-01 12:13 ` Alexandre Belloni
2019-10-01 13:33 ` Andy Shevchenko
2019-10-01 13:50 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001115705.GK32742@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).