From: Christoph Hellwig <hch@lst.de>
To: isaacm@codeaurora.org
Cc: Christoph Hellwig <hch@lst.de>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
joro@8bytes.org, m.szyprowski@samsung.com, robin.murphy@arm.com,
will@kernel.org, pratikp@codeaurora.org, lmark@codeaurora.org
Subject: Re: [PATCH] iommu/dma: Add support for DMA_ATTR_SYS_CACHE
Date: Mon, 28 Oct 2019 08:41:56 +0100 [thread overview]
Message-ID: <20191028074156.GB20443@lst.de> (raw)
In-Reply-To: <e5fe861d7d506eb41c23f3fc047efdfa@codeaurora.org>
On Sat, Oct 26, 2019 at 03:12:57AM -0700, isaacm@codeaurora.org wrote:
> On 2019-10-25 22:30, Christoph Hellwig wrote:
>> The definition makes very little sense.
> Can you please clarify what part doesn’t make sense, and why?
It looks like complete garbage to me. That might just be because it
uses tons of terms I've never heard of of and which aren't used anywhere
in the DMA API. It also might be because it doesn't explain how the
flag might actually be practically useful.
> This is
> really just an extension of this patch that got mainlined, so that clients
> that use the DMA API can use IOMMU_QCOM_SYS_CACHE as well:
> https://patchwork.kernel.org/patch/10946099/
>> Any without a user in the same series it is a complete no-go anyway.
> IOMMU_QCOM_SYS_CACHE does not have any current users in the mainline, nor
> did it have it in the patch series in which it got merged, yet it is still
> present? Furthermore, there are plans to upstream support for one of our
> SoCs that may benefit from this, as seen here:
> https://www.spinics.net/lists/iommu/msg39608.html.
Which means it should have never been merged. As a general policy we do
not add code to the Linux kernel without actual users.
next prev parent reply other threads:[~2019-10-28 7:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-26 0:43 [PATCH] iommu/dma: Add support for DMA_ATTR_SYS_CACHE Isaac J. Manjarres
2019-10-26 5:30 ` Christoph Hellwig
2019-10-26 10:12 ` isaacm
2019-10-28 7:41 ` Christoph Hellwig [this message]
2019-10-28 11:24 ` Will Deacon
2019-10-28 11:37 ` Christoph Hellwig
2019-10-28 15:44 ` Will Deacon
2019-10-28 11:59 ` Robin Murphy
2019-10-28 15:34 ` Jordan Crouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191028074156.GB20443@lst.de \
--to=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=isaacm@codeaurora.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lmark@codeaurora.org \
--cc=m.szyprowski@samsung.com \
--cc=pratikp@codeaurora.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).