[PATCH v2] hdlcdrv: replace unnecessary assertion in hdlcdrv_register

[PATCH v2] hdlcdrv: replace unnecessary assertion in hdlcdrv_register

[Aditya Pakki]

In hdlcdrv_register, failure to register the driver causes a crash.
The three callers of hdlcdrv_register all pass valid pointers and
do not fail. The patch eliminates the unnecessary BUG_ON assertion.

Signed-off-by: Aditya Pakki <pakki001@umn.edu>
---
v1: Changed from returning -EINVAL to deleting BUG_ON as identified
by Stephen Hemminger.
---
 drivers/net/hamradio/hdlcdrv.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/hamradio/hdlcdrv.c b/drivers/net/hamradio/hdlcdrv.c
index df495b5595f5..e7413a643929 100644
--- a/drivers/net/hamradio/hdlcdrv.c
+++ b/drivers/net/hamradio/hdlcdrv.c
@@ -687,8 +687,6 @@ struct net_device *hdlcdrv_register(const struct hdlcdrv_ops *ops,
 	struct hdlcdrv_state *s;
 	int err;
 
-	BUG_ON(ops == NULL);
-
 	if (privsize < sizeof(struct hdlcdrv_state))
 		privsize = sizeof(struct hdlcdrv_state);
 
-- 
2.20.1

Re: [PATCH v2] hdlcdrv: replace unnecessary assertion in hdlcdrv_register

[Markus Elfring]

> The three callers of hdlcdrv_register all pass valid pointers and
> do not fail. The patch eliminates the unnecessary BUG_ON assertion.

I suggest to replace the wording “The patch eliminates” by “Thus delete”
to make it imperative as desired.

Will the tag “Fixes” be added to the final change description?


> ---
>  drivers/net/hamradio/hdlcdrv.c | 2 --

Please replace these triple dashes by a blank line.

Regards,
Markus

Re: [PATCH v2] hdlcdrv: replace unnecessary assertion in hdlcdrv_register

[David Miller]

From: Aditya Pakki <pakki001@umn.edu>
Date: Tue, 17 Dec 2019 15:06:19 -0600

> In hdlcdrv_register, failure to register the driver causes a crash.
> The three callers of hdlcdrv_register all pass valid pointers and
> do not fail. The patch eliminates the unnecessary BUG_ON assertion.
> 
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>

Applied to net-next.