linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: mathias.nyman@intel.com, stern@rowland.harvard.edu,
	acelan.kao@canonical.com, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] USB: Disable LPM on WD19's Realtek Hub
Date: Sat, 11 Jan 2020 20:23:53 +0100	[thread overview]
Message-ID: <20200111192353.GA435222@kroah.com> (raw)
In-Reply-To: <20200110080211.22626-1-kai.heng.feng@canonical.com>

On Fri, Jan 10, 2020 at 04:02:11PM +0800, Kai-Heng Feng wrote:
> Realtek Hub (0bda:0x0487) used in Dell Dock WD19 sometimes drops off the
> bus when bringing underlying ports from U3 to U0.
> 
> Disabling LPM on the hub during setting link state is not enough, so
> let's disable LPM completely for this hub.
> 
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
>  drivers/usb/core/quirks.c | 3 +++
>  1 file changed, 3 insertions(+)

What changed from v1?  Always put that below the --- line.

Also I only see 1 patch here, what happened to the first two?

Please resend the whole series, and properly document what went on, you
know this...

thanks,

greg k-h

  parent reply	other threads:[~2020-01-11 20:01 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-03  8:40 [PATCH 1/3] xhci: Ensure link state is U3 after setting USB_SS_PORT_LS_U3 Kai-Heng Feng
2020-01-03  8:40 ` [PATCH 2/3] xhci: Wait until link state trainsits to U0 after setting USB_SS_PORT_LS_U0 Kai-Heng Feng
2020-01-10 15:29   ` Mathias Nyman
2020-01-13  9:18     ` Kai-Heng Feng
2020-01-14 14:48       ` Mathias Nyman
2020-01-03  8:40 ` [PATCH 3/3] USB: Disable LPM on WD19's Realtek Hub during setting its ports to U0 Kai-Heng Feng
2020-01-03 15:21   ` Alan Stern
2020-01-03 16:25     ` Kai-Heng Feng
2020-01-03 16:54       ` Alan Stern
2020-01-04  6:41         ` Kai-Heng Feng
2020-01-04 16:20           ` Alan Stern
2020-01-06  6:19             ` Kai-Heng Feng
2020-01-06 15:08               ` Alan Stern
2020-01-10  7:35                 ` Kai-Heng Feng
2020-01-10  8:02   ` [PATCH v2 3/3] USB: Disable LPM on WD19's Realtek Hub Kai-Heng Feng
2020-01-10 15:40     ` Alan Stern
2020-01-10 15:51       ` Kai-Heng Feng
2020-01-10 16:36         ` Alan Stern
2020-01-10 16:46           ` Kai-Heng Feng
2020-01-11 19:23     ` Greg KH [this message]
2020-01-13  9:06       ` Kai-Heng Feng
2020-01-10  9:34 ` [PATCH 1/3] xhci: Ensure link state is U3 after setting USB_SS_PORT_LS_U3 Mathias Nyman
2020-01-13  9:10   ` Kai-Heng Feng
2020-01-14 15:07     ` Mathias Nyman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200111192353.GA435222@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=acelan.kao@canonical.com \
    --cc=kai.heng.feng@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).