From: Kai-Heng Feng <kai.heng.feng@canonical.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
Alan Stern <stern@rowland.harvard.edu>,
AceLan Kao <acelan.kao@canonical.com>,
USB list <linux-usb@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] USB: Disable LPM on WD19's Realtek Hub
Date: Mon, 13 Jan 2020 17:06:53 +0800 [thread overview]
Message-ID: <CAAd53p6vGpv0L+XFa1raA2HzO+3LYvHwPW968CEuW8aDbNC7BQ@mail.gmail.com> (raw)
In-Reply-To: <20200111192353.GA435222@kroah.com>
On Sun, Jan 12, 2020 at 4:01 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Fri, Jan 10, 2020 at 04:02:11PM +0800, Kai-Heng Feng wrote:
> > Realtek Hub (0bda:0x0487) used in Dell Dock WD19 sometimes drops off the
> > bus when bringing underlying ports from U3 to U0.
> >
> > Disabling LPM on the hub during setting link state is not enough, so
> > let's disable LPM completely for this hub.
> >
> > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> > ---
> > drivers/usb/core/quirks.c | 3 +++
> > 1 file changed, 3 insertions(+)
>
> What changed from v1? Always put that below the --- line.
>
> Also I only see 1 patch here, what happened to the first two?
The first two are can be actually treat separately, since they are
more generic fixes for xHCI.
>
> Please resend the whole series, and properly document what went on, you
> know this...
I forgot that, will do in next version.
Kai-Heng
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2020-01-13 9:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-03 8:40 [PATCH 1/3] xhci: Ensure link state is U3 after setting USB_SS_PORT_LS_U3 Kai-Heng Feng
2020-01-03 8:40 ` [PATCH 2/3] xhci: Wait until link state trainsits to U0 after setting USB_SS_PORT_LS_U0 Kai-Heng Feng
2020-01-10 15:29 ` Mathias Nyman
2020-01-13 9:18 ` Kai-Heng Feng
2020-01-14 14:48 ` Mathias Nyman
2020-01-03 8:40 ` [PATCH 3/3] USB: Disable LPM on WD19's Realtek Hub during setting its ports to U0 Kai-Heng Feng
2020-01-03 15:21 ` Alan Stern
2020-01-03 16:25 ` Kai-Heng Feng
2020-01-03 16:54 ` Alan Stern
2020-01-04 6:41 ` Kai-Heng Feng
2020-01-04 16:20 ` Alan Stern
2020-01-06 6:19 ` Kai-Heng Feng
2020-01-06 15:08 ` Alan Stern
2020-01-10 7:35 ` Kai-Heng Feng
2020-01-10 8:02 ` [PATCH v2 3/3] USB: Disable LPM on WD19's Realtek Hub Kai-Heng Feng
2020-01-10 15:40 ` Alan Stern
2020-01-10 15:51 ` Kai-Heng Feng
2020-01-10 16:36 ` Alan Stern
2020-01-10 16:46 ` Kai-Heng Feng
2020-01-11 19:23 ` Greg KH
2020-01-13 9:06 ` Kai-Heng Feng [this message]
2020-01-10 9:34 ` [PATCH 1/3] xhci: Ensure link state is U3 after setting USB_SS_PORT_LS_U3 Mathias Nyman
2020-01-13 9:10 ` Kai-Heng Feng
2020-01-14 15:07 ` Mathias Nyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAd53p6vGpv0L+XFa1raA2HzO+3LYvHwPW968CEuW8aDbNC7BQ@mail.gmail.com \
--to=kai.heng.feng@canonical.com \
--cc=acelan.kao@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).