* [PATCH v2] arm64: dts: rockchip: fix px30 lvds ports
@ 2020-01-21 22:20 Heiko Stuebner
2020-01-21 22:20 ` [PATCH] " Heiko Stuebner
2020-03-01 12:08 ` [PATCH v2] " Heiko Stuebner
0 siblings, 2 replies; 7+ messages in thread
From: Heiko Stuebner @ 2020-01-21 22:20 UTC (permalink / raw)
To: linux-rockchip
Cc: linux-arm-kernel, linux-kernel, miquel.raynal,
christoph.muellner, heiko, Heiko Stuebner
From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
The lvds controller has two ports. port@0 for the connection
to the display controller(s) and port@1 for the connection to
the panel, so should have a ports node covering the port@x nodes.
Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
changes in v2:
- added review from Miquel
- removed global #address+size-cells from lvds as suggested by Robin Murphy
arch/arm64/boot/dts/rockchip/px30.dtsi | 25 ++++++++++++++-----------
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi
index 9b1c92132007..82bf39a8dbcc 100644
--- a/arch/arm64/boot/dts/rockchip/px30.dtsi
+++ b/arch/arm64/boot/dts/rockchip/px30.dtsi
@@ -413,27 +413,30 @@ io_domains: io-domains {
lvds: lvds {
compatible = "rockchip,px30-lvds";
- #address-cells = <1>;
- #size-cells = <0>;
phys = <&dsi_dphy>;
phy-names = "dphy";
rockchip,grf = <&grf>;
rockchip,output = "lvds";
status = "disabled";
- port@0 {
- reg = <0>;
+ ports {
#address-cells = <1>;
#size-cells = <0>;
- lvds_vopb_in: endpoint@0 {
+ port@0 {
reg = <0>;
- remote-endpoint = <&vopb_out_lvds>;
- };
-
- lvds_vopl_in: endpoint@1 {
- reg = <1>;
- remote-endpoint = <&vopl_out_lvds>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ lvds_vopb_in: endpoint@0 {
+ reg = <0>;
+ remote-endpoint = <&vopb_out_lvds>;
+ };
+
+ lvds_vopl_in: endpoint@1 {
+ reg = <1>;
+ remote-endpoint = <&vopl_out_lvds>;
+ };
};
};
};
--
2.24.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH] arm64: dts: rockchip: fix px30 lvds ports
2020-01-21 22:20 [PATCH v2] arm64: dts: rockchip: fix px30 lvds ports Heiko Stuebner
@ 2020-01-21 22:20 ` Heiko Stuebner
2020-01-21 22:23 ` Heiko Stuebner
2020-03-01 12:08 ` [PATCH v2] " Heiko Stuebner
1 sibling, 1 reply; 7+ messages in thread
From: Heiko Stuebner @ 2020-01-21 22:20 UTC (permalink / raw)
To: linux-rockchip
Cc: linux-arm-kernel, linux-kernel, miquel.raynal,
christoph.muellner, heiko, Heiko Stuebner
From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
The lvds controller has two ports. port@0 for the connection
to the display controller(s) and port@1 for the connection to
the panel, so should have a ports node covering the port@x nodes.
Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
---
arch/arm64/boot/dts/rockchip/px30.dtsi | 23 ++++++++++++++---------
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi
index 9b1c92132007..37e014444214 100644
--- a/arch/arm64/boot/dts/rockchip/px30.dtsi
+++ b/arch/arm64/boot/dts/rockchip/px30.dtsi
@@ -421,19 +421,24 @@ lvds: lvds {
rockchip,output = "lvds";
status = "disabled";
- port@0 {
- reg = <0>;
+ ports {
#address-cells = <1>;
#size-cells = <0>;
- lvds_vopb_in: endpoint@0 {
+ port@0 {
reg = <0>;
- remote-endpoint = <&vopb_out_lvds>;
- };
-
- lvds_vopl_in: endpoint@1 {
- reg = <1>;
- remote-endpoint = <&vopl_out_lvds>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ lvds_vopb_in: endpoint@0 {
+ reg = <0>;
+ remote-endpoint = <&vopb_out_lvds>;
+ };
+
+ lvds_vopl_in: endpoint@1 {
+ reg = <1>;
+ remote-endpoint = <&vopl_out_lvds>;
+ };
};
};
};
--
2.24.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] arm64: dts: rockchip: fix px30 lvds ports
2020-01-21 22:20 ` [PATCH] " Heiko Stuebner
@ 2020-01-21 22:23 ` Heiko Stuebner
0 siblings, 0 replies; 7+ messages in thread
From: Heiko Stuebner @ 2020-01-21 22:23 UTC (permalink / raw)
To: linux-rockchip
Cc: linux-arm-kernel, linux-kernel, miquel.raynal, christoph.muellner
Am Dienstag, 21. Januar 2020, 23:20:55 CET schrieb Heiko Stuebner:
> From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
>
> The lvds controller has two ports. port@0 for the connection
> to the display controller(s) and port@1 for the connection to
> the panel, so should have a ports node covering the port@x nodes.
>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
ignore this second one please :-)
Something went wrong when sending.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] arm64: dts: rockchip: fix px30 lvds ports
2020-01-21 22:20 [PATCH v2] arm64: dts: rockchip: fix px30 lvds ports Heiko Stuebner
2020-01-21 22:20 ` [PATCH] " Heiko Stuebner
@ 2020-03-01 12:08 ` Heiko Stuebner
1 sibling, 0 replies; 7+ messages in thread
From: Heiko Stuebner @ 2020-03-01 12:08 UTC (permalink / raw)
To: linux-rockchip
Cc: linux-arm-kernel, linux-kernel, miquel.raynal, christoph.muellner
Am Dienstag, 21. Januar 2020, 23:20:54 CET schrieb Heiko Stuebner:
> From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
>
> The lvds controller has two ports. port@0 for the connection
> to the display controller(s) and port@1 for the connection to
> the panel, so should have a ports node covering the port@x nodes.
>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
applied for 5.7
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] arm64: dts: rockchip: fix px30 lvds ports
@ 2020-01-21 13:45 Heiko Stuebner
2020-01-21 13:59 ` Miquel Raynal
2020-01-21 14:56 ` Robin Murphy
0 siblings, 2 replies; 7+ messages in thread
From: Heiko Stuebner @ 2020-01-21 13:45 UTC (permalink / raw)
To: linux-rockchip
Cc: linux-arm-kernel, linux-kernel, miquel.raynal,
christoph.muellner, heiko, Heiko Stuebner
From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
The lvds controller has two ports. port@0 for the connection
to the display controller(s) and port@1 for the connection to
the panel, so should have a ports node covering the port@x nodes.
Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
---
arch/arm64/boot/dts/rockchip/px30.dtsi | 23 ++++++++++++++---------
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi
index 9b1c92132007..37e014444214 100644
--- a/arch/arm64/boot/dts/rockchip/px30.dtsi
+++ b/arch/arm64/boot/dts/rockchip/px30.dtsi
@@ -421,19 +421,24 @@ lvds: lvds {
rockchip,output = "lvds";
status = "disabled";
- port@0 {
- reg = <0>;
+ ports {
#address-cells = <1>;
#size-cells = <0>;
- lvds_vopb_in: endpoint@0 {
+ port@0 {
reg = <0>;
- remote-endpoint = <&vopb_out_lvds>;
- };
-
- lvds_vopl_in: endpoint@1 {
- reg = <1>;
- remote-endpoint = <&vopl_out_lvds>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ lvds_vopb_in: endpoint@0 {
+ reg = <0>;
+ remote-endpoint = <&vopb_out_lvds>;
+ };
+
+ lvds_vopl_in: endpoint@1 {
+ reg = <1>;
+ remote-endpoint = <&vopl_out_lvds>;
+ };
};
};
};
--
2.24.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] arm64: dts: rockchip: fix px30 lvds ports
2020-01-21 13:45 [PATCH] " Heiko Stuebner
@ 2020-01-21 13:59 ` Miquel Raynal
2020-01-21 14:56 ` Robin Murphy
1 sibling, 0 replies; 7+ messages in thread
From: Miquel Raynal @ 2020-01-21 13:59 UTC (permalink / raw)
To: Heiko Stuebner
Cc: linux-rockchip, linux-arm-kernel, linux-kernel,
christoph.muellner, Heiko Stuebner
Hi Heiko,
Heiko Stuebner <heiko@sntech.de> wrote on Tue, 21 Jan 2020 14:45:10
+0100:
> From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
>
> The lvds controller has two ports. port@0 for the connection
> to the display controller(s) and port@1 for the connection to
> the panel, so should have a ports node covering the port@x nodes.
>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> ---
> arch/arm64/boot/dts/rockchip/px30.dtsi | 23 ++++++++++++++---------
> 1 file changed, 14 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi
> index 9b1c92132007..37e014444214 100644
> --- a/arch/arm64/boot/dts/rockchip/px30.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/px30.dtsi
> @@ -421,19 +421,24 @@ lvds: lvds {
> rockchip,output = "lvds";
> status = "disabled";
>
> - port@0 {
> - reg = <0>;
> + ports {
> #address-cells = <1>;
> #size-cells = <0>;
>
> - lvds_vopb_in: endpoint@0 {
> + port@0 {
> reg = <0>;
> - remote-endpoint = <&vopb_out_lvds>;
> - };
> -
> - lvds_vopl_in: endpoint@1 {
> - reg = <1>;
> - remote-endpoint = <&vopl_out_lvds>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + lvds_vopb_in: endpoint@0 {
> + reg = <0>;
> + remote-endpoint = <&vopb_out_lvds>;
> + };
> +
> + lvds_vopl_in: endpoint@1 {
> + reg = <1>;
> + remote-endpoint = <&vopl_out_lvds>;
> + };
> };
> };
> };
I don't know the exact rule but this seems cleaner indeed.
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] arm64: dts: rockchip: fix px30 lvds ports
2020-01-21 13:45 [PATCH] " Heiko Stuebner
2020-01-21 13:59 ` Miquel Raynal
@ 2020-01-21 14:56 ` Robin Murphy
1 sibling, 0 replies; 7+ messages in thread
From: Robin Murphy @ 2020-01-21 14:56 UTC (permalink / raw)
To: Heiko Stuebner, linux-rockchip
Cc: Heiko Stuebner, linux-kernel, miquel.raynal, linux-arm-kernel,
christoph.muellner
On 21/01/2020 1:45 pm, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
>
> The lvds controller has two ports. port@0 for the connection
> to the display controller(s) and port@1 for the connection to
> the panel, so should have a ports node covering the port@x nodes.
>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> ---
> arch/arm64/boot/dts/rockchip/px30.dtsi | 23 ++++++++++++++---------
> 1 file changed, 14 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi
> index 9b1c92132007..37e014444214 100644
> --- a/arch/arm64/boot/dts/rockchip/px30.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/px30.dtsi
> @@ -421,19 +421,24 @@ lvds: lvds {
> rockchip,output = "lvds";
> status = "disabled";
FWIW, the main node's "#{address,size}-cells" properties above here
should now be unnecessary too.
Robin.
>
> - port@0 {
> - reg = <0>;
> + ports {
> #address-cells = <1>;
> #size-cells = <0>;
>
> - lvds_vopb_in: endpoint@0 {
> + port@0 {
> reg = <0>;
> - remote-endpoint = <&vopb_out_lvds>;
> - };
> -
> - lvds_vopl_in: endpoint@1 {
> - reg = <1>;
> - remote-endpoint = <&vopl_out_lvds>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + lvds_vopb_in: endpoint@0 {
> + reg = <0>;
> + remote-endpoint = <&vopb_out_lvds>;
> + };
> +
> + lvds_vopl_in: endpoint@1 {
> + reg = <1>;
> + remote-endpoint = <&vopl_out_lvds>;
> + };
> };
> };
> };
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-03-01 12:08 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-21 22:20 [PATCH v2] arm64: dts: rockchip: fix px30 lvds ports Heiko Stuebner
2020-01-21 22:20 ` [PATCH] " Heiko Stuebner
2020-01-21 22:23 ` Heiko Stuebner
2020-03-01 12:08 ` [PATCH v2] " Heiko Stuebner
-- strict thread matches above, loose matches on Subject: below --
2020-01-21 13:45 [PATCH] " Heiko Stuebner
2020-01-21 13:59 ` Miquel Raynal
2020-01-21 14:56 ` Robin Murphy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).