From: "Paul E. McKenney" <paulmck@kernel.org>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Joel Fernandes <joel@joelfernandes.org>,
Josh Triplett <josh@joshtriplett.org>
Subject: Re: [PATCH 04/10] rcu: Implement rcu_segcblist_is_offloaded() config dependent
Date: Thu, 14 May 2020 08:47:54 -0700 [thread overview]
Message-ID: <20200514154754.GM2869@paulmck-ThinkPad-P72> (raw)
In-Reply-To: <20200513230330.GB18303@lenoir>
On Thu, May 14, 2020 at 01:03:31AM +0200, Frederic Weisbecker wrote:
> On Wed, May 13, 2020 at 11:20:29AM -0700, Paul E. McKenney wrote:
> > On Wed, May 13, 2020 at 06:47:08PM +0200, Frederic Weisbecker wrote:
> > > This simplify the usage of this API and avoid checking the kernel
> > > config from the callers.
> > >
> > > Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
> > > Cc: Paul E. McKenney <paulmck@kernel.org>
> > > Cc: Josh Triplett <josh@joshtriplett.org>
> > > Cc: Steven Rostedt <rostedt@goodmis.org>
> > > Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> > > Cc: Lai Jiangshan <jiangshanlai@gmail.com>
> > > Cc: Joel Fernandes <joel@joelfernandes.org>
> > > ---
> > > include/linux/rcu_segcblist.h | 2 ++
> > > kernel/rcu/rcu_segcblist.c | 2 ++
> > > kernel/rcu/rcu_segcblist.h | 6 ++++++
> > > kernel/rcu/tree.c | 21 +++++++--------------
> > > 4 files changed, 17 insertions(+), 14 deletions(-)
> > >
> > > diff --git a/include/linux/rcu_segcblist.h b/include/linux/rcu_segcblist.h
> > > index b36afe7b22c9..0ced0a0ecbcf 100644
> > > --- a/include/linux/rcu_segcblist.h
> > > +++ b/include/linux/rcu_segcblist.h
> > > @@ -73,7 +73,9 @@ struct rcu_segcblist {
> > > long len;
> > > #endif
> > > u8 enabled;
> > > +#ifdef CONFIG_RCU_NOCB_CPU
> > > u8 offloaded;
> > > +#endif
> >
> > Given that this is only one byte and that removing it won't actually
> > save any memory on most architectures, why not just leave it and
> > adjust as shown below?
>
> Right, the point was to make it private to that config and trigger
> a build error otherwise. But if we have an off case that's fine.
>
> >
> > > };
> > >
> > > #define RCU_SEGCBLIST_INITIALIZER(n) \
> > > diff --git a/kernel/rcu/rcu_segcblist.c b/kernel/rcu/rcu_segcblist.c
> > > index 9a0f66133b4b..d8ea2bef5574 100644
> > > --- a/kernel/rcu/rcu_segcblist.c
> > > +++ b/kernel/rcu/rcu_segcblist.c
> > > @@ -166,6 +166,7 @@ void rcu_segcblist_disable(struct rcu_segcblist *rsclp)
> > > rsclp->enabled = 0;
> > > }
> > >
> > > +#ifdef CONFIG_RCU_NOCB_CPU
> > > /*
> > > * Mark the specified rcu_segcblist structure as offloaded. This
> > > * structure must be empty.
> > > @@ -174,6 +175,7 @@ void rcu_segcblist_offload(struct rcu_segcblist *rsclp)
> > > {
> > > rsclp->offloaded = 1;
> > > }
> > > +#endif
> >
> > Leave this unconditional, as it is nowhere near a fastpath.
>
> The point was to not raise false hopes to those who want to
> offload when it's not supported.
>
> Let's perhaps have at least a WARN_ON_ONCE(1) if it is called
> when !CONFIG_RCU_NOCB_CPU ?
Sounds like a good choice to me!
> > > /*
> > > * Does the specified rcu_segcblist structure contain callbacks that
> > > diff --git a/kernel/rcu/rcu_segcblist.h b/kernel/rcu/rcu_segcblist.h
> > > index 5c293afc07b8..4c1503a82492 100644
> > > --- a/kernel/rcu/rcu_segcblist.h
> > > +++ b/kernel/rcu/rcu_segcblist.h
> > > @@ -62,7 +62,11 @@ static inline bool rcu_segcblist_is_enabled(struct rcu_segcblist *rsclp)
> > > /* Is the specified rcu_segcblist offloaded? */
> > > static inline bool rcu_segcblist_is_offloaded(struct rcu_segcblist *rsclp)
> > > {
> > > +#ifdef CONFIG_RCU_NOCB_CPU
> > > return rsclp->offloaded;
> > > +#else
> > > + return false;
> > > +#endif
> > > }
> >
> > Then this can just be:
> >
> > return IS_ENABLED(CONFIG_RCU_NOCB_CPU) && rsclp->offloaded;
>
> Ok.
>
> > > @@ -1401,8 +1401,7 @@ static bool __note_gp_changes(struct rcu_node *rnp, struct rcu_data *rdp)
> > > {
> > > bool ret = false;
> > > bool need_qs;
> > > - const bool offloaded = IS_ENABLED(CONFIG_RCU_NOCB_CPU) &&
> > > - rcu_segcblist_is_offloaded(&rdp->cblist);
> > > + const bool offloaded = rcu_segcblist_is_offloaded(&rdp->cblist);
> >
> > The adjustment to rcu_segcblist_is_offloaded() allows this (welcome!)
> > simplification to remain.
>
> Ok thanks!
>
> > > @@ -3243,8 +3237,7 @@ static int rcu_pending(int user)
> > >
> > > /* Has RCU gone idle with this CPU needing another grace period? */
> > > if (!gp_in_progress && rcu_segcblist_is_enabled(&rdp->cblist) &&
> > > - (!IS_ENABLED(CONFIG_RCU_NOCB_CPU) ||
> > > - !rcu_segcblist_is_offloaded(&rdp->cblist)) &&
> > > + !rcu_segcblist_is_offloaded(&rdp->cblist) &&
> >
> > Ditto.
> >
> > As in "Why didn't I do it that way to start with???" ;-)
>
> You say that to someone who's too lazy to script short commands typed
> 100 times a day ;-)
;-) ;-) ;-)
Thanx, Paul
next prev parent reply other threads:[~2020-05-14 15:47 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 16:47 [PATCH 00/10] rcu: Allow a CPU to leave and reenter NOCB state Frederic Weisbecker
2020-05-13 16:47 ` [PATCH 01/10] rcu: Directly lock rdp->nocb_lock on nocb code entrypoints Frederic Weisbecker
2020-05-20 12:29 ` Joel Fernandes
2020-05-22 17:57 ` Paul E. McKenney
2020-05-26 15:21 ` Joel Fernandes
2020-05-26 16:29 ` Paul E. McKenney
2020-05-26 20:18 ` Joel Fernandes
2020-05-26 21:09 ` Paul E. McKenney
2020-05-26 21:27 ` Joel Fernandes
2020-05-26 22:29 ` Paul E. McKenney
2020-05-27 0:45 ` Joel Fernandes
2020-05-27 0:58 ` Paul E. McKenney
2020-06-04 11:41 ` Frederic Weisbecker
2020-06-04 16:36 ` Paul E. McKenney
2020-06-08 12:57 ` Frederic Weisbecker
2020-06-09 18:02 ` Paul E. McKenney
2020-06-10 13:12 ` Frederic Weisbecker
2020-06-10 14:02 ` Paul E. McKenney
2020-06-10 22:12 ` Frederic Weisbecker
2020-06-10 23:21 ` Paul E. McKenney
2020-06-11 1:32 ` Joel Fernandes
2020-05-13 16:47 ` [PATCH 02/10] rcu: Use direct rdp->nocb_lock operations on local calls Frederic Weisbecker
2020-05-13 16:47 ` [PATCH 03/10] rcu: Make locking explicit in do_nocb_deferred_wakeup_common() Frederic Weisbecker
2020-05-26 19:54 ` Joel Fernandes
2020-05-26 19:59 ` Joel Fernandes
2020-05-13 16:47 ` [PATCH 04/10] rcu: Implement rcu_segcblist_is_offloaded() config dependent Frederic Weisbecker
2020-05-13 18:20 ` Paul E. McKenney
2020-05-13 23:03 ` Frederic Weisbecker
2020-05-14 15:47 ` Paul E. McKenney [this message]
2020-05-13 16:47 ` [PATCH 05/10] rcu: Remove useless conditional nocb unlock Frederic Weisbecker
2020-05-13 16:47 ` [PATCH 06/10] rcu: Make nocb_cb kthread parkable Frederic Weisbecker
2020-06-11 1:34 ` Joel Fernandes
2020-05-13 16:47 ` [PATCH 07/10] rcu: Temporarily assume that nohz full CPUs might not be NOCB Frederic Weisbecker
2020-05-13 18:25 ` Paul E. McKenney
2020-05-13 23:08 ` Frederic Weisbecker
2020-05-14 15:50 ` Paul E. McKenney
2020-05-14 22:49 ` Frederic Weisbecker
2020-05-13 16:47 ` [PATCH 08/10] rcu: Allow to deactivate nocb on a CPU Frederic Weisbecker
2020-05-13 18:38 ` Paul E. McKenney
2020-05-13 22:45 ` Frederic Weisbecker
2020-05-14 15:47 ` Paul E. McKenney
2020-05-14 22:30 ` Frederic Weisbecker
2020-05-14 22:47 ` Paul E. McKenney
2020-05-14 22:55 ` Frederic Weisbecker
2020-05-26 21:20 ` Joel Fernandes
2020-05-26 22:49 ` Joel Fernandes
2020-06-04 13:10 ` Frederic Weisbecker
2020-06-11 1:32 ` Joel Fernandes
2020-06-11 17:03 ` Paul E. McKenney
2020-06-04 13:14 ` Frederic Weisbecker
2020-05-13 16:47 ` [PATCH 09/10] rcu: Allow to re-offload a CPU that used to be nocb Frederic Weisbecker
2020-05-13 18:41 ` Paul E. McKenney
2020-05-13 16:47 ` [PATCH 10/10] rcu: Nocb (de)activate through sysfs Frederic Weisbecker
2020-05-13 18:42 ` Paul E. McKenney
2020-05-13 23:23 ` Frederic Weisbecker
2020-05-14 15:51 ` Paul E. McKenney
2020-05-13 18:15 ` [PATCH 00/10] rcu: Allow a CPU to leave and reenter NOCB state Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200514154754.GM2869@paulmck-ThinkPad-P72 \
--to=paulmck@kernel.org \
--cc=frederic@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).