linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] dt-bindings: power: supply: bq25890: Indent example with tabs
@ 2020-06-17 10:23 Krzysztof Kozlowski
  2020-06-17 10:23 ` [PATCH 2/2] dt-bindings: power: supply: bq25890: Document required interrupt Krzysztof Kozlowski
  2020-06-19 14:38 ` [PATCH 1/2] dt-bindings: power: supply: bq25890: Indent example with tabs Sebastian Reichel
  0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2020-06-17 10:23 UTC (permalink / raw)
  To: Sebastian Reichel, Rob Herring, Krzysztof Kozlowski,
	Laurentiu Palcu, linux-pm, devicetree, linux-kernel

Fix example indentation to tabs to follow generic Linux coding style.
This avoids copying the space indentation to DTS when re-using the
example.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 .../bindings/power/supply/bq25890.txt         | 22 +++++++++----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/Documentation/devicetree/bindings/power/supply/bq25890.txt b/Documentation/devicetree/bindings/power/supply/bq25890.txt
index dc9c8f76e06c..51ecc756521f 100644
--- a/Documentation/devicetree/bindings/power/supply/bq25890.txt
+++ b/Documentation/devicetree/bindings/power/supply/bq25890.txt
@@ -36,17 +36,17 @@ Optional properties:
 Example:
 
 bq25890 {
-        compatible = "ti,bq25890";
-        reg = <0x6a>;
+	compatible = "ti,bq25890";
+	reg = <0x6a>;
 
-        ti,battery-regulation-voltage = <4200000>;
-        ti,charge-current = <1000000>;
-        ti,termination-current = <50000>;
-        ti,precharge-current = <128000>;
-        ti,minimum-sys-voltage = <3600000>;
-        ti,boost-voltage = <5000000>;
-        ti,boost-max-current = <1000000>;
+	ti,battery-regulation-voltage = <4200000>;
+	ti,charge-current = <1000000>;
+	ti,termination-current = <50000>;
+	ti,precharge-current = <128000>;
+	ti,minimum-sys-voltage = <3600000>;
+	ti,boost-voltage = <5000000>;
+	ti,boost-max-current = <1000000>;
 
-        ti,use-ilim-pin;
-        ti,thermal-regulation-threshold = <120>;
+	ti,use-ilim-pin;
+	ti,thermal-regulation-threshold = <120>;
 };
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH 2/2] dt-bindings: power: supply: bq25890: Document required interrupt
  2020-06-17 10:23 [PATCH 1/2] dt-bindings: power: supply: bq25890: Indent example with tabs Krzysztof Kozlowski
@ 2020-06-17 10:23 ` Krzysztof Kozlowski
  2020-06-19 14:39   ` Sebastian Reichel
  2020-06-19 14:38 ` [PATCH 1/2] dt-bindings: power: supply: bq25890: Indent example with tabs Sebastian Reichel
  1 sibling, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2020-06-17 10:23 UTC (permalink / raw)
  To: Sebastian Reichel, Rob Herring, Krzysztof Kozlowski,
	Laurentiu Palcu, linux-pm, devicetree, linux-kernel
  Cc: stable

The driver requires interrupts (fails probe if it is not provided) so
document this requirement in bindings.

Fixes: 4aeae9cb0dad ("power_supply: Add support for TI BQ25890 charger chip")
Cc: <stable@vger.kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 Documentation/devicetree/bindings/power/supply/bq25890.txt | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/power/supply/bq25890.txt b/Documentation/devicetree/bindings/power/supply/bq25890.txt
index 51ecc756521f..3b4c69a7fa70 100644
--- a/Documentation/devicetree/bindings/power/supply/bq25890.txt
+++ b/Documentation/devicetree/bindings/power/supply/bq25890.txt
@@ -10,6 +10,7 @@ Required properties:
     * "ti,bq25895"
     * "ti,bq25896"
 - reg: integer, i2c address of the device.
+- interrupts: interrupt line;
 - ti,battery-regulation-voltage: integer, maximum charging voltage (in uV);
 - ti,charge-current: integer, maximum charging current (in uA);
 - ti,termination-current: integer, charge will be terminated when current in
@@ -39,6 +40,9 @@ bq25890 {
 	compatible = "ti,bq25890";
 	reg = <0x6a>;
 
+	interrupt-parent = <&gpio1>;
+	interrupts = <16 IRQ_TYPE_EDGE_FALLING>;
+
 	ti,battery-regulation-voltage = <4200000>;
 	ti,charge-current = <1000000>;
 	ti,termination-current = <50000>;
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] dt-bindings: power: supply: bq25890: Indent example with tabs
  2020-06-17 10:23 [PATCH 1/2] dt-bindings: power: supply: bq25890: Indent example with tabs Krzysztof Kozlowski
  2020-06-17 10:23 ` [PATCH 2/2] dt-bindings: power: supply: bq25890: Document required interrupt Krzysztof Kozlowski
@ 2020-06-19 14:38 ` Sebastian Reichel
  1 sibling, 0 replies; 4+ messages in thread
From: Sebastian Reichel @ 2020-06-19 14:38 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Rob Herring, Laurentiu Palcu, linux-pm, devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1765 bytes --]

Hi,

On Wed, Jun 17, 2020 at 12:23:04PM +0200, Krzysztof Kozlowski wrote:
> Fix example indentation to tabs to follow generic Linux coding style.
> This avoids copying the space indentation to DTS when re-using the
> example.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---

Thanks, queued.

-- Sebastian

>  .../bindings/power/supply/bq25890.txt         | 22 +++++++++----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/bq25890.txt b/Documentation/devicetree/bindings/power/supply/bq25890.txt
> index dc9c8f76e06c..51ecc756521f 100644
> --- a/Documentation/devicetree/bindings/power/supply/bq25890.txt
> +++ b/Documentation/devicetree/bindings/power/supply/bq25890.txt
> @@ -36,17 +36,17 @@ Optional properties:
>  Example:
>  
>  bq25890 {
> -        compatible = "ti,bq25890";
> -        reg = <0x6a>;
> +	compatible = "ti,bq25890";
> +	reg = <0x6a>;
>  
> -        ti,battery-regulation-voltage = <4200000>;
> -        ti,charge-current = <1000000>;
> -        ti,termination-current = <50000>;
> -        ti,precharge-current = <128000>;
> -        ti,minimum-sys-voltage = <3600000>;
> -        ti,boost-voltage = <5000000>;
> -        ti,boost-max-current = <1000000>;
> +	ti,battery-regulation-voltage = <4200000>;
> +	ti,charge-current = <1000000>;
> +	ti,termination-current = <50000>;
> +	ti,precharge-current = <128000>;
> +	ti,minimum-sys-voltage = <3600000>;
> +	ti,boost-voltage = <5000000>;
> +	ti,boost-max-current = <1000000>;
>  
> -        ti,use-ilim-pin;
> -        ti,thermal-regulation-threshold = <120>;
> +	ti,use-ilim-pin;
> +	ti,thermal-regulation-threshold = <120>;
>  };
> -- 
> 2.17.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] dt-bindings: power: supply: bq25890: Document required interrupt
  2020-06-17 10:23 ` [PATCH 2/2] dt-bindings: power: supply: bq25890: Document required interrupt Krzysztof Kozlowski
@ 2020-06-19 14:39   ` Sebastian Reichel
  0 siblings, 0 replies; 4+ messages in thread
From: Sebastian Reichel @ 2020-06-19 14:39 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Rob Herring, Laurentiu Palcu, linux-pm, devicetree, linux-kernel, stable

[-- Attachment #1: Type: text/plain, Size: 1550 bytes --]

Hi,

On Wed, Jun 17, 2020 at 12:23:05PM +0200, Krzysztof Kozlowski wrote:
> The driver requires interrupts (fails probe if it is not provided) so
> document this requirement in bindings.
> 
> Fixes: 4aeae9cb0dad ("power_supply: Add support for TI BQ25890 charger chip")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---

Thanks, queued.

-- Sebastian

>  Documentation/devicetree/bindings/power/supply/bq25890.txt | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/bq25890.txt b/Documentation/devicetree/bindings/power/supply/bq25890.txt
> index 51ecc756521f..3b4c69a7fa70 100644
> --- a/Documentation/devicetree/bindings/power/supply/bq25890.txt
> +++ b/Documentation/devicetree/bindings/power/supply/bq25890.txt
> @@ -10,6 +10,7 @@ Required properties:
>      * "ti,bq25895"
>      * "ti,bq25896"
>  - reg: integer, i2c address of the device.
> +- interrupts: interrupt line;
>  - ti,battery-regulation-voltage: integer, maximum charging voltage (in uV);
>  - ti,charge-current: integer, maximum charging current (in uA);
>  - ti,termination-current: integer, charge will be terminated when current in
> @@ -39,6 +40,9 @@ bq25890 {
>  	compatible = "ti,bq25890";
>  	reg = <0x6a>;
>  
> +	interrupt-parent = <&gpio1>;
> +	interrupts = <16 IRQ_TYPE_EDGE_FALLING>;
> +
>  	ti,battery-regulation-voltage = <4200000>;
>  	ti,charge-current = <1000000>;
>  	ti,termination-current = <50000>;
> -- 
> 2.17.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-19 16:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-17 10:23 [PATCH 1/2] dt-bindings: power: supply: bq25890: Indent example with tabs Krzysztof Kozlowski
2020-06-17 10:23 ` [PATCH 2/2] dt-bindings: power: supply: bq25890: Document required interrupt Krzysztof Kozlowski
2020-06-19 14:39   ` Sebastian Reichel
2020-06-19 14:38 ` [PATCH 1/2] dt-bindings: power: supply: bq25890: Indent example with tabs Sebastian Reichel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).