linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] rt2x00: remove duplicate word in comment
@ 2021-02-03  6:38 samirweng1979
  2021-02-03 15:16 ` Randy Dunlap
  0 siblings, 1 reply; 5+ messages in thread
From: samirweng1979 @ 2021-02-03  6:38 UTC (permalink / raw)
  To: stf_xl, helmut.schaa, kvalo, davem, kuba
  Cc: linux-wireless, netdev, linux-kernel, wengjianfeng

From: wengjianfeng <wengjianfeng@yulong.com>

remove duplicate word 'we' in comment

Signed-off-by: wengjianfeng <wengjianfeng@yulong.com>
---
 drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c b/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c
index c861811..7158152 100644
--- a/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c
+++ b/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c
@@ -179,7 +179,7 @@ void rt2x00crypto_rx_insert_iv(struct sk_buff *skb,
 	 * Make room for new data. There are 2 possibilities
 	 * either the alignment is already present between
 	 * the 802.11 header and payload. In that case we
-	 * we have to move the header less then the iv_len
+	 * have to move the header less then the iv_len
 	 * since we can use the already available l2pad bytes
 	 * for the iv data.
 	 * When the alignment must be added manually we must
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] rt2x00: remove duplicate word in comment
  2021-02-03  6:38 [PATCH] rt2x00: remove duplicate word in comment samirweng1979
@ 2021-02-03 15:16 ` Randy Dunlap
  2021-02-04  0:30   ` wengjianfeng
  0 siblings, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2021-02-03 15:16 UTC (permalink / raw)
  To: samirweng1979, stf_xl, helmut.schaa, kvalo, davem, kuba
  Cc: linux-wireless, netdev, linux-kernel, wengjianfeng

On 2/2/21 10:38 PM, samirweng1979 wrote:
> From: wengjianfeng <wengjianfeng@yulong.com>
> 
> remove duplicate word 'we' in comment
> 
> Signed-off-by: wengjianfeng <wengjianfeng@yulong.com>
> ---
>  drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c b/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c
> index c861811..7158152 100644
> --- a/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c
> +++ b/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c
> @@ -179,7 +179,7 @@ void rt2x00crypto_rx_insert_iv(struct sk_buff *skb,
>  	 * Make room for new data. There are 2 possibilities
>  	 * either the alignment is already present between
>  	 * the 802.11 header and payload. In that case we
> -	 * we have to move the header less then the iv_len
> +	 * have to move the header less then the iv_len

s/then/than/

>  	 * since we can use the already available l2pad bytes
>  	 * for the iv data.
>  	 * When the alignment must be added manually we must
> 


-- 
~Randy


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] rt2x00: remove duplicate word in comment
  2021-02-03 15:16 ` Randy Dunlap
@ 2021-02-04  0:30   ` wengjianfeng
  2021-02-04  0:33     ` Randy Dunlap
  0 siblings, 1 reply; 5+ messages in thread
From: wengjianfeng @ 2021-02-04  0:30 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: stf_xl, helmut.schaa, kvalo, davem, kuba, linux-wireless, netdev,
	linux-kernel, wengjianfeng

On Wed, 3 Feb 2021 07:16:17 -0800
Randy Dunlap <rdunlap@infradead.org> wrote:

> On 2/2/21 10:38 PM, samirweng1979 wrote:
> > From: wengjianfeng <wengjianfeng@yulong.com>
> > 
> > remove duplicate word 'we' in comment
> > 
> > Signed-off-by: wengjianfeng <wengjianfeng@yulong.com>
> > ---
> >  drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c
> > b/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c index
> > c861811..7158152 100644 ---
> > a/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c +++
> > b/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c @@ -179,7
> > +179,7 @@ void rt2x00crypto_rx_insert_iv(struct sk_buff *skb,
> >  	 * Make room for new data. There are 2 possibilities
> >  	 * either the alignment is already present between
> >  	 * the 802.11 header and payload. In that case we
> > -	 * we have to move the header less then the iv_len
> > +	 * have to move the header less then the iv_len
> 
> s/then/than/
> 
> >  	 * since we can use the already available l2pad bytes
> >  	 * for the iv data.
> >  	 * When the alignment must be added manually we must
> > 
> 
> 

Hi Randy,
   So you means add it for byte alignment, right? if yes,just ignore
   the patch. thanks.


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] rt2x00: remove duplicate word in comment
  2021-02-04  0:30   ` wengjianfeng
@ 2021-02-04  0:33     ` Randy Dunlap
  2021-02-04  0:39       ` wengjianfeng
  0 siblings, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2021-02-04  0:33 UTC (permalink / raw)
  To: wengjianfeng
  Cc: stf_xl, helmut.schaa, kvalo, davem, kuba, linux-wireless, netdev,
	linux-kernel, wengjianfeng

On 2/3/21 4:30 PM, wengjianfeng wrote:
> On Wed, 3 Feb 2021 07:16:17 -0800
> Randy Dunlap <rdunlap@infradead.org> wrote:
> 
>> On 2/2/21 10:38 PM, samirweng1979 wrote:
>>> From: wengjianfeng <wengjianfeng@yulong.com>
>>>
>>> remove duplicate word 'we' in comment
>>>
>>> Signed-off-by: wengjianfeng <wengjianfeng@yulong.com>
>>> ---
>>>  drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c
>>> b/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c index
>>> c861811..7158152 100644 ---
>>> a/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c +++
>>> b/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c @@ -179,7
>>> +179,7 @@ void rt2x00crypto_rx_insert_iv(struct sk_buff *skb,
>>>  	 * Make room for new data. There are 2 possibilities
>>>  	 * either the alignment is already present between
>>>  	 * the 802.11 header and payload. In that case we
>>> -	 * we have to move the header less then the iv_len
>>> +	 * have to move the header less then the iv_len
>>
>> s/then/than/
>>
>>>  	 * since we can use the already available l2pad bytes
>>>  	 * for the iv data.
>>>  	 * When the alignment must be added manually we must
>>>
>>
>>
> 
> Hi Randy,
>    So you means add it for byte alignment, right? if yes,just ignore
>    the patch. thanks.

No, I mean that there is a typo there also: "then" should be changed to "than"
while you are making changes.

thanks.
-- 
~Randy


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] rt2x00: remove duplicate word in comment
  2021-02-04  0:33     ` Randy Dunlap
@ 2021-02-04  0:39       ` wengjianfeng
  0 siblings, 0 replies; 5+ messages in thread
From: wengjianfeng @ 2021-02-04  0:39 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: stf_xl, helmut.schaa, kvalo, davem, kuba, linux-wireless, netdev,
	linux-kernel, wengjianfeng

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=GB18030, Size: 1726 bytes --]

On Wed, 3 Feb 2021 16:33:37 -0800
Randy Dunlap <rdunlap@infradead.org> wrote:

> On 2/3/21 4:30 PM, wengjianfeng wrote:
> > On Wed, 3 Feb 2021 07:16:17 -0800
> > Randy Dunlap <rdunlap@infradead.org> wrote:
> > 
> >> On 2/2/21 10:38 PM, samirweng1979 wrote:
> >>> From: wengjianfeng <wengjianfeng@yulong.com>
> >>>
> >>> remove duplicate word 'we' in comment
> >>>
> >>> Signed-off-by: wengjianfeng <wengjianfeng@yulong.com>
> >>> ---
> >>>  drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c | 2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c
> >>> b/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c index
> >>> c861811..7158152 100644 ---
> >>> a/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c +++
> >>> b/drivers/net/wireless/ralink/rt2x00/rt2x00crypto.c @@ -179,7
> >>> +179,7 @@ void rt2x00crypto_rx_insert_iv(struct sk_buff *skb,
> >>>  	 * Make room for new data. There are 2 possibilities
> >>>  	 * either the alignment is already present between
> >>>  	 * the 802.11 header and payload. In that case we
> >>> -	 * we have to move the header less then the iv_len
> >>> +	 * have to move the header less then the iv_len
> >>
> >> s/then/than/
> >>
> >>>  	 * since we can use the already available l2pad bytes
> >>>  	 * for the iv data.
> >>>  	 * When the alignment must be added manually we must
> >>>
> >>
> >>
> > 
> > Hi Randy,
> >    So you means add it for byte alignment, right? if yes,just ignore
> >    the patch. thanks.
> 
> No, I mean that there is a typo there also: "then" should be changed
> to "than" while you are making changes.
> 
> thanks.

Hi Randy£¬
  Ok£¬ I¡¡will update the patch£¬thanks for your reply.


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-02-04  4:43 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-03  6:38 [PATCH] rt2x00: remove duplicate word in comment samirweng1979
2021-02-03 15:16 ` Randy Dunlap
2021-02-04  0:30   ` wengjianfeng
2021-02-04  0:33     ` Randy Dunlap
2021-02-04  0:39       ` wengjianfeng

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).