* [PATCH] mfd: da9063: propagate errno when I2C mode fails
@ 2021-05-25 13:42 Wolfram Sang
2021-05-25 14:03 ` AW: " Jonas Mark (BT-FIR/ENG1-Grb)
2021-06-01 15:00 ` Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Wolfram Sang @ 2021-05-25 13:42 UTC (permalink / raw)
To: linux-kernel
Cc: Support Opensource, Lee Jones, Mark Jonas, Hubert Streidl,
stwiss.opensource, Wolfram Sang
Don't hardocde EIO but use the obtained value.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/mfd/da9063-i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/da9063-i2c.c b/drivers/mfd/da9063-i2c.c
index 783a14af18e2..4b7f707b7952 100644
--- a/drivers/mfd/da9063-i2c.c
+++ b/drivers/mfd/da9063-i2c.c
@@ -448,7 +448,7 @@ static int da9063_i2c_probe(struct i2c_client *i2c,
DA9063_TWOWIRE_TO);
if (ret < 0) {
dev_err(da9063->dev, "Failed to set Two-Wire Bus Mode.\n");
- return -EIO;
+ return ret;
}
}
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* AW: [PATCH] mfd: da9063: propagate errno when I2C mode fails
2021-05-25 13:42 [PATCH] mfd: da9063: propagate errno when I2C mode fails Wolfram Sang
@ 2021-05-25 14:03 ` Jonas Mark (BT-FIR/ENG1-Grb)
2021-06-01 15:00 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Jonas Mark (BT-FIR/ENG1-Grb) @ 2021-05-25 14:03 UTC (permalink / raw)
To: Wolfram Sang, linux-kernel
Cc: Support Opensource, Lee Jones, Streidl Hubert (BT-FIR/ENG1-Grb),
stwiss.opensource, Jonas Mark (BT-FIR/ENG1-Grb)
> Von: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Gesendet: Dienstag, 25. Mai 2021 15:43
> An: linux-kernel@vger.kernel.org
> Cc: Support Opensource <support.opensource@diasemi.com>; Lee Jones
> <lee.jones@linaro.org>; Jonas Mark (BT-FIR/ENG1-Grb)
> <Mark.Jonas@de.bosch.com>; Streidl Hubert (BT-FIR/ENG1-Grb)
> <Hubert.Streidl@de.bosch.com>; stwiss.opensource@diasemi.com; Wolfram
> Sang <wsa+renesas@sang-engineering.com>
> Betreff: [PATCH] mfd: da9063: propagate errno when I2C mode fails
>
> Don't hardocde EIO but use the obtained value.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> drivers/mfd/da9063-i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/da9063-i2c.c b/drivers/mfd/da9063-i2c.c index
> 783a14af18e2..4b7f707b7952 100644
> --- a/drivers/mfd/da9063-i2c.c
> +++ b/drivers/mfd/da9063-i2c.c
> @@ -448,7 +448,7 @@ static int da9063_i2c_probe(struct i2c_client *i2c,
> DA9063_TWOWIRE_TO);
> if (ret < 0) {
> dev_err(da9063->dev, "Failed to set Two-Wire Bus
> Mode.\n");
> - return -EIO;
> + return ret;
> }
> }
>
> --
> 2.30.2
Reviewed-by: Mark Jonas <mark.jonas@de.bosch.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: da9063: propagate errno when I2C mode fails
2021-05-25 13:42 [PATCH] mfd: da9063: propagate errno when I2C mode fails Wolfram Sang
2021-05-25 14:03 ` AW: " Jonas Mark (BT-FIR/ENG1-Grb)
@ 2021-06-01 15:00 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2021-06-01 15:00 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-kernel, Support Opensource, Mark Jonas, Hubert Streidl,
stwiss.opensource
On Tue, 25 May 2021, Wolfram Sang wrote:
> Don't hardocde EIO but use the obtained value.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> drivers/mfd/da9063-i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-01 15:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-25 13:42 [PATCH] mfd: da9063: propagate errno when I2C mode fails Wolfram Sang
2021-05-25 14:03 ` AW: " Jonas Mark (BT-FIR/ENG1-Grb)
2021-06-01 15:00 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).