[PATCH 1/1] ring-buffer: remove leading spaces before tabs

[PATCH 1/1] ring-buffer: remove leading spaces before tabs

[Zhen Lei]

1) Run the following command to find and remove the leading spaces before
   tabs:
   find kernel/trace/ -type f | xargs sed -r -i 's/^[ ]+\t/\t/'
2) Manually check and correct if necessary

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 kernel/trace/ring_buffer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index 833ade3d0b00..a555258556c5 100644
--- a/kernel/trace/ring_buffer.c
+++ b/kernel/trace/ring_buffer.c
@@ -5887,7 +5887,7 @@ static __init int test_ringbuffer(void)
 		}
 
 		kthread_bind(rb_threads[cpu], cpu);
- 		wake_up_process(rb_threads[cpu]);
+		wake_up_process(rb_threads[cpu]);
 	}
 
 	/* Now create the rb hammer! */
-- 
2.25.1

Re: [PATCH 1/1] ring-buffer: remove leading spaces before tabs

[Steven Rostedt]

On Tue, 8 Jun 2021 16:10:51 +0800
Zhen Lei <thunder.leizhen@huawei.com> wrote:

> 1) Run the following command to find and remove the leading spaces before
>    tabs:
>    find kernel/trace/ -type f | xargs sed -r -i 's/^[ ]+\t/\t/'
> 2) Manually check and correct if necessary
> 
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>

Sorry, but I do not accept whitespace changes. Clean ups like this is
only welcomed if they come along with actual changes to the code around
them. Otherwise, this just causes extra churn and unwelcomed work for
the maintainer.

-- Steve


> ---
>  kernel/trace/ring_buffer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
> index 833ade3d0b00..a555258556c5 100644
> --- a/kernel/trace/ring_buffer.c
> +++ b/kernel/trace/ring_buffer.c
> @@ -5887,7 +5887,7 @@ static __init int test_ringbuffer(void)
>  		}
>  
>  		kthread_bind(rb_threads[cpu], cpu);
> - 		wake_up_process(rb_threads[cpu]);
> +		wake_up_process(rb_threads[cpu]);
>  	}
>  
>  	/* Now create the rb hammer! */

Re: [PATCH 1/1] ring-buffer: remove leading spaces before tabs

[Leizhen (ThunderTown)]

On 2021/6/8 22:59, Steven Rostedt wrote:
> On Tue, 8 Jun 2021 16:10:51 +0800
> Zhen Lei <thunder.leizhen@huawei.com> wrote:
> 
>> 1) Run the following command to find and remove the leading spaces before
>>    tabs:
>>    find kernel/trace/ -type f | xargs sed -r -i 's/^[ ]+\t/\t/'
>> 2) Manually check and correct if necessary
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> 
> Sorry, but I do not accept whitespace changes. Clean ups like this is
> only welcomed if they come along with actual changes to the code around

It's the wrong way of thinking. It's like having mosquitoes in the house and
killing a mosquito only when you meet it. Mosquitoes will exist for a long
time, and not all mosquitoes will be killed. People who have been in the house
will always face being bitten unless they don't care.


> them. Otherwise, this just causes extra churn and unwelcomed work for
> the maintainer.

Yes, the changes are a little less. There is no owner for the whole kernel
module. So I had to take it apart. As a programmer, since I discovered it,
I had an instinctive drive to fix it. Even if it won't be accepted.

> 
> -- Steve
> 
> 
>> ---
>>  kernel/trace/ring_buffer.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
>> index 833ade3d0b00..a555258556c5 100644
>> --- a/kernel/trace/ring_buffer.c
>> +++ b/kernel/trace/ring_buffer.c
>> @@ -5887,7 +5887,7 @@ static __init int test_ringbuffer(void)
>>  		}
>>  
>>  		kthread_bind(rb_threads[cpu], cpu);
>> - 		wake_up_process(rb_threads[cpu]);
>> +		wake_up_process(rb_threads[cpu]);
>>  	}
>>  
>>  	/* Now create the rb hammer! */
> 
> 
> .
>