From: Rob Herring <robh@kernel.org>
To: Alistair Francis <alistair@alistair23.me>
Cc: lee.jones@linaro.org, lgirdwood@gmail.com, broonie@kernel.org,
linux-imx@nxp.com, kernel@pengutronix.de,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
alistair23@gmail.com
Subject: Re: [PATCH v6 1/5] dt-bindings: mfd: Initial commit of silergy,sy7636a.yaml
Date: Thu, 24 Jun 2021 14:56:22 -0600 [thread overview]
Message-ID: <20210624205622.GA1968619@robh.at.kernel.org> (raw)
In-Reply-To: <20210615103400.946-1-alistair@alistair23.me>
On Tue, Jun 15, 2021 at 08:33:56PM +1000, Alistair Francis wrote:
> Initial support for the Silergy SY7636A Power Management chip
> and regulator.
>
> Signed-off-by: Alistair Francis <alistair@alistair23.me>
> ---
> .../bindings/mfd/silergy,sy7636a.yaml | 73 +++++++++++++++++++
> 1 file changed, 73 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml
>
> diff --git a/Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml b/Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml
> new file mode 100644
> index 000000000000..9e50f57d5e8d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml
> @@ -0,0 +1,73 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/silergy,sy7636a.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: silergy sy7636a PMIC
> +
> +maintainers:
> + - Alistair Francis <alistair@alistair23.me>
> +
> +properties:
> + compatible:
> + const: silergy,sy7636a
> +
> + reg:
> + maxItems: 1
> +
> + '#thermal-sensor-cells':
> + const: 0
> +
> + epd-pwr-good-gpios:
> + description:
> + Specifying the power good GPIOs. As defined in bindings/gpio.txt.
Drop the 2nd sentence.
> + maxItems: 1
> +
> + regulators:
> + type: object
> +
> + properties:
> + compatible:
> + const: silergy,sy7636a-regulator
> +
> + "vcom":
Don't need quotes.
> + type: object
> + $ref: /schemas/regulator/regulator.yaml#
> +
> + regulator-name:
> + const: "vcom"
Don't need quotes.
Doesn't this belong in the 'vcom' node? You need another 'properties'
and this under it.
> +
> + additionalProperties: false
> +
> +required:
> + - compatible
> + - reg
> + - '#thermal-sensor-cells'
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pmic@62 {
> + compatible = "silergy,sy7636a";
> + reg = <0x62>;
> + status = "okay";
Don't show status in examples.
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_epdpmic>;
> + #thermal-sensor-cells = <0>;
> +
> + regulators {
> + compatible = "silergy,sy7636a-regulator";
> + reg_epdpmic: vcom {
> + regulator-name = "vcom";
> + regulator-boot-on;
> + };
> + };
> + };
> + };
> +...
> --
> 2.31.1
>
>
prev parent reply other threads:[~2021-06-24 20:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 10:33 [PATCH v6 1/5] dt-bindings: mfd: Initial commit of silergy,sy7636a.yaml Alistair Francis
2021-06-15 10:33 ` [PATCH v6 2/5] mfd: sy7636a: Initial commit Alistair Francis
2021-06-16 10:56 ` Lee Jones
2021-06-16 22:01 ` Alistair Francis
2021-06-17 9:20 ` Lee Jones
2021-07-08 11:16 ` Alistair Francis
2021-07-08 12:47 ` Lee Jones
2021-07-28 6:57 ` Alistair Francis
2021-08-02 8:45 ` Lee Jones
2021-06-15 10:33 ` [PATCH v6 3/5] regulator: " Alistair Francis
2021-06-15 10:33 ` [PATCH v6 4/5] ARM: imx_v6_v7_defconfig: Enable silergy,sy7636a Alistair Francis
2021-06-15 10:34 ` [PATCH v6 5/5] ARM: dts: imx7d: remarkable2: " Alistair Francis
2021-06-15 17:29 ` (subset) [PATCH v6 1/5] dt-bindings: mfd: Initial commit of silergy,sy7636a.yaml Mark Brown
2021-06-24 20:56 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210624205622.GA1968619@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=alistair23@gmail.com \
--cc=alistair@alistair23.me \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).