* [PATCH] media: mtk-vcodec: MT8173 h264/vp8 encoder min/max bitrate settings
@ 2021-09-26 3:39 Irui Wang
2021-10-06 0:57 ` Hirokazu Honda
0 siblings, 1 reply; 2+ messages in thread
From: Irui Wang @ 2021-09-26 3:39 UTC (permalink / raw)
To: Hans Verkuil, Tzung-Bi Shih, Hirokazu Honda, Alexandre Courbot,
Tiffany Lin, Mauro Carvalho Chehab, Matthias Brugger,
Tomasz Figa
Cc: Hsin-Yi Wang, Maoguang Meng, Longfei Wang, Yunfei Dong,
Fritz Koenig, Irui Wang, linux-media, linux-kernel,
linux-arm-kernel, srv_heupstream, linux-mediatek,
Project_Global_Chrome_Upstream_Group
Set recommend min/max bitrate range for MT8173 h264/vp8 encoder.
Signed-off-by: Irui Wang <irui.wang@mediatek.com>
---
This patch dependents on "Clean redundant encoder format definition",
which already accepted into linux-next.git:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/patch/?id=4093eb21538ae4f2861b26f4615939e1fa50dc67
---
drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
index 4489a9744cd7..5dce3681ce94 100644
--- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
+++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
@@ -388,8 +388,8 @@ static const struct mtk_vcodec_enc_pdata mt8173_avc_pdata = {
.num_capture_formats = ARRAY_SIZE(mtk_video_formats_capture_h264),
.output_formats = mtk_video_formats_output,
.num_output_formats = ARRAY_SIZE(mtk_video_formats_output),
- .min_bitrate = 1,
- .max_bitrate = 4000000,
+ .min_bitrate = 64,
+ .max_bitrate = 60000000,
.core_id = VENC_SYS,
};
@@ -400,7 +400,7 @@ static const struct mtk_vcodec_enc_pdata mt8173_vp8_pdata = {
.output_formats = mtk_video_formats_output,
.num_output_formats = ARRAY_SIZE(mtk_video_formats_output),
.min_bitrate = 64,
- .max_bitrate = 4000000,
+ .max_bitrate = 9000000,
.core_id = VENC_LT_SYS,
};
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: mtk-vcodec: MT8173 h264/vp8 encoder min/max bitrate settings
2021-09-26 3:39 [PATCH] media: mtk-vcodec: MT8173 h264/vp8 encoder min/max bitrate settings Irui Wang
@ 2021-10-06 0:57 ` Hirokazu Honda
0 siblings, 0 replies; 2+ messages in thread
From: Hirokazu Honda @ 2021-10-06 0:57 UTC (permalink / raw)
To: Irui Wang
Cc: Hans Verkuil, Tzung-Bi Shih, Alexandre Courbot, Tiffany Lin,
Mauro Carvalho Chehab, Matthias Brugger, Tomasz Figa,
Hsin-Yi Wang, Maoguang Meng, Longfei Wang, Yunfei Dong,
Fritz Koenig, linux-media, linux-kernel, linux-arm-kernel,
srv_heupstream, linux-mediatek,
Project_Global_Chrome_Upstream_Group
Hi Irui, thank you for the patch.
On Sun, Sep 26, 2021 at 12:39 PM Irui Wang <irui.wang@mediatek.com> wrote:
>
> Set recommend min/max bitrate range for MT8173 h264/vp8 encoder.
>
> Signed-off-by: Irui Wang <irui.wang@mediatek.com>
I confirmed the patch worked with my own test.
Tested-by: Hirokazu Honda <hiroh@chromium.org>
-Hiro
>
> ---
> This patch dependents on "Clean redundant encoder format definition",
> which already accepted into linux-next.git:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/patch/?id=4093eb21538ae4f2861b26f4615939e1fa50dc67
> ---
> drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
> index 4489a9744cd7..5dce3681ce94 100644
> --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
> +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c
> @@ -388,8 +388,8 @@ static const struct mtk_vcodec_enc_pdata mt8173_avc_pdata = {
> .num_capture_formats = ARRAY_SIZE(mtk_video_formats_capture_h264),
> .output_formats = mtk_video_formats_output,
> .num_output_formats = ARRAY_SIZE(mtk_video_formats_output),
> - .min_bitrate = 1,
> - .max_bitrate = 4000000,
> + .min_bitrate = 64,
> + .max_bitrate = 60000000,
> .core_id = VENC_SYS,
> };
>
> @@ -400,7 +400,7 @@ static const struct mtk_vcodec_enc_pdata mt8173_vp8_pdata = {
> .output_formats = mtk_video_formats_output,
> .num_output_formats = ARRAY_SIZE(mtk_video_formats_output),
> .min_bitrate = 64,
> - .max_bitrate = 4000000,
> + .max_bitrate = 9000000,
> .core_id = VENC_LT_SYS,
> };
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-06 0:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-26 3:39 [PATCH] media: mtk-vcodec: MT8173 h264/vp8 encoder min/max bitrate settings Irui Wang
2021-10-06 0:57 ` Hirokazu Honda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).