* [PATCH] coding-style.rst: trivial: fix location of driver model macros @ 2021-04-23 18:40 Trevor Woerner 2021-04-23 18:54 ` Shuah Khan 2021-04-23 19:14 ` Miguel Ojeda 0 siblings, 2 replies; 14+ messages in thread From: Trevor Woerner @ 2021-04-23 18:40 UTC (permalink / raw) To: linux-kernel Cc: Jonathan Corbet, Jiri Kosina, Joe Perches, Shuah Khan, Matthias Brugger, Miguel Ojeda, Geert Uytterhoeven, Alexander A. Klimov, Yorick de Wid, Dan Williams, open list:DOCUMENTATION The dev_printk()-like functions moved to include/linux/dev_print.h in commit af628aae8640 ("device.h: move dev_printk()-like functions to dev_printk.h"). Signed-off-by: Trevor Woerner <twoerner@gmail.com> --- Documentation/process/coding-style.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/process/coding-style.rst b/Documentation/process/coding-style.rst index 42969ab37b34..44f796ba52c4 100644 --- a/Documentation/process/coding-style.rst +++ b/Documentation/process/coding-style.rst @@ -855,7 +855,7 @@ Kernel messages do not have to be terminated with a period. Printing numbers in parentheses (%d) adds no value and should be avoided. -There are a number of driver model diagnostic macros in <linux/device.h> +There are a number of driver model diagnostic macros in <linux/dev_printk.h> which you should use to make sure messages are matched to the right device and driver, and are tagged with the right level: dev_err(), dev_warn(), dev_info(), and so forth. For messages that aren't associated with a -- 2.30.0.rc0 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] coding-style.rst: trivial: fix location of driver model macros 2021-04-23 18:40 [PATCH] coding-style.rst: trivial: fix location of driver model macros Trevor Woerner @ 2021-04-23 18:54 ` Shuah Khan 2021-04-23 19:14 ` Miguel Ojeda 1 sibling, 0 replies; 14+ messages in thread From: Shuah Khan @ 2021-04-23 18:54 UTC (permalink / raw) To: Trevor Woerner, linux-kernel Cc: Jonathan Corbet, Jiri Kosina, Joe Perches, Matthias Brugger, Miguel Ojeda, Geert Uytterhoeven, Alexander A. Klimov, Yorick de Wid, Dan Williams, open list:DOCUMENTATION, Shuah Khan On 4/23/21 12:40 PM, Trevor Woerner wrote: > The dev_printk()-like functions moved to include/linux/dev_print.h in > commit af628aae8640 ("device.h: move dev_printk()-like functions to > dev_printk.h"). > > Signed-off-by: Trevor Woerner <twoerner@gmail.com> > --- > Documentation/process/coding-style.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/process/coding-style.rst b/Documentation/process/coding-style.rst > index 42969ab37b34..44f796ba52c4 100644 > --- a/Documentation/process/coding-style.rst > +++ b/Documentation/process/coding-style.rst > @@ -855,7 +855,7 @@ Kernel messages do not have to be terminated with a period. > > Printing numbers in parentheses (%d) adds no value and should be avoided. > > -There are a number of driver model diagnostic macros in <linux/device.h> > +There are a number of driver model diagnostic macros in <linux/dev_printk.h> > which you should use to make sure messages are matched to the right device > and driver, and are tagged with the right level: dev_err(), dev_warn(), > dev_info(), and so forth. For messages that aren't associated with a > Looks good to me. Thanks for catching this. Reviewed-by: Shuah Khan <skhan@linuxfoundation.org> thanks, -- Shuah ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] coding-style.rst: trivial: fix location of driver model macros 2021-04-23 18:40 [PATCH] coding-style.rst: trivial: fix location of driver model macros Trevor Woerner 2021-04-23 18:54 ` Shuah Khan @ 2021-04-23 19:14 ` Miguel Ojeda [not found] ` <CAHUNapQfFBcqrX7MvUvq8qbPgk2bPu-h3+9NxAUFpRtpOGFODw@mail.gmail.com> 1 sibling, 1 reply; 14+ messages in thread From: Miguel Ojeda @ 2021-04-23 19:14 UTC (permalink / raw) To: Trevor Woerner Cc: linux-kernel, Jonathan Corbet, Jiri Kosina, Joe Perches, Shuah Khan, Matthias Brugger, Miguel Ojeda, Geert Uytterhoeven, Alexander A. Klimov, Yorick de Wid, Dan Williams, open list:DOCUMENTATION On Fri, Apr 23, 2021 at 8:40 PM Trevor Woerner <twoerner@gmail.com> wrote: > > The dev_printk()-like functions moved to include/linux/dev_print.h in > commit af628aae8640 ("device.h: move dev_printk()-like functions to > dev_printk.h"). > > Signed-off-by: Trevor Woerner <twoerner@gmail.com> LGTM Reviewed-by: Miguel Ojeda <ojeda@kernel.org> Cheers, Miguel ^ permalink raw reply [flat|nested] 14+ messages in thread
[parent not found: <CAHUNapQfFBcqrX7MvUvq8qbPgk2bPu-h3+9NxAUFpRtpOGFODw@mail.gmail.com>]
* Re: [PATCH] coding-style.rst: trivial: fix location of driver model macros [not found] ` <CAHUNapQfFBcqrX7MvUvq8qbPgk2bPu-h3+9NxAUFpRtpOGFODw@mail.gmail.com> @ 2021-10-26 12:47 ` Miguel Ojeda 2021-10-26 14:44 ` Trevor Woerner 2021-10-26 15:41 ` Jonathan Corbet 1 sibling, 1 reply; 14+ messages in thread From: Miguel Ojeda @ 2021-10-26 12:47 UTC (permalink / raw) To: Jonathan Corbet, Andrew Morton, Trevor Woerner Cc: linux-kernel, Jiri Kosina, Joe Perches, Shuah Khan, Matthias Brugger, Miguel Ojeda, Geert Uytterhoeven, Alexander A. Klimov, Yorick de Wid, Dan Williams, open list:DOCUMENTATION On Mon, Oct 25, 2021 at 11:40 PM Trevor Woerner <twoerner@gmail.com> wrote: > > ping? > > It doesn't look like this was picked up by trivial? Although, it doesn't look like git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial.git has been used in a while. Is there an alternate (preferred) path for trivial patches? Jonathan should be able to take it, or perhaps Andrew. Note that you should put whoever should take it in the To field (I just noticed your original email did not) -- use `scripts/get_maintainer.pl` for getting the relevant people for a patch or path. Cheers, Miguel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] coding-style.rst: trivial: fix location of driver model macros 2021-10-26 12:47 ` Miguel Ojeda @ 2021-10-26 14:44 ` Trevor Woerner 2021-10-26 15:10 ` Miguel Ojeda 2021-10-26 15:37 ` Joe Perches 0 siblings, 2 replies; 14+ messages in thread From: Trevor Woerner @ 2021-10-26 14:44 UTC (permalink / raw) To: Miguel Ojeda Cc: Jonathan Corbet, Andrew Morton, linux-kernel, Jiri Kosina, Joe Perches, Shuah Khan, Matthias Brugger, Miguel Ojeda, Geert Uytterhoeven, Alexander A. Klimov, Yorick de Wid, Dan Williams, open list:DOCUMENTATION On Tue 2021-10-26 @ 02:47:12 PM, Miguel Ojeda wrote: > On Mon, Oct 25, 2021 at 11:40 PM Trevor Woerner <twoerner@gmail.com> wrote: > > > > ping? > > > > It doesn't look like this was picked up by trivial? Although, it doesn't look like git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial.git has been used in a while. Is there an alternate (preferred) path for trivial patches? > > Jonathan should be able to take it, or perhaps Andrew. > > Note that you should put whoever should take it in the To field (I > just noticed your original email did not) -- use > `scripts/get_maintainer.pl` for getting the relevant people for a > patch or path. Ah, good point. I have a "cccmd" line in my ~/.gitconfig for adding people to the CC when I "git send-email", maybe I should switch that to a "tocmd"? get_maintainer.pl didn't add Andrew back then on my patch and still doesn't even now. Maybe the MAINTAINERS file needs an update if Andrew is to be included on trivial/documentation patches? ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] coding-style.rst: trivial: fix location of driver model macros 2021-10-26 14:44 ` Trevor Woerner @ 2021-10-26 15:10 ` Miguel Ojeda 2021-10-26 15:18 ` Randy Dunlap 2021-10-26 15:37 ` Joe Perches 1 sibling, 1 reply; 14+ messages in thread From: Miguel Ojeda @ 2021-10-26 15:10 UTC (permalink / raw) To: Trevor Woerner Cc: Jonathan Corbet, Andrew Morton, linux-kernel, Jiri Kosina, Joe Perches, Shuah Khan, Matthias Brugger, Miguel Ojeda, Geert Uytterhoeven, Alexander A. Klimov, Yorick de Wid, Dan Williams, open list:DOCUMENTATION On Tue, Oct 26, 2021 at 4:44 PM Trevor Woerner <twoerner@gmail.com> wrote: > > get_maintainer.pl didn't add Andrew back then on my patch and still doesn't > even now. Maybe the MAINTAINERS file needs an update if Andrew is to be > included on trivial/documentation patches? I mentioned Andrew because he does the hard job of being a backup for everything and everyone, but normally you should try to put the actual maintainer first in the `To` field and/or trivial@kernel.org. Cheers, Miguel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] coding-style.rst: trivial: fix location of driver model macros 2021-10-26 15:10 ` Miguel Ojeda @ 2021-10-26 15:18 ` Randy Dunlap 2021-10-26 15:27 ` Joe Perches 2021-10-26 15:28 ` Miguel Ojeda 0 siblings, 2 replies; 14+ messages in thread From: Randy Dunlap @ 2021-10-26 15:18 UTC (permalink / raw) To: Miguel Ojeda, Trevor Woerner Cc: Jonathan Corbet, Andrew Morton, linux-kernel, Jiri Kosina, Joe Perches, Shuah Khan, Matthias Brugger, Miguel Ojeda, Geert Uytterhoeven, Alexander A. Klimov, Yorick de Wid, Dan Williams, open list:DOCUMENTATION On 10/26/21 8:10 AM, Miguel Ojeda wrote: > On Tue, Oct 26, 2021 at 4:44 PM Trevor Woerner <twoerner@gmail.com> wrote: >> >> get_maintainer.pl didn't add Andrew back then on my patch and still doesn't >> even now. Maybe the MAINTAINERS file needs an update if Andrew is to be >> included on trivial/documentation patches? > > I mentioned Andrew because he does the hard job of being a backup for > everything and everyone, but normally you should try to put the actual > maintainer first in the `To` field and/or trivial@kernel.org. I think that we decided to stop using trivial@kernel.org for new patches a few months ago... -- ~Randy ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] coding-style.rst: trivial: fix location of driver model macros 2021-10-26 15:18 ` Randy Dunlap @ 2021-10-26 15:27 ` Joe Perches 2021-10-26 23:49 ` Randy Dunlap 2021-10-26 15:28 ` Miguel Ojeda 1 sibling, 1 reply; 14+ messages in thread From: Joe Perches @ 2021-10-26 15:27 UTC (permalink / raw) To: Randy Dunlap, Miguel Ojeda, Trevor Woerner Cc: Jonathan Corbet, Andrew Morton, linux-kernel, Jiri Kosina, Shuah Khan, Matthias Brugger, Miguel Ojeda, Geert Uytterhoeven, Alexander A. Klimov, Yorick de Wid, Dan Williams, open list:DOCUMENTATION On Tue, 2021-10-26 at 08:18 -0700, Randy Dunlap wrote: > On 10/26/21 8:10 AM, Miguel Ojeda wrote: > > On Tue, Oct 26, 2021 at 4:44 PM Trevor Woerner <twoerner@gmail.com> wrote: > > > > > > get_maintainer.pl didn't add Andrew back then on my patch and still doesn't > > > even now. Maybe the MAINTAINERS file needs an update if Andrew is to be > > > included on trivial/documentation patches? > > > > I mentioned Andrew because he does the hard job of being a backup for > > everything and everyone, but normally you should try to put the actual > > maintainer first in the `To` field and/or trivial@kernel.org. > > I think that we decided to stop using trivial@kernel.org for new patches > a few months ago... Dunno who the "we" is but then maybe this is appropriate: --- MAINTAINERS | 6 ------ 1 file changed, 6 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 869e6cc6366bc..8c933736bb412 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -19282,12 +19282,6 @@ W: https://github.com/srcres258/linux-doc T: git git://github.com/srcres258/linux-doc.git doc-zh-tw F: Documentation/translations/zh_TW/ -TRIVIAL PATCHES -M: Jiri Kosina <trivial@kernel.org> -S: Maintained -T: git git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial.git -K: ^Subject:.*(?i)trivial - TTY LAYER M: Greg Kroah-Hartman <gregkh@linuxfoundation.org> M: Jiri Slaby <jirislaby@kernel.org> ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] coding-style.rst: trivial: fix location of driver model macros 2021-10-26 15:27 ` Joe Perches @ 2021-10-26 23:49 ` Randy Dunlap 0 siblings, 0 replies; 14+ messages in thread From: Randy Dunlap @ 2021-10-26 23:49 UTC (permalink / raw) To: Joe Perches, Miguel Ojeda, Trevor Woerner Cc: Jonathan Corbet, Andrew Morton, linux-kernel, Jiri Kosina, Shuah Khan, Matthias Brugger, Miguel Ojeda, Geert Uytterhoeven, Alexander A. Klimov, Yorick de Wid, Dan Williams, open list:DOCUMENTATION On 10/26/21 8:27 AM, Joe Perches wrote: > On Tue, 2021-10-26 at 08:18 -0700, Randy Dunlap wrote: >> On 10/26/21 8:10 AM, Miguel Ojeda wrote: >>> On Tue, Oct 26, 2021 at 4:44 PM Trevor Woerner <twoerner@gmail.com> wrote: >>>> >>>> get_maintainer.pl didn't add Andrew back then on my patch and still doesn't >>>> even now. Maybe the MAINTAINERS file needs an update if Andrew is to be >>>> included on trivial/documentation patches? >>> >>> I mentioned Andrew because he does the hard job of being a backup for >>> everything and everyone, but normally you should try to put the actual >>> maintainer first in the `To` field and/or trivial@kernel.org. >> >> I think that we decided to stop using trivial@kernel.org for new patches >> a few months ago... > > Dunno who the "we" is but then maybe this is appropriate: > --- > MAINTAINERS | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 869e6cc6366bc..8c933736bb412 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -19282,12 +19282,6 @@ W: https://github.com/srcres258/linux-doc > T: git git://github.com/srcres258/linux-doc.git doc-zh-tw > F: Documentation/translations/zh_TW/ > > -TRIVIAL PATCHES > -M: Jiri Kosina <trivial@kernel.org> > -S: Maintained > -T: git git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial.git > -K: ^Subject:.*(?i)trivial > - > TTY LAYER > M: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > M: Jiri Slaby <jirislaby@kernel.org> > Jiri? Acked-by: Randy Dunlap <rdunlap@infradead.org> thanks. -- ~Randy ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] coding-style.rst: trivial: fix location of driver model macros 2021-10-26 15:18 ` Randy Dunlap 2021-10-26 15:27 ` Joe Perches @ 2021-10-26 15:28 ` Miguel Ojeda 1 sibling, 0 replies; 14+ messages in thread From: Miguel Ojeda @ 2021-10-26 15:28 UTC (permalink / raw) To: Randy Dunlap Cc: Trevor Woerner, Jonathan Corbet, Andrew Morton, linux-kernel, Jiri Kosina, Joe Perches, Shuah Khan, Matthias Brugger, Miguel Ojeda, Geert Uytterhoeven, Alexander A. Klimov, Yorick de Wid, Dan Williams, open list:DOCUMENTATION On Tue, Oct 26, 2021 at 5:18 PM Randy Dunlap <rdunlap@infradead.org> wrote: > > I think that we decided to stop using trivial@kernel.org for new patches > a few months ago... Ah, good to know, thanks! Then we should update submitting-patches.rst at least. Cheers, Miguel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] coding-style.rst: trivial: fix location of driver model macros 2021-10-26 14:44 ` Trevor Woerner 2021-10-26 15:10 ` Miguel Ojeda @ 2021-10-26 15:37 ` Joe Perches 2021-10-26 21:21 ` Trevor Woerner 1 sibling, 1 reply; 14+ messages in thread From: Joe Perches @ 2021-10-26 15:37 UTC (permalink / raw) To: Trevor Woerner, Miguel Ojeda Cc: Jonathan Corbet, Andrew Morton, linux-kernel, Jiri Kosina, Shuah Khan, Matthias Brugger, Miguel Ojeda, Geert Uytterhoeven, Alexander A. Klimov, Yorick de Wid, Dan Williams, open list:DOCUMENTATION On Tue, 2021-10-26 at 10:44 -0400, Trevor Woerner wrote: > On Tue 2021-10-26 @ 02:47:12 PM, Miguel Ojeda wrote: > > On Mon, Oct 25, 2021 at 11:40 PM Trevor Woerner <twoerner@gmail.com> wrote: > > > ping? [] > > Note that you should put whoever should take it in the To field (I > > just noticed your original email did not) -- use > > `scripts/get_maintainer.pl` for getting the relevant people for a > > patch or path. > > Ah, good point. I have a "cccmd" line in my ~/.gitconfig for adding people to > the CC when I "git send-email", maybe I should switch that to a "tocmd"? I use scripts for both. https://lore.kernel.org/all/1473862411.32273.25.camel@perches.com/ ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] coding-style.rst: trivial: fix location of driver model macros 2021-10-26 15:37 ` Joe Perches @ 2021-10-26 21:21 ` Trevor Woerner 0 siblings, 0 replies; 14+ messages in thread From: Trevor Woerner @ 2021-10-26 21:21 UTC (permalink / raw) To: Joe Perches Cc: Miguel Ojeda, Jonathan Corbet, Andrew Morton, linux-kernel, Jiri Kosina, Shuah Khan, Matthias Brugger, Miguel Ojeda, Geert Uytterhoeven, Alexander A. Klimov, Yorick de Wid, Dan Williams, open list:DOCUMENTATION Joe, On Tue 2021-10-26 @ 08:37:29 AM, Joe Perches wrote: > On Tue, 2021-10-26 at 10:44 -0400, Trevor Woerner wrote: > > On Tue 2021-10-26 @ 02:47:12 PM, Miguel Ojeda wrote: > > > On Mon, Oct 25, 2021 at 11:40 PM Trevor Woerner <twoerner@gmail.com> wrote: > > > > ping? > [] > > > Note that you should put whoever should take it in the To field (I > > > just noticed your original email did not) -- use > > > `scripts/get_maintainer.pl` for getting the relevant people for a > > > patch or path. > > > > Ah, good point. I have a "cccmd" line in my ~/.gitconfig for adding people to > > the CC when I "git send-email", maybe I should switch that to a "tocmd"? > > I use scripts for both. > > https://lore.kernel.org/all/1473862411.32273.25.camel@perches.com/ That is awesome, thanks! ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] coding-style.rst: trivial: fix location of driver model macros [not found] ` <CAHUNapQfFBcqrX7MvUvq8qbPgk2bPu-h3+9NxAUFpRtpOGFODw@mail.gmail.com> 2021-10-26 12:47 ` Miguel Ojeda @ 2021-10-26 15:41 ` Jonathan Corbet 2021-10-26 21:23 ` Trevor Woerner 1 sibling, 1 reply; 14+ messages in thread From: Jonathan Corbet @ 2021-10-26 15:41 UTC (permalink / raw) To: Trevor Woerner, Miguel Ojeda Cc: linux-kernel, Jiri Kosina, Joe Perches, Shuah Khan, Matthias Brugger, Miguel Ojeda, Geert Uytterhoeven, Alexander A. Klimov, Dan Williams, open list:DOCUMENTATION Trevor Woerner <twoerner@gmail.com> writes: > ping? > > It doesn't look like this was picked up by trivial? Although, it doesn't > look like git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial.git > has been used in a while. Is there an alternate (preferred) path for > trivial patches? Hmm...no idea why I missed it the first time around. Applied now, apologies for the delay. Thanks, jon ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] coding-style.rst: trivial: fix location of driver model macros 2021-10-26 15:41 ` Jonathan Corbet @ 2021-10-26 21:23 ` Trevor Woerner 0 siblings, 0 replies; 14+ messages in thread From: Trevor Woerner @ 2021-10-26 21:23 UTC (permalink / raw) To: Jonathan Corbet Cc: Miguel Ojeda, linux-kernel, Jiri Kosina, Joe Perches, Shuah Khan, Matthias Brugger, Miguel Ojeda, Geert Uytterhoeven, Alexander A. Klimov, Dan Williams, open list:DOCUMENTATION On Tue 2021-10-26 @ 09:41:10 AM, Jonathan Corbet wrote: > Trevor Woerner <twoerner@gmail.com> writes: > > > ping? > > > > It doesn't look like this was picked up by trivial? Although, it doesn't > > look like git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial.git > > has been used in a while. Is there an alternate (preferred) path for > > trivial patches? > > Hmm...no idea why I missed it the first time around. Applied now, Maybe because I added you in the CC instead of TO? Sorry about that. Anyway, that's cleaned up now (thanks to Joe's scripts). > Applied now, > apologies for the delay. Thanks! ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2021-10-26 23:49 UTC | newest] Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-04-23 18:40 [PATCH] coding-style.rst: trivial: fix location of driver model macros Trevor Woerner 2021-04-23 18:54 ` Shuah Khan 2021-04-23 19:14 ` Miguel Ojeda [not found] ` <CAHUNapQfFBcqrX7MvUvq8qbPgk2bPu-h3+9NxAUFpRtpOGFODw@mail.gmail.com> 2021-10-26 12:47 ` Miguel Ojeda 2021-10-26 14:44 ` Trevor Woerner 2021-10-26 15:10 ` Miguel Ojeda 2021-10-26 15:18 ` Randy Dunlap 2021-10-26 15:27 ` Joe Perches 2021-10-26 23:49 ` Randy Dunlap 2021-10-26 15:28 ` Miguel Ojeda 2021-10-26 15:37 ` Joe Perches 2021-10-26 21:21 ` Trevor Woerner 2021-10-26 15:41 ` Jonathan Corbet 2021-10-26 21:23 ` Trevor Woerner
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).