[PATCH] coding-style.rst: trivial: fix location of driver model macros

[PATCH] coding-style.rst: trivial: fix location of driver model macros

[Trevor Woerner]

The dev_printk()-like functions moved to include/linux/dev_print.h in
commit af628aae8640 ("device.h: move dev_printk()-like functions to
dev_printk.h").

Signed-off-by: Trevor Woerner <twoerner@gmail.com>
---
 Documentation/process/coding-style.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/process/coding-style.rst b/Documentation/process/coding-style.rst
index 42969ab37b34..44f796ba52c4 100644
--- a/Documentation/process/coding-style.rst
+++ b/Documentation/process/coding-style.rst
@@ -855,7 +855,7 @@ Kernel messages do not have to be terminated with a period.
 
 Printing numbers in parentheses (%d) adds no value and should be avoided.
 
-There are a number of driver model diagnostic macros in <linux/device.h>
+There are a number of driver model diagnostic macros in <linux/dev_printk.h>
 which you should use to make sure messages are matched to the right device
 and driver, and are tagged with the right level:  dev_err(), dev_warn(),
 dev_info(), and so forth.  For messages that aren't associated with a
-- 
2.30.0.rc0

Re: [PATCH] coding-style.rst: trivial: fix location of driver model macros

[Shuah Khan]

On 4/23/21 12:40 PM, Trevor Woerner wrote:
> The dev_printk()-like functions moved to include/linux/dev_print.h in
> commit af628aae8640 ("device.h: move dev_printk()-like functions to
> dev_printk.h").
> 
> Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> ---
>   Documentation/process/coding-style.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/process/coding-style.rst b/Documentation/process/coding-style.rst
> index 42969ab37b34..44f796ba52c4 100644
> --- a/Documentation/process/coding-style.rst
> +++ b/Documentation/process/coding-style.rst
> @@ -855,7 +855,7 @@ Kernel messages do not have to be terminated with a period.
>   
>   Printing numbers in parentheses (%d) adds no value and should be avoided.
>   
> -There are a number of driver model diagnostic macros in <linux/device.h>
> +There are a number of driver model diagnostic macros in <linux/dev_printk.h>
>   which you should use to make sure messages are matched to the right device
>   and driver, and are tagged with the right level:  dev_err(), dev_warn(),
>   dev_info(), and so forth.  For messages that aren't associated with a
> 

Looks good to me. Thanks for catching this.

Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>

thanks,
-- Shuah

Re: [PATCH] coding-style.rst: trivial: fix location of driver model macros

[Miguel Ojeda]

On Fri, Apr 23, 2021 at 8:40 PM Trevor Woerner <twoerner@gmail.com> wrote:
>
> The dev_printk()-like functions moved to include/linux/dev_print.h in
> commit af628aae8640 ("device.h: move dev_printk()-like functions to
> dev_printk.h").
>
> Signed-off-by: Trevor Woerner <twoerner@gmail.com>

LGTM

    Reviewed-by: Miguel Ojeda <ojeda@kernel.org>

Cheers,
Miguel

Re: [PATCH] coding-style.rst: trivial: fix location of driver model macros

[Miguel Ojeda]

On Mon, Oct 25, 2021 at 11:40 PM Trevor Woerner <twoerner@gmail.com> wrote:
>
> ping?
>
> It doesn't look like this was picked up by trivial? Although, it doesn't look like git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial.git has been used in a while. Is there an alternate (preferred) path for trivial patches?

Jonathan should be able to take it, or perhaps Andrew.

Note that you should put whoever should take it in the To field (I
just noticed your original email did not) -- use
`scripts/get_maintainer.pl` for getting the relevant people for a
patch or path.

Cheers,
Miguel

Re: [PATCH] coding-style.rst: trivial: fix location of driver model macros

[Trevor Woerner]

On Tue 2021-10-26 @ 02:47:12 PM, Miguel Ojeda wrote:
> On Mon, Oct 25, 2021 at 11:40 PM Trevor Woerner <twoerner@gmail.com> wrote:
> >
> > ping?
> >
> > It doesn't look like this was picked up by trivial? Although, it doesn't look like git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial.git has been used in a while. Is there an alternate (preferred) path for trivial patches?
> 
> Jonathan should be able to take it, or perhaps Andrew.
> 
> Note that you should put whoever should take it in the To field (I
> just noticed your original email did not) -- use
> `scripts/get_maintainer.pl` for getting the relevant people for a
> patch or path.

Ah, good point. I have a "cccmd" line in my ~/.gitconfig for adding people to
the CC when I "git send-email", maybe I should switch that to a "tocmd"?

get_maintainer.pl didn't add Andrew back then on my patch and still doesn't
even now. Maybe the MAINTAINERS file needs an update if Andrew is to be
included on trivial/documentation patches?

Re: [PATCH] coding-style.rst: trivial: fix location of driver model macros

[Miguel Ojeda]

On Tue, Oct 26, 2021 at 4:44 PM Trevor Woerner <twoerner@gmail.com> wrote:
>
> get_maintainer.pl didn't add Andrew back then on my patch and still doesn't
> even now. Maybe the MAINTAINERS file needs an update if Andrew is to be
> included on trivial/documentation patches?

I mentioned Andrew because he does the hard job of being a backup for
everything and everyone, but normally you should try to put the actual
maintainer first in the `To` field and/or trivial@kernel.org.

Cheers,
Miguel

Re: [PATCH] coding-style.rst: trivial: fix location of driver model macros

[Randy Dunlap]

On 10/26/21 8:10 AM, Miguel Ojeda wrote:
> On Tue, Oct 26, 2021 at 4:44 PM Trevor Woerner <twoerner@gmail.com> wrote:
>>
>> get_maintainer.pl didn't add Andrew back then on my patch and still doesn't
>> even now. Maybe the MAINTAINERS file needs an update if Andrew is to be
>> included on trivial/documentation patches?
> 
> I mentioned Andrew because he does the hard job of being a backup for
> everything and everyone, but normally you should try to put the actual
> maintainer first in the `To` field and/or trivial@kernel.org.

I think that we decided to stop using trivial@kernel.org for new patches
a few months ago...

-- 
~Randy

Re: [PATCH] coding-style.rst: trivial: fix location of driver model macros

[Joe Perches]

On Tue, 2021-10-26 at 08:18 -0700, Randy Dunlap wrote:
> On 10/26/21 8:10 AM, Miguel Ojeda wrote:
> > On Tue, Oct 26, 2021 at 4:44 PM Trevor Woerner <twoerner@gmail.com> wrote:
> > > 
> > > get_maintainer.pl didn't add Andrew back then on my patch and still doesn't
> > > even now. Maybe the MAINTAINERS file needs an update if Andrew is to be
> > > included on trivial/documentation patches?
> > 
> > I mentioned Andrew because he does the hard job of being a backup for
> > everything and everyone, but normally you should try to put the actual
> > maintainer first in the `To` field and/or trivial@kernel.org.
> 
> I think that we decided to stop using trivial@kernel.org for new patches
> a few months ago...

Dunno who the "we" is but then maybe this is appropriate:
---
 MAINTAINERS | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 869e6cc6366bc..8c933736bb412 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -19282,12 +19282,6 @@ W:	https://github.com/srcres258/linux-doc
 T:	git git://github.com/srcres258/linux-doc.git doc-zh-tw
 F:	Documentation/translations/zh_TW/
 
-TRIVIAL PATCHES
-M:	Jiri Kosina <trivial@kernel.org>
-S:	Maintained
-T:	git git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial.git
-K:	^Subject:.*(?i)trivial
-
 TTY LAYER
 M:	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 M:	Jiri Slaby <jirislaby@kernel.org>

Re: [PATCH] coding-style.rst: trivial: fix location of driver model macros

[Miguel Ojeda]

On Tue, Oct 26, 2021 at 5:18 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> I think that we decided to stop using trivial@kernel.org for new patches
> a few months ago...

Ah, good to know, thanks! Then we should update submitting-patches.rst at least.

Cheers,
Miguel

Re: [PATCH] coding-style.rst: trivial: fix location of driver model macros

[Joe Perches]

On Tue, 2021-10-26 at 10:44 -0400, Trevor Woerner wrote:
> On Tue 2021-10-26 @ 02:47:12 PM, Miguel Ojeda wrote:
> > On Mon, Oct 25, 2021 at 11:40 PM Trevor Woerner <twoerner@gmail.com> wrote:
> > > ping?
[]
> > Note that you should put whoever should take it in the To field (I
> > just noticed your original email did not) -- use
> > `scripts/get_maintainer.pl` for getting the relevant people for a
> > patch or path.
> 
> Ah, good point. I have a "cccmd" line in my ~/.gitconfig for adding people to
> the CC when I "git send-email", maybe I should switch that to a "tocmd"?

I use scripts for both.

https://lore.kernel.org/all/1473862411.32273.25.camel@perches.com/

Re: [PATCH] coding-style.rst: trivial: fix location of driver model macros

[Jonathan Corbet]

Trevor Woerner <twoerner@gmail.com> writes:

> ping?
>
> It doesn't look like this was picked up by trivial? Although, it doesn't
> look like git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial.git
> has been used in a while. Is there an alternate (preferred) path for
> trivial patches?

Hmm...no idea why I missed it the first time around.  Applied now,
apologies for the delay.

Thanks,

jon

Re: [PATCH] coding-style.rst: trivial: fix location of driver model macros

[Trevor Woerner]

Joe,

On Tue 2021-10-26 @ 08:37:29 AM, Joe Perches wrote:
> On Tue, 2021-10-26 at 10:44 -0400, Trevor Woerner wrote:
> > On Tue 2021-10-26 @ 02:47:12 PM, Miguel Ojeda wrote:
> > > On Mon, Oct 25, 2021 at 11:40 PM Trevor Woerner <twoerner@gmail.com> wrote:
> > > > ping?
> []
> > > Note that you should put whoever should take it in the To field (I
> > > just noticed your original email did not) -- use
> > > `scripts/get_maintainer.pl` for getting the relevant people for a
> > > patch or path.
> > 
> > Ah, good point. I have a "cccmd" line in my ~/.gitconfig for adding people to
> > the CC when I "git send-email", maybe I should switch that to a "tocmd"?
> 
> I use scripts for both.
> 
> https://lore.kernel.org/all/1473862411.32273.25.camel@perches.com/

That is awesome, thanks!

Re: [PATCH] coding-style.rst: trivial: fix location of driver model macros

[Trevor Woerner]

On Tue 2021-10-26 @ 09:41:10 AM, Jonathan Corbet wrote:
> Trevor Woerner <twoerner@gmail.com> writes:
> 
> > ping?
> >
> > It doesn't look like this was picked up by trivial? Although, it doesn't
> > look like git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial.git
> > has been used in a while. Is there an alternate (preferred) path for
> > trivial patches?
> 
> Hmm...no idea why I missed it the first time around.  Applied now,

Maybe because I added you in the CC instead of TO? Sorry about that. Anyway,
that's cleaned up now (thanks to Joe's scripts).

> Applied now,
> apologies for the delay.

Thanks!

Re: [PATCH] coding-style.rst: trivial: fix location of driver model macros

[Randy Dunlap]

On 10/26/21 8:27 AM, Joe Perches wrote:
> On Tue, 2021-10-26 at 08:18 -0700, Randy Dunlap wrote:
>> On 10/26/21 8:10 AM, Miguel Ojeda wrote:
>>> On Tue, Oct 26, 2021 at 4:44 PM Trevor Woerner <twoerner@gmail.com> wrote:
>>>>
>>>> get_maintainer.pl didn't add Andrew back then on my patch and still doesn't
>>>> even now. Maybe the MAINTAINERS file needs an update if Andrew is to be
>>>> included on trivial/documentation patches?
>>>
>>> I mentioned Andrew because he does the hard job of being a backup for
>>> everything and everyone, but normally you should try to put the actual
>>> maintainer first in the `To` field and/or trivial@kernel.org.
>>
>> I think that we decided to stop using trivial@kernel.org for new patches
>> a few months ago...
> 
> Dunno who the "we" is but then maybe this is appropriate:
> ---
>   MAINTAINERS | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 869e6cc6366bc..8c933736bb412 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -19282,12 +19282,6 @@ W:	https://github.com/srcres258/linux-doc
>   T:	git git://github.com/srcres258/linux-doc.git doc-zh-tw
>   F:	Documentation/translations/zh_TW/
>   
> -TRIVIAL PATCHES
> -M:	Jiri Kosina <trivial@kernel.org>
> -S:	Maintained
> -T:	git git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial.git
> -K:	^Subject:.*(?i)trivial
> -
>   TTY LAYER
>   M:	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>   M:	Jiri Slaby <jirislaby@kernel.org>
> 

Jiri?

Acked-by: Randy Dunlap <rdunlap@infradead.org>

thanks.

-- 
~Randy