* linux-next: build warnings after merge of the hwmon-staging tree
@ 2021-11-24 5:22 Stephen Rothwell
2021-11-24 6:43 ` [PATCH 1/1] hwmon: Fix warnings in asus_wmi_sensors.rst documetation Denis Pauk
0 siblings, 1 reply; 12+ messages in thread
From: Stephen Rothwell @ 2021-11-24 5:22 UTC (permalink / raw)
To: Guenter Roeck
Cc: Denis Pauk, Ed Brindley, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 516 bytes --]
Hi all,
After merging the hwmon-staging tree, today's linux-next build (htmldocs)
produced these warnings:
Documentation/hwmon/asus_wmi_sensors.rst:33: WARNING: Unexpected indentation.
Documentation/hwmon/asus_wmi_sensors.rst:68: WARNING: Unexpected indentation.
Documentation/hwmon/asus_wmi_sensors.rst:76: WARNING: Block quote ends without a blank line; unexpected unindent.
Introduced by commit
9d07e54a25b8 ("hwmon: (asus_wmi_sensors) Support X370 Asus WMI.")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 1/1] hwmon: Fix warnings in asus_wmi_sensors.rst documetation.
2021-11-24 5:22 linux-next: build warnings after merge of the hwmon-staging tree Stephen Rothwell
@ 2021-11-24 6:43 ` Denis Pauk
2021-11-24 14:13 ` Guenter Roeck
0 siblings, 1 reply; 12+ messages in thread
From: Denis Pauk @ 2021-11-24 6:43 UTC (permalink / raw)
Cc: Denis Pauk, Jean Delvare, Guenter Roeck, Jonathan Corbet,
Ed Brindley, linux-hwmon, linux-doc, linux-kernel
Fixes: 9d07e54a25b8 ("hwmon: (asus_wmi_sensors) Support X370 Asus WMI.")
Signed-off-by: Denis Pauk <pauk.denis@gmail.com>
---
Documentation/hwmon/asus_wmi_sensors.rst | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/Documentation/hwmon/asus_wmi_sensors.rst b/Documentation/hwmon/asus_wmi_sensors.rst
index 408fd3b4a0de..8f2096cf5183 100644
--- a/Documentation/hwmon/asus_wmi_sensors.rst
+++ b/Documentation/hwmon/asus_wmi_sensors.rst
@@ -29,7 +29,9 @@ ASUS mainboards publish hardware monitoring information via WMI interface.
ASUS WMI interface provides a methods to get list of sensors and values of
such, which is utilized by this driver to publish those sensor readings to the
-HWMON system. The driver is aware of and reads the following sensors:
+HWMON system.
+
+The driver is aware of and reads the following sensors:
* CPU Core Voltage,
* CPU SOC Voltage,
* DRAM Voltage,
@@ -64,7 +66,7 @@ HWMON system. The driver is aware of and reads the following sensors:
* CPU VRM Output Current.
Known Issues:
-* The WMI implementation in some of Asus' BIOSes is buggy. This can result in
+ * The WMI implementation in some of Asus' BIOSes is buggy. This can result in
fans stopping, fans getting stuck at max speed, or temperature readouts
getting stuck. This is not an issue with the driver, but the BIOS. The Prime
X470 Pro seems particularly bad for this. The more frequently the WMI
@@ -73,4 +75,4 @@ Known Issues:
sensors frequently, don't leave you computer unattended. Upgrading to new
BIOS version with method version greater than or equal to two should
rectify the issue.
-* A few boards report 12v voltages to be ~10v.
+ * A few boards report 12v voltages to be ~10v.
base-commit: 9d07e54a25b84099983f56e33e00f2914f06b53f
--
2.33.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 1/1] hwmon: Fix warnings in asus_wmi_sensors.rst documetation.
2021-11-24 6:43 ` [PATCH 1/1] hwmon: Fix warnings in asus_wmi_sensors.rst documetation Denis Pauk
@ 2021-11-24 14:13 ` Guenter Roeck
0 siblings, 0 replies; 12+ messages in thread
From: Guenter Roeck @ 2021-11-24 14:13 UTC (permalink / raw)
To: Denis Pauk
Cc: Jean Delvare, Jonathan Corbet, Ed Brindley, linux-hwmon,
linux-doc, linux-kernel
On 11/23/21 10:43 PM, Denis Pauk wrote:
> Fixes: 9d07e54a25b8 ("hwmon: (asus_wmi_sensors) Support X370 Asus WMI.")
>
> Signed-off-by: Denis Pauk <pauk.denis@gmail.com>
Squashed into offending commit.
However, for the future,
1) Please always provide a full description of the problem
2) Never send a patch as reply to a previous patch, or as reply
to a bug report, unless you want it to get lost.
Where is that "send patch as reply" thing coming from ?
It seems to proliferate for some reason. Is someone promoting that ?
Thanks,
Guenter
> ---
> Documentation/hwmon/asus_wmi_sensors.rst | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/hwmon/asus_wmi_sensors.rst b/Documentation/hwmon/asus_wmi_sensors.rst
> index 408fd3b4a0de..8f2096cf5183 100644
> --- a/Documentation/hwmon/asus_wmi_sensors.rst
> +++ b/Documentation/hwmon/asus_wmi_sensors.rst
> @@ -29,7 +29,9 @@ ASUS mainboards publish hardware monitoring information via WMI interface.
>
> ASUS WMI interface provides a methods to get list of sensors and values of
> such, which is utilized by this driver to publish those sensor readings to the
> -HWMON system. The driver is aware of and reads the following sensors:
> +HWMON system.
> +
> +The driver is aware of and reads the following sensors:
> * CPU Core Voltage,
> * CPU SOC Voltage,
> * DRAM Voltage,
> @@ -64,7 +66,7 @@ HWMON system. The driver is aware of and reads the following sensors:
> * CPU VRM Output Current.
>
> Known Issues:
> -* The WMI implementation in some of Asus' BIOSes is buggy. This can result in
> + * The WMI implementation in some of Asus' BIOSes is buggy. This can result in
> fans stopping, fans getting stuck at max speed, or temperature readouts
> getting stuck. This is not an issue with the driver, but the BIOS. The Prime
> X470 Pro seems particularly bad for this. The more frequently the WMI
> @@ -73,4 +75,4 @@ Known Issues:
> sensors frequently, don't leave you computer unattended. Upgrading to new
> BIOS version with method version greater than or equal to two should
> rectify the issue.
> -* A few boards report 12v voltages to be ~10v.
> + * A few boards report 12v voltages to be ~10v.
>
> base-commit: 9d07e54a25b84099983f56e33e00f2914f06b53f
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* linux-next: build warnings after merge of the hwmon-staging tree
@ 2024-02-04 23:41 Stephen Rothwell
2024-02-05 0:04 ` Guenter Roeck
0 siblings, 1 reply; 12+ messages in thread
From: Stephen Rothwell @ 2024-02-04 23:41 UTC (permalink / raw)
To: Guenter Roeck
Cc: Charles Hsu, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 491 bytes --]
Hi all,
After merging the hwmon-staging tree, today's linux-next build (x86_64
allmodconfig) produced these warnings:
WARNING: modpost: module mpq8785 uses symbol pmbus_do_probe from namespace PMBUS, but does not import it.
WARNING: modpost: module mpq8785 uses symbol pmbus_read_byte_data from namespace PMBUS, but does not import it.
Introduced by commit
7dd62e578cb4 ("hwmon: Add driver for MPS MPQ8785 Synchronous Step-Down Converter")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 484 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: linux-next: build warnings after merge of the hwmon-staging tree
2024-02-04 23:41 linux-next: build warnings after merge of the hwmon-staging tree Stephen Rothwell
@ 2024-02-05 0:04 ` Guenter Roeck
0 siblings, 0 replies; 12+ messages in thread
From: Guenter Roeck @ 2024-02-05 0:04 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Charles Hsu, Linux Kernel Mailing List, Linux Next Mailing List
On 2/4/24 15:41, Stephen Rothwell wrote:
> Hi all,
>
> After merging the hwmon-staging tree, today's linux-next build (x86_64
> allmodconfig) produced these warnings:
>
> WARNING: modpost: module mpq8785 uses symbol pmbus_do_probe from namespace PMBUS, but does not import it.
> WARNING: modpost: module mpq8785 uses symbol pmbus_read_byte_data from namespace PMBUS, but does not import it.
>
> Introduced by commit
>
> 7dd62e578cb4 ("hwmon: Add driver for MPS MPQ8785 Synchronous Step-Down Converter")
>
Now fixed up.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 12+ messages in thread
* linux-next: build warnings after merge of the hwmon-staging tree
@ 2022-06-07 4:23 Stephen Rothwell
2022-06-07 9:35 ` Bagas Sanjaya
0 siblings, 1 reply; 12+ messages in thread
From: Stephen Rothwell @ 2022-06-07 4:23 UTC (permalink / raw)
To: Guenter Roeck; +Cc: Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 441 bytes --]
Hi all,
After merging the hwmon-staging tree, today's linux-next build (htmldocs)
produced these warnings:
Documentation/hwmon/lm90.rst:493: WARNING: Bullet list ends without a blank line; unexpected unindent.
Documentation/hwmon/lm90.rst:494: WARNING: Bullet list ends without a blank line; unexpected unindent.
Introduced by commit
7dd47c2603aa ("hwmon: (lm90) Support MAX1617 and LM84")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: linux-next: build warnings after merge of the hwmon-staging tree
2022-06-07 4:23 Stephen Rothwell
@ 2022-06-07 9:35 ` Bagas Sanjaya
2022-06-07 12:39 ` Guenter Roeck
0 siblings, 1 reply; 12+ messages in thread
From: Bagas Sanjaya @ 2022-06-07 9:35 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Guenter Roeck, Linux Kernel Mailing List,
Linux Next Mailing List, linux-doc
On Tue, Jun 07, 2022 at 02:23:01PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the hwmon-staging tree, today's linux-next build (htmldocs)
> produced these warnings:
>
> Documentation/hwmon/lm90.rst:493: WARNING: Bullet list ends without a blank line; unexpected unindent.
> Documentation/hwmon/lm90.rst:494: WARNING: Bullet list ends without a blank line; unexpected unindent.
>
> Introduced by commit
>
> 7dd47c2603aa ("hwmon: (lm90) Support MAX1617 and LM84")
>
Hi Stephen,
These warnings above doesn't appear when doing htmldocs build using
Sphinx installed from pip on my system.
Cc-ing linux-doc list.
Thanks.
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: linux-next: build warnings after merge of the hwmon-staging tree
2022-06-07 9:35 ` Bagas Sanjaya
@ 2022-06-07 12:39 ` Guenter Roeck
0 siblings, 0 replies; 12+ messages in thread
From: Guenter Roeck @ 2022-06-07 12:39 UTC (permalink / raw)
To: Bagas Sanjaya, Stephen Rothwell
Cc: Linux Kernel Mailing List, Linux Next Mailing List, linux-doc
On 6/7/22 02:35, Bagas Sanjaya wrote:
> On Tue, Jun 07, 2022 at 02:23:01PM +1000, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the hwmon-staging tree, today's linux-next build (htmldocs)
>> produced these warnings:
>>
>> Documentation/hwmon/lm90.rst:493: WARNING: Bullet list ends without a blank line; unexpected unindent.
>> Documentation/hwmon/lm90.rst:494: WARNING: Bullet list ends without a blank line; unexpected unindent.
>>
>> Introduced by commit
>>
>> 7dd47c2603aa ("hwmon: (lm90) Support MAX1617 and LM84")
>>
>
> Hi Stephen,
>
> These warnings above doesn't appear when doing htmldocs build using
> Sphinx installed from pip on my system.
>
That is possibly because I already fixed it up (in one place a '-'
instead of '*' had slipped in).
Guenter
^ permalink raw reply [flat|nested] 12+ messages in thread
* linux-next: build warnings after merge of the hwmon-staging tree
@ 2022-06-07 4:19 Stephen Rothwell
2022-06-07 9:37 ` Bagas Sanjaya
0 siblings, 1 reply; 12+ messages in thread
From: Stephen Rothwell @ 2022-06-07 4:19 UTC (permalink / raw)
To: Guenter Roeck; +Cc: Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 2674 bytes --]
Hi all,
After merging the hwmon-staging tree, today's linux-next build (htmldocs)
produced these warnings:
Documentation/hwmon/lt7182s.rst:2: WARNING: Explicit markup ends without a blank line; unexpected unindent.
Documentation/hwmon/lt7182s.rst:75: WARNING: Malformed table.
Text in column margin in table line 33.
====================== ====================================
curr[1-2]_label "iin[12]"
curr[1-2]_input Measured input current
curr[1-2]_max Maximum input current
curr[1-2]_max_alarm Current high alarm
curr[3-4]_label "iout[1-2]"
curr[3-4]_input Measured output current
curr[3-4]_highest Highest measured output current
curr[3-4]_max Maximum output current
curr[3-4]_max_alarm Output current high alarm
in[1-2]_label "vin[12]"
in[1-2]_input Measured input voltage
in[1-2]_highest Highest measured input voltage
in[1-2]_crit Critical maximum input voltage
in[1-2]_crit_alarm Input voltage critical high alarm
in[1-2]_min Minimum input voltage
in[1-2]_min_alarm Input voltage low alarm
in[1-2]_rated_min Rated minimum input voltage
in[1-2]_rated_max Rated maximum input voltage
in1_reset_history Write to reset history for all attributes
in[3-5]_label "vmon[1-3]"
in[3-5]_input Measured voltage on ITH1/ITH2/EXTVCC pins
Only available if enabled with MFR_ADC_CONTROL_LT7182S
command.
in[3-4|6-7]_label "vout[1-2]"
in[3-4|6-7]_input Measured output voltage
in[3-4|6-7]_highest Highest measured output voltage
in[3-4|6-7]_lcrit Critical minimum output voltage
in[3-4|6-7]_lcrit_alarm Output voltage critical low alarm
in[3-4|6-7]_min Minimum output voltage
in[3-4|6-7]_max_alarm Output voltage low alarm
in[3-4|6-7]_max Maximum output voltage
in[3-4|6-7]_max_alarm Output voltage high alarm
in[3-4|6-7]_crit Critical maximum output voltage
in[3-4|6-7]_crit_alarm Output voltage critical high alarm
power[1-2]_label "pout[1-2]"
power[1-2]_input Measured output power
temp1_input Measured temperature
temp1_crit Critical high temperature
temp1_crit_alarm Chip temperature critical high alarm
temp1_max Maximum temperature
temp1_max_alarm Chip temperature high alarm
====================== ====================================
Introduced by commit
3d6bcaa21fbd ("hwmon: (pmbus) Add support for Analog Devices LT7182S")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: linux-next: build warnings after merge of the hwmon-staging tree
2022-06-07 4:19 Stephen Rothwell
@ 2022-06-07 9:37 ` Bagas Sanjaya
2022-06-07 12:40 ` Guenter Roeck
0 siblings, 1 reply; 12+ messages in thread
From: Bagas Sanjaya @ 2022-06-07 9:37 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Guenter Roeck, Linux Kernel Mailing List,
Linux Next Mailing List, linux-doc
On Tue, Jun 07, 2022 at 02:19:58PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the hwmon-staging tree, today's linux-next build (htmldocs)
> produced these warnings:
>
> Documentation/hwmon/lt7182s.rst:2: WARNING: Explicit markup ends without a blank line; unexpected unindent.
> Documentation/hwmon/lt7182s.rst:75: WARNING: Malformed table.
> Text in column margin in table line 33.
>
> ====================== ====================================
> curr[1-2]_label "iin[12]"
> curr[1-2]_input Measured input current
> curr[1-2]_max Maximum input current
> curr[1-2]_max_alarm Current high alarm
>
> curr[3-4]_label "iout[1-2]"
> curr[3-4]_input Measured output current
> curr[3-4]_highest Highest measured output current
> curr[3-4]_max Maximum output current
> curr[3-4]_max_alarm Output current high alarm
>
> in[1-2]_label "vin[12]"
> in[1-2]_input Measured input voltage
> in[1-2]_highest Highest measured input voltage
> in[1-2]_crit Critical maximum input voltage
> in[1-2]_crit_alarm Input voltage critical high alarm
> in[1-2]_min Minimum input voltage
> in[1-2]_min_alarm Input voltage low alarm
> in[1-2]_rated_min Rated minimum input voltage
> in[1-2]_rated_max Rated maximum input voltage
> in1_reset_history Write to reset history for all attributes
>
> in[3-5]_label "vmon[1-3]"
> in[3-5]_input Measured voltage on ITH1/ITH2/EXTVCC pins
> Only available if enabled with MFR_ADC_CONTROL_LT7182S
> command.
>
> in[3-4|6-7]_label "vout[1-2]"
> in[3-4|6-7]_input Measured output voltage
> in[3-4|6-7]_highest Highest measured output voltage
> in[3-4|6-7]_lcrit Critical minimum output voltage
> in[3-4|6-7]_lcrit_alarm Output voltage critical low alarm
> in[3-4|6-7]_min Minimum output voltage
> in[3-4|6-7]_max_alarm Output voltage low alarm
> in[3-4|6-7]_max Maximum output voltage
> in[3-4|6-7]_max_alarm Output voltage high alarm
> in[3-4|6-7]_crit Critical maximum output voltage
> in[3-4|6-7]_crit_alarm Output voltage critical high alarm
>
> power[1-2]_label "pout[1-2]"
> power[1-2]_input Measured output power
>
> temp1_input Measured temperature
> temp1_crit Critical high temperature
> temp1_crit_alarm Chip temperature critical high alarm
> temp1_max Maximum temperature
> temp1_max_alarm Chip temperature high alarm
> ====================== ====================================
>
> Introduced by commit
>
> 3d6bcaa21fbd ("hwmon: (pmbus) Add support for Analog Devices LT7182S")
>
Hi Stephen,
The warning above doesn't appear when doing htmldocs build using Sphinx
installed from pip on my system.
Cc-ing linux-doc list.
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: linux-next: build warnings after merge of the hwmon-staging tree
2022-06-07 9:37 ` Bagas Sanjaya
@ 2022-06-07 12:40 ` Guenter Roeck
0 siblings, 0 replies; 12+ messages in thread
From: Guenter Roeck @ 2022-06-07 12:40 UTC (permalink / raw)
To: Bagas Sanjaya, Stephen Rothwell
Cc: Linux Kernel Mailing List, Linux Next Mailing List, linux-doc
On 6/7/22 02:37, Bagas Sanjaya wrote:
> On Tue, Jun 07, 2022 at 02:19:58PM +1000, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the hwmon-staging tree, today's linux-next build (htmldocs)
>> produced these warnings:
>>
>> Documentation/hwmon/lt7182s.rst:2: WARNING: Explicit markup ends without a blank line; unexpected unindent.
>> Documentation/hwmon/lt7182s.rst:75: WARNING: Malformed table.
>> Text in column margin in table line 33.
>>
>> ====================== ====================================
>> curr[1-2]_label "iin[12]"
>> curr[1-2]_input Measured input current
>> curr[1-2]_max Maximum input current
>> curr[1-2]_max_alarm Current high alarm
>>
>> curr[3-4]_label "iout[1-2]"
>> curr[3-4]_input Measured output current
>> curr[3-4]_highest Highest measured output current
>> curr[3-4]_max Maximum output current
>> curr[3-4]_max_alarm Output current high alarm
>>
>> in[1-2]_label "vin[12]"
>> in[1-2]_input Measured input voltage
>> in[1-2]_highest Highest measured input voltage
>> in[1-2]_crit Critical maximum input voltage
>> in[1-2]_crit_alarm Input voltage critical high alarm
>> in[1-2]_min Minimum input voltage
>> in[1-2]_min_alarm Input voltage low alarm
>> in[1-2]_rated_min Rated minimum input voltage
>> in[1-2]_rated_max Rated maximum input voltage
>> in1_reset_history Write to reset history for all attributes
>>
>> in[3-5]_label "vmon[1-3]"
>> in[3-5]_input Measured voltage on ITH1/ITH2/EXTVCC pins
>> Only available if enabled with MFR_ADC_CONTROL_LT7182S
>> command.
>>
>> in[3-4|6-7]_label "vout[1-2]"
>> in[3-4|6-7]_input Measured output voltage
>> in[3-4|6-7]_highest Highest measured output voltage
>> in[3-4|6-7]_lcrit Critical minimum output voltage
>> in[3-4|6-7]_lcrit_alarm Output voltage critical low alarm
^
>> in[3-4|6-7]_min Minimum output voltage
>> in[3-4|6-7]_max_alarm Output voltage low alarm
>> in[3-4|6-7]_max Maximum output voltage
>> in[3-4|6-7]_max_alarm Output voltage high alarm
>> in[3-4|6-7]_crit Critical maximum output voltage
>> in[3-4|6-7]_crit_alarm Output voltage critical high alarm
>>
>> power[1-2]_label "pout[1-2]"
>> power[1-2]_input Measured output power
>>
>> temp1_input Measured temperature
>> temp1_crit Critical high temperature
>> temp1_crit_alarm Chip temperature critical high alarm
>> temp1_max Maximum temperature
>> temp1_max_alarm Chip temperature high alarm
>> ====================== ====================================
>>
>> Introduced by commit
>>
>> 3d6bcaa21fbd ("hwmon: (pmbus) Add support for Analog Devices LT7182S")
>>
>
> Hi Stephen,
>
> The warning above doesn't appear when doing htmldocs build using Sphinx
> installed from pip on my system.
>
I already fixed it up.
Guenter
^ permalink raw reply [flat|nested] 12+ messages in thread
* linux-next: build warnings after merge of the hwmon-staging tree
@ 2019-06-06 0:32 Stephen Rothwell
0 siblings, 0 replies; 12+ messages in thread
From: Stephen Rothwell @ 2019-06-06 0:32 UTC (permalink / raw)
To: Guenter Roeck
Cc: Linux Next Mailing List, Linux Kernel Mailing List, amy.shih,
Gustavo A. R. Silva, Kees Cook
[-- Attachment #1: Type: text/plain, Size: 1416 bytes --]
Hi all,
After merging the hwmon-staging tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/hwmon/nct7904.c: In function 'nct7904_in_is_visible':
drivers/hwmon/nct7904.c:313:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (channel > 0 && (data->vsen_mask & BIT(index)))
^
drivers/hwmon/nct7904.c:315:2: note: here
case hwmon_in_min:
^~~~
drivers/hwmon/nct7904.c: In function 'nct7904_fan_is_visible':
drivers/hwmon/nct7904.c:230:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (data->fanin_mask & (1 << channel))
^
drivers/hwmon/nct7904.c:232:2: note: here
case hwmon_fan_min:
^~~~
drivers/hwmon/nct7904.c: In function 'nct7904_temp_is_visible':
drivers/hwmon/nct7904.c:443:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (channel < 5) {
^
drivers/hwmon/nct7904.c:450:2: note: here
case hwmon_temp_max:
^~~~
Introduced by commit
af55ab0b0792 ("hwmon: (nct7904) Add extra sysfs support for fan, voltage and temperature.")
I get these warnings because I am building with -Wimplicit-fallthrough
in attempt to catch new additions early. The gcc warning can be turned
off by adding a /* fall through */ comment at the point the fall through
happens (assuming that the fall through is intentional).
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2024-02-05 0:04 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-24 5:22 linux-next: build warnings after merge of the hwmon-staging tree Stephen Rothwell
2021-11-24 6:43 ` [PATCH 1/1] hwmon: Fix warnings in asus_wmi_sensors.rst documetation Denis Pauk
2021-11-24 14:13 ` Guenter Roeck
-- strict thread matches above, loose matches on Subject: below --
2024-02-04 23:41 linux-next: build warnings after merge of the hwmon-staging tree Stephen Rothwell
2024-02-05 0:04 ` Guenter Roeck
2022-06-07 4:23 Stephen Rothwell
2022-06-07 9:35 ` Bagas Sanjaya
2022-06-07 12:39 ` Guenter Roeck
2022-06-07 4:19 Stephen Rothwell
2022-06-07 9:37 ` Bagas Sanjaya
2022-06-07 12:40 ` Guenter Roeck
2019-06-06 0:32 Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).