From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: bchihi@baylibre.com
Cc: rafael@kernel.org, rui.zhang@intel.com,
daniel.lezcano@linaro.org, amitk@kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
khilman@baylibre.com, mka@chromium.org, robh+dt@kernel.org,
krzk+dt@kernel.org, matthias.bgg@gmail.com,
p.zabel@pengutronix.de, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, james.lo@mediatek.com,
fan.chen@mediatek.com, louis.yu@mediatek.com,
rex-bc.chen@mediatek.com, abailon@baylibre.com
Subject: Re: [PATCH v8.1, 1/7] thermal: mediatek: Relocate driver to mediatek folder
Date: Thu, 4 Aug 2022 19:04:07 -0400 [thread overview]
Message-ID: <20220804230407.kwfsxy74qmmebfsj@notapiano> (raw)
In-Reply-To: <20220804130912.676043-2-bchihi@baylibre.com>
Hi Balsam,
On Thu, Aug 04, 2022 at 03:09:06PM +0200, bchihi@baylibre.com wrote:
> From: Michael Kao <michael.kao@mediatek.com>
>
> Add MediaTek proprietary folder to upstream more thermal zone and cooler
> drivers, relocate the original thermal controller driver to it, and rename it
> as "mtxxxx_thermal.c" to show its purpose more clearly.
>
> Signed-off-by: Michael Kao <michael.kao@mediatek.com>
> Signed-off-by: Ben Tseng <ben.tseng@mediatek.com>
> Signed-off-by: Balsam CHIHI <bchihi@baylibre.com>
> ---
> drivers/thermal/Kconfig | 14 ++++-------
> drivers/thermal/Makefile | 2 +-
> drivers/thermal/mediatek/Kconfig | 23 +++++++++++++++++++
> drivers/thermal/mediatek/Makefile | 1 +
> .../mtxxxx_thermal.c} | 2 +-
> 5 files changed, 30 insertions(+), 12 deletions(-)
> create mode 100644 drivers/thermal/mediatek/Kconfig
> create mode 100644 drivers/thermal/mediatek/Makefile
> rename drivers/thermal/{mtk_thermal.c => mediatek/mtxxxx_thermal.c} (99%)
[..]
> --- /dev/null
> +++ b/drivers/thermal/mediatek/Makefile
> @@ -0,0 +1 @@
> +obj-$(CONFIG_MTK_SOC_THERMAL) += mtxxxx_thermal.o
> diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mediatek/mtxxxx_thermal.c
When Daniel suggested using a more SoC explicit name like 'mtxxx_thermal' [1]
the xxxx was supposed to be substituted for the actual SoC (family) that makes
use of this driver :-).
From the compatibles looks like we have mt8173, mt2701, mt2712, mt7622, mt8183.
So it doesn't look like it's a single SoC family... What about calling it
auxadc_thermal?
Thanks,
Nícolas
[1] https://lore.kernel.org/linux-mediatek/24250d03-b25f-e521-5abd-f36109885c36@linaro.org/
> similarity index 99%
> rename from drivers/thermal/mtk_thermal.c
> rename to drivers/thermal/mediatek/mtxxxx_thermal.c
> index ede94eadddda..60924f8f98e9 100644
> --- a/drivers/thermal/mtk_thermal.c
> +++ b/drivers/thermal/mediatek/mtxxxx_thermal.c
> @@ -23,7 +23,7 @@
> #include <linux/reset.h>
> #include <linux/types.h>
>
> -#include "thermal_hwmon.h"
> +#include "../thermal_hwmon.h"
>
> /* AUXADC Registers */
> #define AUXADC_CON1_SET_V 0x008
> --
> 2.34.1
>
>
next prev parent reply other threads:[~2022-08-04 23:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 13:09 [PATCH v8.1, 0/7] Add LVTS architecture thermal bchihi
2022-08-04 13:09 ` [PATCH v8.1, 1/7] thermal: mediatek: Relocate driver to mediatek folder bchihi
2022-08-04 23:04 ` Nícolas F. R. A. Prado [this message]
2022-08-05 11:53 ` Balsam CHIHI
2022-08-04 13:09 ` [PATCH v8.1, 2/7] dt-bindings: thermal: Add binding document for LVTS thermal controllers bchihi
2022-08-04 15:21 ` Krzysztof Kozlowski
2022-08-04 19:50 ` Rob Herring
2022-08-04 23:11 ` Nícolas F. R. A. Prado
2022-08-05 8:48 ` Krzysztof Kozlowski
2022-08-04 13:09 ` [PATCH v8.1, 3/7] arm64: dts: mt8192: Add thermal zone bchihi
2022-08-04 15:23 ` Krzysztof Kozlowski
2022-08-04 23:20 ` Nícolas F. R. A. Prado
2022-08-04 13:09 ` [PATCH v8.1, 4/7] thermal: mediatek: Add LVTS driver for mt8192 thermal zones bchihi
2022-08-04 18:15 ` Randy Dunlap
2022-08-04 23:39 ` Nícolas F. R. A. Prado
2022-08-05 0:00 ` Nícolas F. R. A. Prado
2022-08-04 13:09 ` [PATCH v8.1, 5/7] arm64: dts: mt8195: Add efuse node to mt8195 bchihi
2022-08-04 15:22 ` Krzysztof Kozlowski
2022-08-05 14:55 ` Balsam CHIHI
2022-08-04 13:09 ` [PATCH v8.1, 6/7] arm64: dts: mt8195: Add thermal zone bchihi
2022-08-04 15:22 ` Krzysztof Kozlowski
2022-08-04 13:09 ` [PATCH v8.1, 7/7] thermal: mediatek: Add thermal zone settings for mt8195 bchihi
2022-08-04 23:08 ` [PATCH v8.1, 0/7] Add LVTS architecture thermal Nícolas F. R. A. Prado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220804230407.kwfsxy74qmmebfsj@notapiano \
--to=nfraprado@collabora.com \
--cc=abailon@baylibre.com \
--cc=amitk@kernel.org \
--cc=bchihi@baylibre.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=fan.chen@mediatek.com \
--cc=james.lo@mediatek.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=louis.yu@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=mka@chromium.org \
--cc=p.zabel@pengutronix.de \
--cc=rafael@kernel.org \
--cc=rex-bc.chen@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).