linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: bchihi@baylibre.com
Cc: rafael@kernel.org, rui.zhang@intel.com,
	daniel.lezcano@linaro.org, amitk@kernel.org,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	khilman@baylibre.com, mka@chromium.org, robh+dt@kernel.org,
	krzk+dt@kernel.org, matthias.bgg@gmail.com,
	p.zabel@pengutronix.de, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, james.lo@mediatek.com,
	fan.chen@mediatek.com, louis.yu@mediatek.com,
	rex-bc.chen@mediatek.com, abailon@baylibre.com
Subject: Re: [PATCH v8.1, 4/7] thermal: mediatek: Add LVTS driver for mt8192 thermal zones
Date: Thu, 4 Aug 2022 20:00:03 -0400	[thread overview]
Message-ID: <20220805000003.gljuut3udzed7avz@notapiano> (raw)
In-Reply-To: <20220804130912.676043-5-bchihi@baylibre.com>

Hi Balsam,

another thing.

On Thu, Aug 04, 2022 at 03:09:09PM +0200, bchihi@baylibre.com wrote:
[..]
> --- /dev/null
> +++ b/drivers/thermal/mediatek/lvts_thermal.h
[..]
> +#define ONE_SAMPLE							(lvts_data->counting_window_us + 2 * BUS_ACCESS_US)

This macro is still using a hardcoded variable.

> +#define NUM_OF_SAMPLE(tc_id)				((lvts_data->tc[tc_id].hw_filter < LVTS_FILTER_2) ? \
> +	1 : ((lvts_data->tc[tc_id].hw_filter > LVTS_FILTER_16_OF_18) ? \
> +	1 : ((lvts_data->tc[tc_id].hw_filter == LVTS_FILTER_16_OF_18) ? \
> +	18 : ((lvts_data->tc[tc_id].hw_filter == LVTS_FILTER_8_OF_10) ? \
> +	10 : (lvts_data->tc[tc_id].hw_filter * 2)))))

Ditto.

> +
> +#define PERIOD_UNIT_US(tc_id)		((lvts_data->tc[tc_id].tc_speed->period_unit * 256 * \
> +	CLOCK_26MHZ_CYCLE_NS) / 1000)
> +#define FILTER_INT_US(tc_id)		(lvts_data->tc[tc_id].tc_speed->filter_interval_delay * \
> +	PERIOD_UNIT_US(tc_id))
> +#define SENSOR_INT_US(tc_id)		(lvts_data->tc[tc_id].tc_speed->sensor_interval_delay * \
> +	PERIOD_UNIT_US(tc_id))
> +#define GROUP_INT_US(tc_id)			(lvts_data->tc[tc_id].tc_speed->group_interval_delay * \
> +	PERIOD_UNIT_US(tc_id))

All of these too.

> +#define SENSOR_LATENCY_US(tc_id)	((NUM_OF_SAMPLE(tc_id) - 1) * FILTER_INT_US(tc_id) + \
[..]
> +#define DEVICE_READ				(CK26M_ACTIVE(lvts_data) | DEVICE_ACCESS)

And this.

> +#define DEVICE_WRITE			(CK26M_ACTIVE(lvts_data) | DEVICE_ACCESS | WRITE_ACCESS)

And this.

> +#define RESET_ALL_DEVICES		(DEVICE_WRITE | RG_TSFM_RST << 8 | 0xFF)
> +#define READ_DEVICE_REG(reg_id)	(DEVICE_READ | (reg_id) << 8 | 0x00)
> +#define READ_BACK_DEVICE_ID		(CK26M_ACTIVE(lvts_data) | DEVICE_ACCESS | BROADCAST_ID_UPDATE | \

And finally this one.

I might've have missed some, so please double-check and remove any lingering
hardcoded variable in macros.

Thanks,
Nícolas

> +	RG_DID_LVTS << 8)
[..]

  parent reply	other threads:[~2022-08-05  0:00 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-04 13:09 [PATCH v8.1, 0/7] Add LVTS architecture thermal bchihi
2022-08-04 13:09 ` [PATCH v8.1, 1/7] thermal: mediatek: Relocate driver to mediatek folder bchihi
2022-08-04 23:04   ` Nícolas F. R. A. Prado
2022-08-05 11:53     ` Balsam CHIHI
2022-08-04 13:09 ` [PATCH v8.1, 2/7] dt-bindings: thermal: Add binding document for LVTS thermal controllers bchihi
2022-08-04 15:21   ` Krzysztof Kozlowski
2022-08-04 19:50   ` Rob Herring
2022-08-04 23:11   ` Nícolas F. R. A. Prado
2022-08-05  8:48     ` Krzysztof Kozlowski
2022-08-04 13:09 ` [PATCH v8.1, 3/7] arm64: dts: mt8192: Add thermal zone bchihi
2022-08-04 15:23   ` Krzysztof Kozlowski
2022-08-04 23:20   ` Nícolas F. R. A. Prado
2022-08-04 13:09 ` [PATCH v8.1, 4/7] thermal: mediatek: Add LVTS driver for mt8192 thermal zones bchihi
2022-08-04 18:15   ` Randy Dunlap
2022-08-04 23:39   ` Nícolas F. R. A. Prado
2022-08-05  0:00   ` Nícolas F. R. A. Prado [this message]
2022-08-04 13:09 ` [PATCH v8.1, 5/7] arm64: dts: mt8195: Add efuse node to mt8195 bchihi
2022-08-04 15:22   ` Krzysztof Kozlowski
2022-08-05 14:55     ` Balsam CHIHI
2022-08-04 13:09 ` [PATCH v8.1, 6/7] arm64: dts: mt8195: Add thermal zone bchihi
2022-08-04 15:22   ` Krzysztof Kozlowski
2022-08-04 13:09 ` [PATCH v8.1, 7/7] thermal: mediatek: Add thermal zone settings for mt8195 bchihi
2022-08-04 23:08 ` [PATCH v8.1, 0/7] Add LVTS architecture thermal Nícolas F. R. A. Prado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220805000003.gljuut3udzed7avz@notapiano \
    --to=nfraprado@collabora.com \
    --cc=abailon@baylibre.com \
    --cc=amitk@kernel.org \
    --cc=bchihi@baylibre.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fan.chen@mediatek.com \
    --cc=james.lo@mediatek.com \
    --cc=khilman@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=louis.yu@mediatek.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mka@chromium.org \
    --cc=p.zabel@pengutronix.de \
    --cc=rafael@kernel.org \
    --cc=rex-bc.chen@mediatek.com \
    --cc=robh+dt@kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).