From: Randy Dunlap <rdunlap@infradead.org>
To: bchihi@baylibre.com, rafael@kernel.org, rui.zhang@intel.com,
daniel.lezcano@linaro.org, amitk@kernel.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
khilman@baylibre.com, mka@chromium.org, robh+dt@kernel.org,
krzk+dt@kernel.org, matthias.bgg@gmail.com,
p.zabel@pengutronix.de, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, james.lo@mediatek.com,
fan.chen@mediatek.com, louis.yu@mediatek.com,
rex-bc.chen@mediatek.com, abailon@baylibre.com
Subject: Re: [PATCH v8.1, 4/7] thermal: mediatek: Add LVTS driver for mt8192 thermal zones
Date: Thu, 4 Aug 2022 11:15:38 -0700 [thread overview]
Message-ID: <30e4c6a0-cd8e-5a86-ac25-ac2af5ec53dd@infradead.org> (raw)
In-Reply-To: <20220804130912.676043-5-bchihi@baylibre.com>
Hi--
On 8/4/22 06:09, bchihi@baylibre.com wrote:
> diff --git a/drivers/thermal/mediatek/Kconfig b/drivers/thermal/mediatek/Kconfig
> index 592c849b9fed..afef43a0e7ca 100644
> --- a/drivers/thermal/mediatek/Kconfig
> +++ b/drivers/thermal/mediatek/Kconfig
> @@ -20,4 +20,28 @@ config MTK_SOC_THERMAL
> configures thermal controllers to collect temperature
> via AUXADC interface.
>
> +config MTK_LVTS_THERMAL
> + tristate "LVTS (Low Voltage Thermal Sensor) driver for MediaTek SoCs"
> + depends on HAS_IOMEM
> + depends on NVMEM
> + depends on RESET_CONTROLLER
> + help
> + Enable this option if you want to get SoC temperature
> + information for MediaTek platforms. This driver configures
> + LVTS (Low Voltage Thermal Sensor) thermal controllers to
> + collect temperatures via ASIF (Analog Serial Interface).
> +
> +if MTK_LVTS_THERMAL
> +
> +config MTK_LVTS_V4
> + tristate "LVTS V4 Thermal Driver for MediaTek SoCs"
> + depends on HAS_IOMEM
> + depends on NVMEM
> + depends on RESET_CONTROLLER
You shouldn't need to repeat all of these "depends on" lines since this
Kconfig symbol depends on MTK_LVTS_THERMAL, which already depends on these
3 items.
Have you seen any issue that this is supposed to fix?
> + help
> + Enable this option if you want to get SoC temperature
> + information for LVTS V4.
> +
> +endif
thanks.
--
~Randy
next prev parent reply other threads:[~2022-08-04 18:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 13:09 [PATCH v8.1, 0/7] Add LVTS architecture thermal bchihi
2022-08-04 13:09 ` [PATCH v8.1, 1/7] thermal: mediatek: Relocate driver to mediatek folder bchihi
2022-08-04 23:04 ` Nícolas F. R. A. Prado
2022-08-05 11:53 ` Balsam CHIHI
2022-08-04 13:09 ` [PATCH v8.1, 2/7] dt-bindings: thermal: Add binding document for LVTS thermal controllers bchihi
2022-08-04 15:21 ` Krzysztof Kozlowski
2022-08-04 19:50 ` Rob Herring
2022-08-04 23:11 ` Nícolas F. R. A. Prado
2022-08-05 8:48 ` Krzysztof Kozlowski
2022-08-04 13:09 ` [PATCH v8.1, 3/7] arm64: dts: mt8192: Add thermal zone bchihi
2022-08-04 15:23 ` Krzysztof Kozlowski
2022-08-04 23:20 ` Nícolas F. R. A. Prado
2022-08-04 13:09 ` [PATCH v8.1, 4/7] thermal: mediatek: Add LVTS driver for mt8192 thermal zones bchihi
2022-08-04 18:15 ` Randy Dunlap [this message]
2022-08-04 23:39 ` Nícolas F. R. A. Prado
2022-08-05 0:00 ` Nícolas F. R. A. Prado
2022-08-04 13:09 ` [PATCH v8.1, 5/7] arm64: dts: mt8195: Add efuse node to mt8195 bchihi
2022-08-04 15:22 ` Krzysztof Kozlowski
2022-08-05 14:55 ` Balsam CHIHI
2022-08-04 13:09 ` [PATCH v8.1, 6/7] arm64: dts: mt8195: Add thermal zone bchihi
2022-08-04 15:22 ` Krzysztof Kozlowski
2022-08-04 13:09 ` [PATCH v8.1, 7/7] thermal: mediatek: Add thermal zone settings for mt8195 bchihi
2022-08-04 23:08 ` [PATCH v8.1, 0/7] Add LVTS architecture thermal Nícolas F. R. A. Prado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30e4c6a0-cd8e-5a86-ac25-ac2af5ec53dd@infradead.org \
--to=rdunlap@infradead.org \
--cc=abailon@baylibre.com \
--cc=amitk@kernel.org \
--cc=bchihi@baylibre.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=fan.chen@mediatek.com \
--cc=james.lo@mediatek.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=louis.yu@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=mka@chromium.org \
--cc=p.zabel@pengutronix.de \
--cc=rafael@kernel.org \
--cc=rex-bc.chen@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).