From: Marcos Paulo de Souza <mpdesouza@suse.com>
To: linux-kernel@vger.kernel.org, live-patching@vger.kernel.org
Cc: jpoimboe@redhat.com, joe.lawrence@redhat.com, pmladek@suse.com,
Marcos Paulo de Souza <mpdesouza@suse.com>
Subject: [PATCH v2 2/4] livepatch/shadow: Separate code removing all shadow variables for a given id
Date: Wed, 26 Oct 2022 16:41:20 -0300 [thread overview]
Message-ID: <20221026194122.11761-3-mpdesouza@suse.com> (raw)
In-Reply-To: <20221026194122.11761-1-mpdesouza@suse.com>
From: Petr Mladek <pmladek@suse.com>
Allow to remove all shadow variables with already taken klp_shadow_lock.
It will be needed to synchronize this with other operation during
the garbage collection of shadow variables.
It is a code refactoring without any functional changes.
Signed-off-by: Petr Mladek <pmladek@suse.com>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
---
Changes from v1:
* Added my SoB (Josh)
kernel/livepatch/shadow.c | 24 +++++++++++++++---------
1 file changed, 15 insertions(+), 9 deletions(-)
diff --git a/kernel/livepatch/shadow.c b/kernel/livepatch/shadow.c
index 81ad7cbbd124..aba44dcc0a88 100644
--- a/kernel/livepatch/shadow.c
+++ b/kernel/livepatch/shadow.c
@@ -283,6 +283,20 @@ void klp_shadow_free(void *obj, unsigned long id, klp_shadow_dtor_t dtor)
}
EXPORT_SYMBOL_GPL(klp_shadow_free);
+static void __klp_shadow_free_all(unsigned long id, klp_shadow_dtor_t dtor)
+{
+ struct klp_shadow *shadow;
+ int i;
+
+ lockdep_assert_held(&klp_shadow_lock);
+
+ /* Delete all <*, id> from hash */
+ hash_for_each(klp_shadow_hash, i, shadow, node) {
+ if (klp_shadow_match(shadow, shadow->obj, id))
+ klp_shadow_free_struct(shadow, dtor);
+ }
+}
+
/**
* klp_shadow_free_all() - detach and free all <_, id> shadow variables
* @id: data identifier
@@ -294,18 +308,10 @@ EXPORT_SYMBOL_GPL(klp_shadow_free);
*/
void klp_shadow_free_all(unsigned long id, klp_shadow_dtor_t dtor)
{
- struct klp_shadow *shadow;
unsigned long flags;
- int i;
spin_lock_irqsave(&klp_shadow_lock, flags);
-
- /* Delete all <_, id> from hash */
- hash_for_each(klp_shadow_hash, i, shadow, node) {
- if (klp_shadow_match(shadow, shadow->obj, id))
- klp_shadow_free_struct(shadow, dtor);
- }
-
+ __klp_shadow_free_all(id, dtor);
spin_unlock_irqrestore(&klp_shadow_lock, flags);
}
EXPORT_SYMBOL_GPL(klp_shadow_free_all);
--
2.37.3
next prev parent reply other threads:[~2022-10-26 19:41 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 19:41 [PATCH v2 0/4] livepatch: Add garbage collection for shadow variables Marcos Paulo de Souza
2022-10-26 19:41 ` [PATCH v2 1/4] livepatch/shadow: Separate code to get or use pre-allocated shadow variable Marcos Paulo de Souza
2022-10-31 15:44 ` Petr Mladek
2022-10-26 19:41 ` Marcos Paulo de Souza [this message]
2022-10-26 19:41 ` [PATCH v2 3/4] livepatch/shadow: Introduce klp_shadow_type structure Marcos Paulo de Souza
2022-10-31 16:02 ` Petr Mladek
2023-01-31 4:36 ` Josh Poimboeuf
2022-10-26 19:41 ` [PATCH v2 4/4] livepatch/shadow: Add garbage collection of shadow variables Marcos Paulo de Souza
2022-11-04 1:03 ` Josh Poimboeuf
2022-11-04 10:25 ` Petr Mladek
2022-11-08 1:32 ` Josh Poimboeuf
2022-11-08 9:14 ` Petr Mladek
2022-11-08 18:44 ` Josh Poimboeuf
2022-11-09 14:36 ` Petr Mladek
2023-02-04 23:59 ` Josh Poimboeuf
2023-02-17 16:22 ` Petr Mladek
2022-11-11 9:20 ` Nicolai Stange
2022-11-11 9:55 ` Petr Mladek
2022-11-13 18:51 ` Josh Poimboeuf
2023-01-17 15:01 ` Petr Mladek
2023-01-25 23:22 ` Josh Poimboeuf
2023-01-26 9:36 ` Petr Mladek
2023-02-04 19:34 ` Josh Poimboeuf
2023-01-31 4:40 ` Josh Poimboeuf
2023-01-31 14:23 ` Petr Mladek
2023-01-31 21:17 ` Josh Poimboeuf
2023-02-02 13:58 ` Petr Mladek
2023-02-01 0:18 ` Josh Poimboeuf
2023-02-02 10:14 ` Petr Mladek
2023-02-04 17:37 ` Josh Poimboeuf
2022-11-01 10:43 ` [PATCH v2 0/4] livepatch: Add garbage collection for " Petr Mladek
2023-01-23 17:33 ` Marcos Paulo de Souza
2023-01-24 15:51 ` Petr Mladek
2023-01-26 16:35 ` Petr Mladek
2023-01-26 17:05 ` Joe Lawrence
2023-01-26 18:30 ` Josh Poimboeuf
2023-01-27 10:51 ` Petr Mladek
2023-01-27 11:08 ` Marcos Paulo de Souza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221026194122.11761-3-mpdesouza@suse.com \
--to=mpdesouza@suse.com \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).