From: Petr Mladek <pmladek@suse.com>
To: Marcos Paulo de Souza <mpdesouza@suse.de>
Cc: Marcos Paulo de Souza <mpdesouza@suse.com>,
linux-kernel@vger.kernel.org, live-patching@vger.kernel.org,
jpoimboe@redhat.com, joe.lawrence@redhat.com
Subject: Re: [PATCH v2 0/4] livepatch: Add garbage collection for shadow variables
Date: Thu, 26 Jan 2023 17:35:42 +0100 [thread overview]
Message-ID: <Y9Kr3vb2s3m0MbEQ@alley> (raw)
In-Reply-To: <Y8/+bGqjHsi8LEfI@alley>
On Tue 2023-01-24 16:51:08, Petr Mladek wrote:
> On Mon 2023-01-23 14:33:31, Marcos Paulo de Souza wrote:
> > On Tue, Nov 01, 2022 at 11:43:50AM +0100, Petr Mladek wrote:
> > > On Wed 2022-10-26 16:41:18, Marcos Paulo de Souza wrote:
> > > > Hello,
> > > >
> > > > This is the v2 of the livepatch shadow GC patches. The changes are minor since
> > > > nobody asked for for big code changes.
> > > >
> > > > Changes from v1:
> > > > * Reworked commit messages (Petr)
> > > > * Added my SoB which was missing in some patches, or the ordering was wrong. (Josh)
> > > > * Change __klp_shadow_get_or_use to __klp_shadow_get_or_add_locked and add a comment (Petr)
> > > > * Add lockdep_assert_held on __klp_shadow_get_or_add_locked (Petr)
> > > > about it's meaning (Petr)
> > > > * CCing LKML (Josh)
> > > >
> > > > Some observations:
> > > > * Petr has reviewed some of the patches that we created. I kept the Reviewed-by
> > > > tags since he wrote the patches some time ago and now he reviewed them again
> > > > on the ML.
> > > > * There were questions about possible problems about using klp_shadow_types
> > > > instead of using ids, but Petr already explained that internally it still uses
> > > > the id to find the correct livepatch.
> > > > * Regarding the possibility of multiple patches use the same ID, the problem
> > > > already existed before. Petr suggested using a "stringified" version using
> > > > name and id, but nobody has commented yet. I can implement such feature in a
> > > > v3 if necessary.
> > > >
> > > > Marcos Paulo de Souza (2):
> > > > livepatch/shadow: Introduce klp_shadow_type structure
> > > > livepatch/shadow: Add garbage collection of shadow variables
> > > >
> > > > Petr Mladek (2):
> > > > livepatch/shadow: Separate code to get or use pre-allocated shadow
> > > > variable
> > > > livepatch/shadow: Separate code removing all shadow variables for a
> > > > given id
> > >
> > > From my POV, the patchset is ready for pushing upstream.
> >
> > Petr, what do you think about merging the first two patches, since they just
> > cleanups and simplifications?
>
> Sounds reasonable to me. I am going to push them by the end of the
> week if nobody complained in the meantime.
Josh accepted the idea in the end so we could actually push the entire
patchset. I am not sure if anyone else would like to review it
so I going to wait a bit longer.
Resume:
I am going to push the entire patchset the following week (Wednesday?)
unless anyone asks for more time or finds a problem.
Best Regards,
Petr
next prev parent reply other threads:[~2023-01-26 16:35 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 19:41 [PATCH v2 0/4] livepatch: Add garbage collection for shadow variables Marcos Paulo de Souza
2022-10-26 19:41 ` [PATCH v2 1/4] livepatch/shadow: Separate code to get or use pre-allocated shadow variable Marcos Paulo de Souza
2022-10-31 15:44 ` Petr Mladek
2022-10-26 19:41 ` [PATCH v2 2/4] livepatch/shadow: Separate code removing all shadow variables for a given id Marcos Paulo de Souza
2022-10-26 19:41 ` [PATCH v2 3/4] livepatch/shadow: Introduce klp_shadow_type structure Marcos Paulo de Souza
2022-10-31 16:02 ` Petr Mladek
2023-01-31 4:36 ` Josh Poimboeuf
2022-10-26 19:41 ` [PATCH v2 4/4] livepatch/shadow: Add garbage collection of shadow variables Marcos Paulo de Souza
2022-11-04 1:03 ` Josh Poimboeuf
2022-11-04 10:25 ` Petr Mladek
2022-11-08 1:32 ` Josh Poimboeuf
2022-11-08 9:14 ` Petr Mladek
2022-11-08 18:44 ` Josh Poimboeuf
2022-11-09 14:36 ` Petr Mladek
2023-02-04 23:59 ` Josh Poimboeuf
2023-02-17 16:22 ` Petr Mladek
2022-11-11 9:20 ` Nicolai Stange
2022-11-11 9:55 ` Petr Mladek
2022-11-13 18:51 ` Josh Poimboeuf
2023-01-17 15:01 ` Petr Mladek
2023-01-25 23:22 ` Josh Poimboeuf
2023-01-26 9:36 ` Petr Mladek
2023-02-04 19:34 ` Josh Poimboeuf
2023-01-31 4:40 ` Josh Poimboeuf
2023-01-31 14:23 ` Petr Mladek
2023-01-31 21:17 ` Josh Poimboeuf
2023-02-02 13:58 ` Petr Mladek
2023-02-01 0:18 ` Josh Poimboeuf
2023-02-02 10:14 ` Petr Mladek
2023-02-04 17:37 ` Josh Poimboeuf
2022-11-01 10:43 ` [PATCH v2 0/4] livepatch: Add garbage collection for " Petr Mladek
2023-01-23 17:33 ` Marcos Paulo de Souza
2023-01-24 15:51 ` Petr Mladek
2023-01-26 16:35 ` Petr Mladek [this message]
2023-01-26 17:05 ` Joe Lawrence
2023-01-26 18:30 ` Josh Poimboeuf
2023-01-27 10:51 ` Petr Mladek
2023-01-27 11:08 ` Marcos Paulo de Souza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9Kr3vb2s3m0MbEQ@alley \
--to=pmladek@suse.com \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mpdesouza@suse.com \
--cc=mpdesouza@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).