* Re: [PATCH] sctp: Remove some redundant code
2016-09-04 9:38 [PATCH] sctp: Remove some redundant code Christophe JAILLET
@ 2016-09-05 12:40 ` marcelo.leitner
2016-09-05 23:48 ` marcelo.leitner
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: marcelo.leitner @ 2016-09-05 12:40 UTC (permalink / raw)
To: Christophe JAILLET
Cc: vyasevich, nhorman, davem, linux-sctp, linux-kernel, kernel-janitors
On Sun, Sep 04, 2016 at 11:38:13AM +0200, Christophe JAILLET wrote:
> In commit 311b21774f13 ("sctp: simplify sk_receive_queue locking"), a call
> to 'skb_queue_splice_tail_init()' has been made explicit. Previously it was
> hidden in 'sctp_skb_list_tail()'
>
> Now, the code around it looks redundant. The '_init()' part of
> 'skb_queue_splice_tail_init()' should alreday do the same.
Nice
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Un-tested
Okay. It seems good to me but I'll give this a run after lunch anyway.
Thanks
> ---
> net/sctp/ulpqueue.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/net/sctp/ulpqueue.c b/net/sctp/ulpqueue.c
> index 877e55066f89..84d0fdaf7de9 100644
> --- a/net/sctp/ulpqueue.c
> +++ b/net/sctp/ulpqueue.c
> @@ -140,11 +140,8 @@ int sctp_clear_pd(struct sock *sk, struct sctp_association *asoc)
> * we can go ahead and clear out the lobby in one shot
> */
> if (!skb_queue_empty(&sp->pd_lobby)) {
> - struct list_head *list;
> skb_queue_splice_tail_init(&sp->pd_lobby,
> &sk->sk_receive_queue);
> - list = (struct list_head *)&sctp_sk(sk)->pd_lobby;
> - INIT_LIST_HEAD(list);
> return 1;
> }
> } else {
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] sctp: Remove some redundant code
2016-09-04 9:38 [PATCH] sctp: Remove some redundant code Christophe JAILLET
2016-09-05 12:40 ` marcelo.leitner
@ 2016-09-05 23:48 ` marcelo.leitner
2016-09-07 15:19 ` Neil Horman
2016-09-15 17:34 ` Marcelo
3 siblings, 0 replies; 7+ messages in thread
From: marcelo.leitner @ 2016-09-05 23:48 UTC (permalink / raw)
To: Christophe JAILLET
Cc: vyasevich, nhorman, davem, linux-sctp, linux-kernel, kernel-janitors
On Sun, Sep 04, 2016 at 11:38:13AM +0200, Christophe JAILLET wrote:
> In commit 311b21774f13 ("sctp: simplify sk_receive_queue locking"), a call
> to 'skb_queue_splice_tail_init()' has been made explicit. Previously it was
> hidden in 'sctp_skb_list_tail()'
>
> Now, the code around it looks redundant. The '_init()' part of
> 'skb_queue_splice_tail_init()' should alreday do the same.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Un-tested
Tested here with some netperf combinations, seems good.
Thanks
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
> ---
> net/sctp/ulpqueue.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/net/sctp/ulpqueue.c b/net/sctp/ulpqueue.c
> index 877e55066f89..84d0fdaf7de9 100644
> --- a/net/sctp/ulpqueue.c
> +++ b/net/sctp/ulpqueue.c
> @@ -140,11 +140,8 @@ int sctp_clear_pd(struct sock *sk, struct sctp_association *asoc)
> * we can go ahead and clear out the lobby in one shot
> */
> if (!skb_queue_empty(&sp->pd_lobby)) {
> - struct list_head *list;
> skb_queue_splice_tail_init(&sp->pd_lobby,
> &sk->sk_receive_queue);
> - list = (struct list_head *)&sctp_sk(sk)->pd_lobby;
> - INIT_LIST_HEAD(list);
> return 1;
> }
> } else {
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] sctp: Remove some redundant code
2016-09-04 9:38 [PATCH] sctp: Remove some redundant code Christophe JAILLET
2016-09-05 12:40 ` marcelo.leitner
2016-09-05 23:48 ` marcelo.leitner
@ 2016-09-07 15:19 ` Neil Horman
2016-09-15 17:34 ` Marcelo
3 siblings, 0 replies; 7+ messages in thread
From: Neil Horman @ 2016-09-07 15:19 UTC (permalink / raw)
To: Christophe JAILLET
Cc: marcelo.leitner, vyasevich, davem, linux-sctp, linux-kernel,
kernel-janitors
On Sun, Sep 04, 2016 at 11:38:13AM +0200, Christophe JAILLET wrote:
> In commit 311b21774f13 ("sctp: simplify sk_receive_queue locking"), a call
> to 'skb_queue_splice_tail_init()' has been made explicit. Previously it was
> hidden in 'sctp_skb_list_tail()'
>
> Now, the code around it looks redundant. The '_init()' part of
> 'skb_queue_splice_tail_init()' should alreday do the same.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Un-tested
> ---
> net/sctp/ulpqueue.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/net/sctp/ulpqueue.c b/net/sctp/ulpqueue.c
> index 877e55066f89..84d0fdaf7de9 100644
> --- a/net/sctp/ulpqueue.c
> +++ b/net/sctp/ulpqueue.c
> @@ -140,11 +140,8 @@ int sctp_clear_pd(struct sock *sk, struct sctp_association *asoc)
> * we can go ahead and clear out the lobby in one shot
> */
> if (!skb_queue_empty(&sp->pd_lobby)) {
> - struct list_head *list;
> skb_queue_splice_tail_init(&sp->pd_lobby,
> &sk->sk_receive_queue);
> - list = (struct list_head *)&sctp_sk(sk)->pd_lobby;
> - INIT_LIST_HEAD(list);
> return 1;
> }
> } else {
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] sctp: Remove some redundant code
2016-09-04 9:38 [PATCH] sctp: Remove some redundant code Christophe JAILLET
` (2 preceding siblings ...)
2016-09-07 15:19 ` Neil Horman
@ 2016-09-15 17:34 ` Marcelo
2016-09-15 19:32 ` Christophe JAILLET
3 siblings, 1 reply; 7+ messages in thread
From: Marcelo @ 2016-09-15 17:34 UTC (permalink / raw)
To: Christophe JAILLET
Cc: vyasevich, nhorman, davem, linux-sctp, linux-kernel, kernel-janitors
On Sun, Sep 04, 2016 at 11:38:13AM +0200, Christophe JAILLET wrote:
> In commit 311b21774f13 ("sctp: simplify sk_receive_queue locking"), a call
> to 'skb_queue_splice_tail_init()' has been made explicit. Previously it was
> hidden in 'sctp_skb_list_tail()'
>
> Now, the code around it looks redundant. The '_init()' part of
> 'skb_queue_splice_tail_init()' should alreday do the same.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
I just noticed you didn't include netdev@ in the destinations.
Is your patch going to be tracked somewhere else? It's not showing up in
http://patchwork.ozlabs.org/project/netdev/list/?submitter=66309&state=*&q=&archive=&delegate=
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] sctp: Remove some redundant code
2016-09-15 17:34 ` Marcelo
@ 2016-09-15 19:32 ` Christophe JAILLET
2016-09-15 20:19 ` Marcelo
0 siblings, 1 reply; 7+ messages in thread
From: Christophe JAILLET @ 2016-09-15 19:32 UTC (permalink / raw)
To: Marcelo
Cc: vyasevich, nhorman, davem, linux-sctp, linux-kernel, kernel-janitors
Le 15/09/2016 à 19:34, Marcelo a écrit :
> On Sun, Sep 04, 2016 at 11:38:13AM +0200, Christophe JAILLET wrote:
>> In commit 311b21774f13 ("sctp: simplify sk_receive_queue locking"), a call
>> to 'skb_queue_splice_tail_init()' has been made explicit. Previously it was
>> hidden in 'sctp_skb_list_tail()'
>>
>> Now, the code around it looks redundant. The '_init()' part of
>> 'skb_queue_splice_tail_init()' should alreday do the same.
>>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> I just noticed you didn't include netdev@ in the destinations.
>
> Is your patch going to be tracked somewhere else? It's not showing up in
> http://patchwork.ozlabs.org/project/netdev/list/?submitter=66309&state=*&q=&archive=&delegate=
>
My fault, get_maintainer lists netdev@ but I missed it.
Should I resubmit or is it ok?
CJ
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] sctp: Remove some redundant code
2016-09-15 19:32 ` Christophe JAILLET
@ 2016-09-15 20:19 ` Marcelo
0 siblings, 0 replies; 7+ messages in thread
From: Marcelo @ 2016-09-15 20:19 UTC (permalink / raw)
To: Christophe JAILLET
Cc: vyasevich, nhorman, davem, linux-sctp, linux-kernel, kernel-janitors
On Thu, Sep 15, 2016 at 09:32:18PM +0200, Christophe JAILLET wrote:
> Le 15/09/2016 à 19:34, Marcelo a écrit :
> > On Sun, Sep 04, 2016 at 11:38:13AM +0200, Christophe JAILLET wrote:
> > > In commit 311b21774f13 ("sctp: simplify sk_receive_queue locking"), a call
> > > to 'skb_queue_splice_tail_init()' has been made explicit. Previously it was
> > > hidden in 'sctp_skb_list_tail()'
> > >
> > > Now, the code around it looks redundant. The '_init()' part of
> > > 'skb_queue_splice_tail_init()' should alreday do the same.
> > >
> > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > I just noticed you didn't include netdev@ in the destinations.
> >
> > Is your patch going to be tracked somewhere else? It's not showing up in
> > http://patchwork.ozlabs.org/project/netdev/list/?submitter=66309&state=*&q=&archive=&delegate=
> >
> My fault, get_maintainer lists netdev@ but I missed it.
>
> Should I resubmit or is it ok?
I guess you need to resubmit then, as it's not showing up in patchwork.
Marcelo
^ permalink raw reply [flat|nested] 7+ messages in thread