From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux Trace Devel <linux-trace-devel@vger.kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Christian Brauner <brauner@kernel.org>,
Ajay Kaher <ajay.kaher@broadcom.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] eventfs: Have inodes have unique inode numbers
Date: Mon, 29 Jan 2024 11:00:04 -0500 [thread overview]
Message-ID: <3120f1f0-eaf8-4058-9a65-bdbee28c68c9@efficios.com> (raw)
In-Reply-To: <CAHk-=wjpyv+fhxzV+XEQgsC+-HaouKT7Ns8qT31jkpN_Jm84_g@mail.gmail.com>
On 2024-01-26 17:49, Linus Torvalds wrote:
> On Fri, 26 Jan 2024 at 14:41, Mathieu Desnoyers
> <mathieu.desnoyers@efficios.com> wrote:
>>
>> Yes, there is even a note about stat.st_size in inode(7) explaining
>> this:
>
> Good. Send a patch to do the same for st_ino.
This breaks "cp -aH" and "cp -aL". Even setting st_nlink={0,1}
does not help there, from coreutils 9.1:
copy_internal():
[...]
else if (x->preserve_links
&& !x->hard_link
&& (1 < src_sb.st_nlink
|| (command_line_arg
&& x->dereference == DEREF_COMMAND_LINE_ARGUMENTS)
|| x->dereference == DEREF_ALWAYS))
{
earlier_file = remember_copied (dst_relname,
src_sb.st_ino, src_sb.st_dev);
}
Thanks,
Mathieu
--
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com
next prev parent reply other threads:[~2024-01-29 16:00 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 20:02 [PATCH] eventfs: Have inodes have unique inode numbers Steven Rostedt
2024-01-26 20:25 ` Linus Torvalds
2024-01-26 21:26 ` Steven Rostedt
2024-01-26 21:31 ` Linus Torvalds
2024-01-26 21:43 ` Steven Rostedt
2024-01-26 21:36 ` Linus Torvalds
2024-01-26 21:42 ` Steven Rostedt
2024-01-26 21:49 ` Linus Torvalds
2024-01-26 22:08 ` Steven Rostedt
2024-01-26 22:26 ` Linus Torvalds
2024-01-27 14:47 ` Steven Rostedt
2024-01-28 14:42 ` Steven Rostedt
2024-01-26 22:14 ` Mathieu Desnoyers
2024-01-26 22:29 ` Linus Torvalds
2024-01-26 22:41 ` Mathieu Desnoyers
2024-01-26 22:49 ` Linus Torvalds
2024-01-29 16:00 ` Mathieu Desnoyers [this message]
2024-01-29 18:58 ` Linus Torvalds
2024-01-26 22:34 ` Matthew Wilcox
2024-01-26 22:40 ` Mathieu Desnoyers
2024-01-26 22:48 ` Linus Torvalds
2024-01-26 23:04 ` Matthew Wilcox
2024-01-26 23:11 ` Linus Torvalds
2024-01-26 23:17 ` Linus Torvalds
2024-01-27 9:36 ` Andreas Schwab
2024-01-27 21:47 ` Linus Torvalds
2024-01-28 20:15 ` Steven Rostedt
2024-01-28 20:53 ` Linus Torvalds
2024-01-28 21:08 ` Linus Torvalds
2024-01-28 22:01 ` Steven Rostedt
2024-01-28 22:17 ` Linus Torvalds
2024-01-28 22:26 ` Steven Rostedt
2024-01-28 21:11 ` Steven Rostedt
2024-01-28 21:19 ` Steven Rostedt
2024-01-28 21:43 ` Linus Torvalds
2024-01-28 22:07 ` Linus Torvalds
2024-01-28 22:17 ` Steven Rostedt
2024-01-28 22:25 ` Linus Torvalds
2024-01-28 22:51 ` Steven Rostedt
2024-01-28 23:24 ` Linus Torvalds
2024-01-28 23:59 ` Steven Rostedt
2024-01-29 0:21 ` Steven Rostedt
2024-01-29 1:00 ` Linus Torvalds
2024-01-29 1:42 ` Linus Torvalds
2024-01-29 2:32 ` Steven Rostedt
2024-01-29 3:40 ` Steven Rostedt
2024-01-29 4:01 ` Linus Torvalds
2024-01-29 2:09 ` Steven Rostedt
2024-01-29 6:44 ` Amir Goldstein
2024-01-29 9:32 ` Steven Rostedt
2024-01-27 15:26 ` David Laight
2024-01-27 20:01 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3120f1f0-eaf8-4058-9a65-bdbee28c68c9@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=ajay.kaher@broadcom.com \
--cc=brauner@kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).