* [PATCH net-next] net: dsa: select NET_SWITCHDEV
@ 2017-01-08 23:17 Vivien Didelot
2017-01-08 23:31 ` Andrew Lunn
2017-01-09 1:18 ` Florian Fainelli
0 siblings, 2 replies; 6+ messages in thread
From: Vivien Didelot @ 2017-01-08 23:17 UTC (permalink / raw)
To: netdev
Cc: linux-kernel, kernel, David S. Miller, Florian Fainelli,
Andrew Lunn, Jiri Pirko, Vivien Didelot
DSA wraps SWITCHDEV, thus select it instead of depending on it.
Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
---
net/dsa/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/dsa/Kconfig b/net/dsa/Kconfig
index 2ae9bb357523..675acbf1502d 100644
--- a/net/dsa/Kconfig
+++ b/net/dsa/Kconfig
@@ -6,7 +6,8 @@ config HAVE_NET_DSA
config NET_DSA
tristate "Distributed Switch Architecture"
- depends on HAVE_NET_DSA && NET_SWITCHDEV
+ depends on HAVE_NET_DSA
+ select NET_SWITCHDEV
select PHYLIB
---help---
Say Y if you want to enable support for the hardware switches supported
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net: dsa: select NET_SWITCHDEV
2017-01-08 23:17 [PATCH net-next] net: dsa: select NET_SWITCHDEV Vivien Didelot
@ 2017-01-08 23:31 ` Andrew Lunn
2017-01-09 1:18 ` Florian Fainelli
1 sibling, 0 replies; 6+ messages in thread
From: Andrew Lunn @ 2017-01-08 23:31 UTC (permalink / raw)
To: Vivien Didelot
Cc: netdev, linux-kernel, kernel, David S. Miller, Florian Fainelli,
Jiri Pirko
On Sun, Jan 08, 2017 at 06:17:24PM -0500, Vivien Didelot wrote:
> DSA wraps SWITCHDEV, thus select it instead of depending on it.
>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net-next] net: dsa: select NET_SWITCHDEV
2017-01-08 23:17 [PATCH net-next] net: dsa: select NET_SWITCHDEV Vivien Didelot
2017-01-08 23:31 ` Andrew Lunn
@ 2017-01-09 1:18 ` Florian Fainelli
2017-01-09 1:32 ` Randy Dunlap
1 sibling, 1 reply; 6+ messages in thread
From: Florian Fainelli @ 2017-01-09 1:18 UTC (permalink / raw)
To: Vivien Didelot, netdev
Cc: linux-kernel, kernel, David S. Miller, Andrew Lunn, Jiri Pirko
On 01/08/2017 03:17 PM, Vivien Didelot wrote:
> DSA wraps SWITCHDEV, thus select it instead of depending on it.
>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net: dsa: select NET_SWITCHDEV
2017-01-09 1:18 ` Florian Fainelli
@ 2017-01-09 1:32 ` Randy Dunlap
2017-01-09 16:32 ` Vivien Didelot
0 siblings, 1 reply; 6+ messages in thread
From: Randy Dunlap @ 2017-01-09 1:32 UTC (permalink / raw)
To: Florian Fainelli, Vivien Didelot, netdev
Cc: linux-kernel, kernel, David S. Miller, Andrew Lunn, Jiri Pirko
On 01/08/17 17:18, Florian Fainelli wrote:
> On 01/08/2017 03:17 PM, Vivien Didelot wrote:
>> DSA wraps SWITCHDEV, thus select it instead of depending on it.
>>
>> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
>
but when CONFIG_INET is not enabled, the patch causes this warning:
warning: (NET_DSA) selects NET_SWITCHDEV which has unmet direct dependencies (NET && INET)
--
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net: dsa: select NET_SWITCHDEV
2017-01-09 1:32 ` Randy Dunlap
@ 2017-01-09 16:32 ` Vivien Didelot
2017-01-09 16:47 ` Randy Dunlap
0 siblings, 1 reply; 6+ messages in thread
From: Vivien Didelot @ 2017-01-09 16:32 UTC (permalink / raw)
To: Randy Dunlap, Florian Fainelli, netdev
Cc: linux-kernel, kernel, David S. Miller, Andrew Lunn, Jiri Pirko
Hi Randy,
Randy Dunlap <rdunlap@infradead.org> writes:
> On 01/08/17 17:18, Florian Fainelli wrote:
>> On 01/08/2017 03:17 PM, Vivien Didelot wrote:
>>> DSA wraps SWITCHDEV, thus select it instead of depending on it.
>>>
>>> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
>>
>> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
>>
>
> but when CONFIG_INET is not enabled, the patch causes this warning:
>
> warning: (NET_DSA) selects NET_SWITCHDEV which has unmet direct dependencies (NET && INET)
Thanks for spotting that! Would that be enough to change this first?
diff --git a/net/dsa/Kconfig b/net/dsa/Kconfig
index 675acbf1502d..c7263b70e72b 100644
--- a/net/dsa/Kconfig
+++ b/net/dsa/Kconfig
@@ -1,6 +1,6 @@
config HAVE_NET_DSA
def_bool y
- depends on NETDEVICES && !S390
+ depends on INET && NETDEVICES && !S390
# Drivers must select NET_DSA and the appropriate tagging format
Thanks,
Vivien
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net-next] net: dsa: select NET_SWITCHDEV
2017-01-09 16:32 ` Vivien Didelot
@ 2017-01-09 16:47 ` Randy Dunlap
0 siblings, 0 replies; 6+ messages in thread
From: Randy Dunlap @ 2017-01-09 16:47 UTC (permalink / raw)
To: Vivien Didelot, Florian Fainelli, netdev
Cc: linux-kernel, kernel, David S. Miller, Andrew Lunn, Jiri Pirko
On 01/09/17 08:32, Vivien Didelot wrote:
> Hi Randy,
>
> Randy Dunlap <rdunlap@infradead.org> writes:
>
>> On 01/08/17 17:18, Florian Fainelli wrote:
>>> On 01/08/2017 03:17 PM, Vivien Didelot wrote:
>>>> DSA wraps SWITCHDEV, thus select it instead of depending on it.
>>>>
>>>> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
>>>
>>> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
>>>
>>
>> but when CONFIG_INET is not enabled, the patch causes this warning:
>>
>> warning: (NET_DSA) selects NET_SWITCHDEV which has unmet direct dependencies (NET && INET)
>
> Thanks for spotting that! Would that be enough to change this first?
>
> diff --git a/net/dsa/Kconfig b/net/dsa/Kconfig
> index 675acbf1502d..c7263b70e72b 100644
> --- a/net/dsa/Kconfig
> +++ b/net/dsa/Kconfig
> @@ -1,6 +1,6 @@
> config HAVE_NET_DSA
> def_bool y
> - depends on NETDEVICES && !S390
> + depends on INET && NETDEVICES && !S390
>
> # Drivers must select NET_DSA and the appropriate tagging format
Yes, thanks.
Tested-by: Randy Dunlap <rdunlap@infradead.org>
--
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-01-09 16:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-08 23:17 [PATCH net-next] net: dsa: select NET_SWITCHDEV Vivien Didelot
2017-01-08 23:31 ` Andrew Lunn
2017-01-09 1:18 ` Florian Fainelli
2017-01-09 1:32 ` Randy Dunlap
2017-01-09 16:32 ` Vivien Didelot
2017-01-09 16:47 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).