[PATCH] sound: sscape: add missing include of asm/io.h

[PATCH] sound: sscape: add missing include of asm/io.h

[Arnd Bergmann]

The soundscape driver uses the ISA inb/outb functions declared
in asm/io.h, so it needs to include this header to avoid
a build error:

sscape.c: In function 'sscape_write_unsafe':
sscape.c:203:2: error: implicit declaration of function 'outb' [-Werror=implicit-function-declaration]

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

diff --git a/sound/isa/sscape.c b/sound/isa/sscape.c
index 018ab140c2be..7b248cdf06e2 100644
--- a/sound/isa/sscape.c
+++ b/sound/isa/sscape.c
@@ -23,6 +23,7 @@
 
 #include <linux/init.h>
 #include <linux/err.h>
+#include <linux/io.h>
 #include <linux/isa.h>
 #include <linux/delay.h>
 #include <linux/firmware.h>

Re: [PATCH] sound: sscape: add missing include of asm/io.h

[Takashi Iwai]

At Wed, 28 Jan 2015 15:54:04 +0100,
Arnd Bergmann wrote:
> 
> The soundscape driver uses the ISA inb/outb functions declared
> in asm/io.h, so it needs to include this header to avoid
> a build error:
> 
> sscape.c: In function 'sscape_write_unsafe':
> sscape.c:203:2: error: implicit declaration of function 'outb' [-Werror=implicit-function-declaration]
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Could you correct asm/io.h with linux/io.h in subject and description
to match with the actual change?


thanks,

Takashi

> 
> diff --git a/sound/isa/sscape.c b/sound/isa/sscape.c
> index 018ab140c2be..7b248cdf06e2 100644
> --- a/sound/isa/sscape.c
> +++ b/sound/isa/sscape.c
> @@ -23,6 +23,7 @@
>  
>  #include <linux/init.h>
>  #include <linux/err.h>
> +#include <linux/io.h>
>  #include <linux/isa.h>
>  #include <linux/delay.h>
>  #include <linux/firmware.h>
> 

[PATCH] sound: sscape: add missing include of linux/io.h

[Arnd Bergmann]

The soundscape driver uses the ISA inb/outb functions declared
in linux/io.h, so it needs to include this header to avoid
a build error:

sscape.c: In function 'sscape_write_unsafe':
sscape.c:203:2: error: implicit declaration of function 'outb' [-Werror=implicit-function-declaration]

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Sorry about messing up the patch description the first time. I'm cleaning
out old patches from a randconfig build tree and I found this one was
still needed but did not inspect the changelog closely enough.

diff --git a/sound/isa/sscape.c b/sound/isa/sscape.c
index 018ab140c2be..7b248cdf06e2 100644
--- a/sound/isa/sscape.c
+++ b/sound/isa/sscape.c
@@ -23,6 +23,7 @@
 
 #include <linux/init.h>
 #include <linux/err.h>
+#include <linux/io.h>
 #include <linux/isa.h>
 #include <linux/delay.h>
 #include <linux/firmware.h>

Re: [PATCH] sound: sscape: add missing include of linux/io.h

[Takashi Iwai]

At Wed, 28 Jan 2015 16:04:46 +0100,
Arnd Bergmann wrote:
> 
> The soundscape driver uses the ISA inb/outb functions declared
> in linux/io.h, so it needs to include this header to avoid
> a build error:
> 
> sscape.c: In function 'sscape_write_unsafe':
> sscape.c:203:2: error: implicit declaration of function 'outb' [-Werror=implicit-function-declaration]
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> Sorry about messing up the patch description the first time. I'm cleaning
> out old patches from a randconfig build tree and I found this one was
> still needed but did not inspect the changelog closely enough.

Thanks, applied.


Takashi

> 
> diff --git a/sound/isa/sscape.c b/sound/isa/sscape.c
> index 018ab140c2be..7b248cdf06e2 100644
> --- a/sound/isa/sscape.c
> +++ b/sound/isa/sscape.c
> @@ -23,6 +23,7 @@
>  
>  #include <linux/init.h>
>  #include <linux/err.h>
> +#include <linux/io.h>
>  #include <linux/isa.h>
>  #include <linux/delay.h>
>  #include <linux/firmware.h>
>